From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FFE2C021A8 for ; Sat, 14 Sep 2024 17:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EQmXl/GmKhm4/80aM/NWJRvpOYShImP18T+P1c5Ur2k=; b=EgSZPP2+z/nq79/gZKjasVDhzo JhdjraYXwoqHDb4or0HUiHnqWpyd2mRRc0Oh70Iz3eMQ61aKRG3NTYWgNzi3pJG5t0CoJHeD/vcyO 4PimwV2FTjCoirLj0JpBFiSD/7ddewGtT7wo+J9FL8NcqX/RvE4iM5EZv9wfYfq/kf7YHoNAfjUmA w0DUXa6WepECBpvvU9y78b0Fd4I2tRg2MFlJzwQUSP65OX42UgAYMdYocCpfy+DHFqGVPohY2ShVj +WPGSZeRDQCeGDWVQsXNBaAfDwkcbsU+tV2DFUm7+FG0FZiJPLWwbNEjIZHBCvWGJEU7ddX/qOsEg /aJUiNNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1spX1P-000000013yU-0OcH; Sat, 14 Sep 2024 17:57:23 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1spX0J-000000013rG-0moM for linux-arm-kernel@lists.infradead.org; Sat, 14 Sep 2024 17:56:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 08515A4009B; Sat, 14 Sep 2024 17:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78388C4CEC0; Sat, 14 Sep 2024 17:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726336573; bh=usg5zuvL6dMiMtReqxAmcXPlYBF1AWzxevclY567A/4=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=BCKnMStk0KD+KF5iLNc2XB3G3YDXTC7IF5zt1upbDpbkyTewGa+L+bN3T+QCIm+/Y dcUP4wpxJ5OVej1SrXlGVNH6rMQsZ8gFAsxwg3lKkaE7rzFkVGFbcQIkMnzvhVM6Kr M5RTY7BxqmGcL3I30T4qtMRxT9JvvK30B023vO8c= Date: Sat, 14 Sep 2024 19:56:09 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: Arturs Artamonovs , Greg Malysa , Nathan Barrett-Morrison , Utsav Agarwal , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, soc@kernel.org, Andi Shyti , Arnd Bergmann , Bartosz Golaszewski , Catalin Marinas , Conor Dooley , Jiri Slaby , Krzysztof Kozlowski , Linus Walleij , Michael Turquette , Olof Johansson , Philipp Zabel , Rob Herring , Stephen Boyd , Thomas Gleixner , Will Deacon , LKML , adsp-linux@analog.com Subject: Re: [PATCH 01/21] arm64: Add ADI ADSP-SC598 SoC Message-ID: <2024091459-company-diabolic-a9ed@gregkh> References: <20240912-test-v1-1-458fa57c8ccf@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240914_105615_694380_74A36DF4 X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 14, 2024 at 07:15:08PM +0200, Markus Elfring wrote: > … > > +++ b/drivers/soc/adi/system.c > > @@ -0,0 +1,257 @@ > … > > +static void adi_system_config_remove(struct platform_device *pdev) > +{ > > + struct adi_system_config *config = platform_get_drvdata(pdev); > > + unsigned long flags; > > + > > + spin_lock_irqsave(&adi_system_config_lock, flags); > > + list_del(&config->list); > > + spin_unlock_irqrestore(&adi_system_config_lock, flags); > > +} > … > > Under which circumstances would you become interested to apply a statement > like “guard(spinlock_irqsave)(&adi_system_config_lock);”? > https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/spinlock.h#L572 > > Regards, > Markus > Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot