From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84D36C3ABA2 for ; Mon, 16 Sep 2024 16:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v+hhzF+vg3G7WuRyUB5TA+AZlfqxVkuVcx1rSSh2dfM=; b=1VTS8SMhwlv2+N9Y3kloYt0eCK oMTxiZYrhxEBorcni0Ivg7eU5SUZS2DmsbiFYBvGqF7FMLwAEYjc7bK3XeFRkffAMs7NPiZ+GZ8qq ReNUy5bTGelcwFnF5orbCb/hoE7qiQMe+t7/BXvuMNO1Rh+PFZH79aMeQlQwoFqB0sD4mopedee+E L2jZY5Ej0Flodbv4tdPOP2PagAb4F2TUXCtrRCXFlSvVCDmxNL5MC/wwXT+gjuExbKI6T23wXMMX0 mZOQBA+/oazc1D9amQt40VT4UrOVHrXPkqHwaYrPICUMvTZ8K3nea2fFwr6DtIc7tSSbKqaIQlPPG +7T1z6mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqEkk-00000004UIU-0Ca4; Mon, 16 Sep 2024 16:39:06 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqEfj-00000004Tbi-2mfJ; Mon, 16 Sep 2024 16:33:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E30DBA4319E; Mon, 16 Sep 2024 16:33:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 085B2C4CEC4; Mon, 16 Sep 2024 16:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726504434; bh=QqNjHfV+bL/edqLFl7taMwluNBafAR8LxONwNNjOAcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dCtmew8RuqFe0tIQcMcetN0cyzAHNDgdFZ96zEVYKfPmrkzcqwxb+1XhE7mAjR4uI RxKQ7chmm1h6BYcrJXRsxT9njZjF6rjVr0+FErjNGqUjkGMgLomRcrQxQHUOufoZJK Q56W8acdw/sfpxF1s6kcXcgR8FGgDk6g+4J46bIvaZvjNqkg6QWpFrERfBpIDB/XcV E/fo1OC8fdawkQS+t1f6RjqYhvTh85RgAYOKLCkZYpFZm0daWBK6XVkr3QJR6wOdPB TaLIt9sTOdxyZSoRXm/ItCMVC4RyphBNSwbYFAbtvvNYR+Sf4AIy7i2/X5hFkFSFTX 9HSjvaOEucs7w== Date: Mon, 16 Sep 2024 17:33:49 +0100 From: Conor Dooley To: Yao Zi Cc: Heiko Stuebner , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: Possible misleading information in rockchip,rk3588-cru.yaml Message-ID: <20240916-neuron-surfer-32db6440e1ad@spud> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="762l3reB4+o5LV48" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240916_093355_791623_759C1754 X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --762l3reB4+o5LV48 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 11, 2024 at 09:20:02PM +0000, Yao Zi wrote: > Hi, >=20 > rockchip,rk3588-cru.yaml, dt-binding for RK3588 clock and reset module, > contains description of customized property "rockchip,grf", >=20 > rockchip,grf: > $ref: /schemas/types.yaml#/definitions/phandle > description: > > phandle to the syscon managing the "general register files". It is > used for GRF muxes, if missing any muxes present in the GRF will > not be available. >=20 > But after doing some searching, I found that clk-rk3588.c actually > defines no clock hardware with MUXGRF type. This is also true in in the > vendor code[1], it seems there is actually no GRF mux on RK3588 > platform. Have you been able to check the datasheet/register map for this piece of hardware? Does it have a grf register region? Wouldn't be surprised if it didn't, and the cause of it being in the binding was nothing more than copy-paste. --762l3reB4+o5LV48 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZuhd7QAKCRB4tDGHoIJi 0sfLAP4rUDigw1FDwiNdvnZREugTaL9WpuIT1BHZHS4TrWxCZgEApyjlEt72BdfD fapeDQzlfMZjPRcI/2jXPFZkPzGcuw8= =2kPB -----END PGP SIGNATURE----- --762l3reB4+o5LV48--