From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D858C3ABB2 for ; Mon, 16 Sep 2024 10:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S/GA9yRiwtcFQ7dDPsBs3vafpeHgegXdK3i5eFOjlrE=; b=qjQE17SpumAQ7halrkiCiXQfoF Vlyib1WPRF+Guqn7ZJk4+FlpUpR5x30mOiO91w8551f4EmA2ZXmcmeekO3oRLRkPicCQiScYXnCFs M29YuBQ+01znAiF3LXlesQepw0F7FK6V9JR5U14r0BBl3IT5Ps6mMLLNrecdurjHg25sj9fvhX3Gt B2vt34t6MPEys8TH8KNNQsolONaaZ9zyAoL/ln6ttWfqHwZE0shDG22ktE+mwHhbbeVoDedY5g9Ox LS35eexrrANK+mPWE8Ro2SLfeZ5KunYNvb5kdeA+VNtbCXYuEUvPMvFXPdYi83qgrhlmkDhBwdTId CNKdiiKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sq8XW-00000003dln-1uwH; Mon, 16 Sep 2024 10:01:07 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sq8WO-00000003dat-3weo for linux-arm-kernel@lists.infradead.org; Mon, 16 Sep 2024 09:59:55 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id BAB121C0002; Mon, 16 Sep 2024 09:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1726480788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S/GA9yRiwtcFQ7dDPsBs3vafpeHgegXdK3i5eFOjlrE=; b=CLlx0GqpFLOoKOsTbqczn9UjiUC6hFcUmGm3nmVJDV771RcVNJIocsC0521z8vtTrypv2w aAoq9AeAc7RZgcByh7Blu/jp/7pvG5FsYB9EIAC1ydODZReuSKuXu9ufsnfmL6BHDzZ/pk Am6ec45fockeSiloFkGig26k0HF912tDPlQNZ0QwwMQDxooB8c1lFnbijsx6S/OsOJoRKM Vd+RhsnQGGQGRgXUJxquG2+NQaOj85qSs6HLUmgibD2l9dcsRCundb6V5uuwXizD+nLvD9 l3SCOXvYnLa2kvcwcz17u6CjmztORgoub61SVAvtQo8cRgswcx+73cn37m5AQA== Date: Mon, 16 Sep 2024 11:59:47 +0200 From: Alexandre Belloni To: Andrei Simion Subject: Re: [PATCH 2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation Message-ID: <202409160959473da37eea@mail.local> References: <20240916085214.11083-1-andrei.simion@microchip.com> <20240916085214.11083-3-andrei.simion@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240916085214.11083-3-andrei.simion@microchip.com> X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240916_025953_595940_61D7B188 X-CRM114-Status: GOOD ( 18.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, linux-sound@vger.kernel.org, perex@perex.cz, broonie@kernel.org, claudiu.beznea@tuxon.dev, Codrin Ciubotariu , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/09/2024 11:52:15+0300, Andrei Simion wrote: > From: Codrin Ciubotariu > > Drop S24_LE format because it is not supported if more than 2 channels > (of TDM slots) are used. This limitation makes it impractical for use cases > requiring more than 2 TDM slots, leading to potential issues in > multi-channel configurations. > > [andrei.simion@microchip.com: Reword the commit title and the commit > message.] > > Signed-off-by: Codrin Ciubotariu > Signed-off-by: Andrei Simion > --- > sound/soc/atmel/atmel_ssc_dai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index 7047f17fe7a8..475e7579c64c 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -822,7 +822,7 @@ static int atmel_ssc_resume(struct snd_soc_component *component) > } > > #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ > - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) > + SNDRV_PCM_FMTBIT_S32_LE) I believe this requires a comment. Else someone may add it back later on. > > static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { > .startup = atmel_ssc_startup, > -- > 2.34.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com