From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FCE0C3ABB2 for ; Mon, 16 Sep 2024 14:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=knm+SgfwZ9UaN8njARDSqAzh//upppGOTDB0X/DOlB0=; b=Z3pGFA5iNrqI7RPV37Lzm3+A86 yYRxloEFXWj7DYiCS5SZsStb/ngtH/mEOAPIQKhUS0X8HPhA610pchzrrLWxstbi5GqIMakme9UJJ hh6Cg1818SInQymN2AgjJ6o+YXJbtRLS/AElK1zP/zQslAxxyqaldnL073M9q8VNPEpw36Z8sF1d5 FSHTidHe51SSsmzKlDPVLTeedd6lRhZUvuFa+5MfQ8cKuKkFs2Rr3ibzA5FLGChnEgYd1jif20K/Z 3qb4U3sKxfrK2l0cpCFlLUzwcEpynMZE1WnIGVmzBUrlVnRCXM7yAeeuDmo9ShJMfAL7+e6YSFbKY YOM2718A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqCad-00000004CMW-35tA; Mon, 16 Sep 2024 14:20:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqCZY-00000004CF6-1kkh for linux-arm-kernel@lists.infradead.org; Mon, 16 Sep 2024 14:19:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726496362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=knm+SgfwZ9UaN8njARDSqAzh//upppGOTDB0X/DOlB0=; b=Xfxb/MgWEqZPA9xCltn9fpLH9ygdMQ2Ppc/q/Etb5FAa3eQGLgD4VRK77TbCBq2HlGgBvC ZVMF/Qg3ibQBHJxsN/AsHfrOOGEFFdLPHhyaMnOSp/evEVFjGWvr0ZN79SkZJZSsBDkch+ qpVFgsB80kv1w6QsKQQTJYNZfhn76wQ= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-1J4J-k56PqKibycX6NXmdQ-1; Mon, 16 Sep 2024 10:19:17 -0400 X-MC-Unique: 1J4J-k56PqKibycX6NXmdQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A23FB19560AE; Mon, 16 Sep 2024 14:19:14 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.82]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 008DE195605A; Mon, 16 Sep 2024 14:19:09 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 16 Sep 2024 16:19:02 +0200 (CEST) Date: Mon, 16 Sep 2024 16:18:56 +0200 From: Oleg Nesterov To: Puranjay Mohan Cc: Steven Rostedt , Masami Hiramatsu , Catalin Marinas , Will Deacon , Mark Rutland , Mark Brown , Kalesh Singh , chenqiwu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: arm64: stacktrace: WARN_ON(state->common.pc == orig_pc) in kunwind_recover_return_address() Message-ID: <20240916141856.GA10560@redhat.com> References: <20240916102741.GA13899@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240916_071924_600892_58EA5164 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/16, Puranjay Mohan wrote: > > Oleg Nesterov writes: > > > given that kunwind_recover_return_address() passes idx == NULL to > > ftrace_graph_ret_addr(), it should always return ret == state->common.pc ? > > > > > > Perhaps this connects to 29c1c24a27 ("function_graph: Fix up ftrace_graph_ret_addr()") > > and I have no idea if something like the patch below makes any sense. > > > > Your finding is accurate. > > It has been fixed in upstream by c060f93253ca ("arm64: stacktrace: fix > the usage of ftrace_graph_ret_addr()") Yes, I have already found that commit, see my next email ;) Nevertheless, thanks a lot Puranjay for the confirmation! Oleg.