From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AF24C3ABB2 for ; Mon, 16 Sep 2024 14:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QloBWWiiQvJ9odjtbk/ZDUQVWAaXV9wS+D1Lf/XH/qc=; b=fXIaXqLuaxnYvivo9RFMmRYWmO AK39xFD6IPu+GHZai6yltjedDib8kLd0PtxI2ZhQSYxL70U94kyF55UwXnznNed/p7lqDw3fn5HTs QiU9Znf1+urRWoJhr9+b9aqXyxVsh+q4BPvWzpclSEux8dluyxsEKl+xMkYhsGzyvvDeoQo5FNd/F gtT/iTQGCuM3PNw39DoEs+mFvyh5YLFiRJwBCbFi/dX5iQn9z07q7Ob4VjRGg0YLjB+b/HGL0MHiX PJhotsexe8eI5E2M3tk7Vq0FWJIy4JNhLcNynIH4GTfNH4t/mOBTHmqu1CSMvM4r+c7PbacDDMk+Q dGJEKJqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqCnV-00000004Dxc-0WbY; Mon, 16 Sep 2024 14:33:49 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqClM-00000004Dfd-0Tjk for linux-arm-kernel@lists.infradead.org; Mon, 16 Sep 2024 14:31:38 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id E8DBC20007; Mon, 16 Sep 2024 14:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1726497092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QloBWWiiQvJ9odjtbk/ZDUQVWAaXV9wS+D1Lf/XH/qc=; b=BHbjGyh2V5W711FYpda4uynjp9Pj7IzPDyskiBG+W33xrLTe4hJGafNYQ2BkZUdzN7ftwR MKNQPQrkh7rvh1McVuzovwb5SGe3qZU55e/i+nq3VUJyaT2xRkcyf/w7QhgMTfxbrkXdtT D9CppqOIjE+yv2ITa1z4fLQCk/TALo7kZSJHF+bDv2pGIEH+XAU86aXLK9Ej1otx8IdIkV HJv/3VsiYZ3hkmcrS2jSB08bDnpHag2L9lVW6g2bN/C1NXCnZnoTMdhqzZtqTD0pYhxp1T y06RDUJYQNdUjPFF8EsNQkjPlLKkzkj41Z0J0YXmoiiFk7N3VrHoIi+MVVYp0g== Date: Mon, 16 Sep 2024 16:31:30 +0200 From: Alexandre Belloni To: Andrei Simion Subject: Re: [PATCH v2 2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation Message-ID: <20240916143130835e72b4@mail.local> References: <20240916131910.22680-1-andrei.simion@microchip.com> <20240916131910.22680-3-andrei.simion@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240916131910.22680-3-andrei.simion@microchip.com> X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240916_073136_809575_3DB7BB19 X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, linux-sound@vger.kernel.org, perex@perex.cz, broonie@kernel.org, claudiu.beznea@tuxon.dev, Codrin Ciubotariu , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/09/2024 16:19:10+0300, Andrei Simion wrote: > From: Codrin Ciubotariu > > Drop S24_LE format because it is not supported if more than 2 channels > (of TDM slots) are used. This limitation makes it impractical for use cases > requiring more than 2 TDM slots, leading to potential issues in > multi-channel configurations. > > [andrei.simion@microchip.com: Reword the commit title and the commit > message. Add code comment to explain the removed code.] > Reviewed-by: Alexandre Belloni > Signed-off-by: Codrin Ciubotariu > Signed-off-by: Andrei Simion > --- > v1 -> v2: > - add code comment to explain why S24_LE is dropped. > --- > sound/soc/atmel/atmel_ssc_dai.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index 7047f17fe7a8..89098f41679c 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component) > return 0; > } > > +/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */ > #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ > - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) > + SNDRV_PCM_FMTBIT_S32_LE) > > static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { > .startup = atmel_ssc_startup, > -- > 2.34.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com