From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A580CAC5A3 for ; Tue, 17 Sep 2024 21:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UGcn0zgWN/oUdHL/eHDomWGdyBTm6jZFo4BUFtwVohE=; b=4uC194Rh55Rnw84xTmBsv/m4EV jmuN17hep4UIS9dAGDovir4sTNMkteq0V0dXnHRqNj8lvFV/6YYXqFOrptQL1Q8Ysyy5E95BUbU6E 72IgiL4IIQ+X1H0TkG2kxZnijpStBQCc4V0X52kfd/syNEkACstqYHE+aSnHSToROIVd9v1hrT8sB 9Dli1AwfO+aijHmlXqbCrFCaVR/7nbHr0+tP163bOlMe0B4fwAVY04it9ZAVUOuwIn9yAdqEQ1lwX 0dDbas5WsZRWaovuM6gQhVjMFMY6eh0JASiiQ892GQy8GCWDqpylSTmgCA6xWDd2RgBk1OPmiWbX0 xMw16p8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqfXN-00000006wFD-2Jlj; Tue, 17 Sep 2024 21:15:05 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqfWG-00000006w6F-2wva; Tue, 17 Sep 2024 21:13:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 041815C463E; Tue, 17 Sep 2024 21:13:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70DC3C4CEC5; Tue, 17 Sep 2024 21:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726607635; bh=h6tfNn4BixxJYWQYKrDQLr7/eqjQkFy0kULBd/P+I4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TyE8X+GqWp7Z/p5furrj0+eAxM/KsS6HaBJHLmVLo8Koq88/0VSzkyTGN5IKW1HZG OPwMjuyM78k+lDKtOBlMtoDD5NvXGC/HfGb0ZP4s+t0l70B3tkUCXZeU0Q/u/X0M/Q a54APR/wJoX5/8nmIxkF6XPa3vuriJP7Jy7pCGTgpleDJnyjg/vJppLeEKS8rrwkm8 PUV0AxR9m5qcOUzETL8CZ409Ff01O8bxO3wotbiUby33e7RDVvXN89v5cQqtYX4P/C gPYxufC+CdP2VL3vdg9U2I7ilIp5Y6DgI5t6CP5vLyuEb7fjJ4SSh3pNKahZ/CrqYg DQM4Xhac7Mb5A== Date: Tue, 17 Sep 2024 22:13:58 +0100 From: Conor Dooley To: Yao Zi Cc: Heiko Stuebner , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: Possible misleading information in rockchip,rk3588-cru.yaml Message-ID: <20240917-flypaper-december-3719ea838b3c@squawk> References: <20240916-neuron-surfer-32db6440e1ad@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RIDGw94K0j/yawb4" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240917_141356_832668_E6763039 X-CRM114-Status: GOOD ( 27.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --RIDGw94K0j/yawb4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 16, 2024 at 05:38:56PM +0000, Yao Zi wrote: > On Mon, Sep 16, 2024 at 05:33:49PM +0100, Conor Dooley wrote: > > On Wed, Sep 11, 2024 at 09:20:02PM +0000, Yao Zi wrote: > > > Hi, > > >=20 > > > rockchip,rk3588-cru.yaml, dt-binding for RK3588 clock and reset modul= e, > > > contains description of customized property "rockchip,grf", > > >=20 > > > rockchip,grf: > > > $ref: /schemas/types.yaml#/definitions/phandle > > > description: > > > > phandle to the syscon managing the "general register files". It= is > > > used for GRF muxes, if missing any muxes present in the GRF will > > > not be available. > > >=20 > > > But after doing some searching, I found that clk-rk3588.c actually > > > defines no clock hardware with MUXGRF type. This is also true in in t= he > > > vendor code[1], it seems there is actually no GRF mux on RK3588 > > > platform. > >=20 > > Have you been able to check the datasheet/register map for this piece of > > hardware? Does it have a grf register region? > > Wouldn't be surprised if it didn't, and the cause of it being in the > > binding was nothing more than copy-paste. >=20 > Have checked a public datasheet[1], RK3588 does have corresponding grf > region and there are only clock related bits in PHP_GRF_CLK_CON1[2]. >=20 > But these gmac clocks bits are used in dwmac-rk GMAC driver[3] > internally, out of the common clock driver, rk3588-cru. So I don't think > the CRU needs access to the grf by design. That sounds like a reasonable justification for deleting it - but please check U-Boot etc to make sure that other projects are not using this in a different manner to the kernel. If they are not using it, then please send a patch :) --RIDGw94K0j/yawb4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZunxEgAKCRB4tDGHoIJi 0tzwAPsEW69ocfhtVR+GMWt0pS+MPPaBskZvsdl4XuVumMe3NAEAvsgdPy+i81Ec ZX8q4UQyEvwTSKQHOQvpLTNM8UhH0gw= =GlRo -----END PGP SIGNATURE----- --RIDGw94K0j/yawb4--