From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 268FDC35FED for ; Tue, 17 Sep 2024 07:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0ctxh6EHatNfEKj/a1TCaaMo+DnREyCVRKDJamzJcTA=; b=4hHE20ReOP5nQWOJ8Z88yE5PBW d0vq7a9Hw2HP+3WVC4nh48wsiMgkjyhHvwZZmO99rbuZq/dhjMYJZzEIHLDl+8KJIlfPGVABJL6e7 /yPRhCOj7STODn4ojLsRu2Q2NdoI5jQxeG5JT385ftAMpAOzfqg0Cp+RVTuwha68cd13kaVDNFpld PXAeyKdWtUP8f42PqDk3HF+q4LxKyqFz7qb/V5P2vVfCIFmcjlxZiL/4+K15j2gUkBQZUO8EcQiEt VIxzKVl9Yh+gHxmZugMcfE0VtSAFWl9XaIIIpBmfXEAx+/0+bOcrl3gwLmMEQt3C1xykB30aQ72eV 2vG4ELNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqSvR-00000005cwT-31Rz; Tue, 17 Sep 2024 07:47:05 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqSuK-00000005cqp-0tJE for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2024 07:45:58 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 6A8781F9C7; Tue, 17 Sep 2024 09:45:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1726559150; bh=0ctxh6EHatNfEKj/a1TCaaMo+DnREyCVRKDJamzJcTA=; h=From:To:Subject; b=GMTNj07vlNNAvHSkjs9h+CXYzHd3oI0JfRiZ/HOZ3AKx3Syqt2ZbRfgZ02g3ByEqI sFrv0aqx8qzPsSIhkDhEW/fQe7S4WC02W9mvZv2GFE659P3e3cjTr8ZracM0IW3Q3D 6ZBhoKXOqK5sZGuWLcH/Ovzs31BEsTKsK3p2lpxY3kr4gw+OH684fXtaJCR67DiJ80 10AkWd1dLoWFGniJy14/vu2xp2ONRvs476xdVIponkHV2NTAg80445XDSNMKnO3TaB i7/Hd1AQertKt/B9sQZ7k90O7CIqTgZTszEctaozmfsC/w+ssz7bofteSSqnzDocYy qulu7vIvg0FYw== Date: Tue, 17 Sep 2024 09:45:44 +0200 From: Francesco Dolcini To: Krzysztof Kozlowski Cc: Emanuele Ghidoli , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Emanuele Ghidoli , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Shawn Guo , Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Francesco Dolcini Subject: Re: [PATCH v1] arm64: dts: colibri-imx8x: Add ad7879_ts label to touchscreen controller Message-ID: <20240917074544.GA7916@francesco-nb> References: <20240910152213.2072743-1-ghidoliemanuele@gmail.com> <1cfe3f3a-28a3-4030-b6ba-3892a2a7bc79@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cfe3f3a-28a3-4030-b6ba-3892a2a7bc79@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240917_004557_167530_4BF3DC82 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Krzysztof, it seems that this patch requires more explanation, maybe something that should be part of the commit message, let's see ... On Mon, Sep 16, 2024 at 06:10:55PM +0200, Krzysztof Kozlowski wrote: > On 10/09/2024 17:22, Emanuele Ghidoli wrote: > > From: Emanuele Ghidoli > > > > The device tree defines the touchscreen controller, but it cannot be > > enabled because it lacks a reference label. > > It can be. Just enable it... colibri-imx8x is a SoM, it's not a complete self-contained device. The display touch controller is part of the SoM, however it is kept disabled since you need an actual touchscreen to make any use of it. This label would be used where an actual touchscreen is defined, this can happen with a DT overlay, for example. > > This commit adds a label to allow it to be referenced and enabled. > > You changed here nothing. For me this patch is churn and pointless. > You add the label when you need to use it. DT files from the Linux kernel GIT are used also outside the Linux kernel sources, see for example U-Boot OF_UPSTREAM [1], to me it's fair to add a label for an out-of-tree user, am I wrong? Francesco [1] https://lore.kernel.org/all/20240222093607.3085545-1-sumit.garg@linaro.org/