From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 090E1C36006 for ; Tue, 17 Sep 2024 09:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tMgucL+2N64HjHzuwZ+R6uYA/XLaz/Mbws1qhVHbfCY=; b=QEoDTvfCC1MjLGapiRRTLRtaNL jfy7ElC2i/2Xcut39Hz+8lGU/5CQoSW4Bkr2xw+uwyjynJEsEjO5U6P/fJ6zw5wjLZ2ULYONR4UH/ fo2rgbTlNXoIaXNRgkd2YqUanb1FmZH4x7nc/Fq6TH9SMtOBirqt/s5NR8KI+LIUH7oPaaBHz+vXs FAbQAvnLCuPe5LBrkADlE4Pa41Z8N2N5zdzJQxIjV/i+D6yi26NrQbAuyA3aR0URBTu4cCQqDp9pg LctNLJtA+DbseuEkExbQekYZiP1DxrdCA9sUL2xYWs5QJYiiHIitLkmx38kn8FQMtnX4puZGWDvQo J62FbKUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqUxK-00000005tVN-0k6m; Tue, 17 Sep 2024 09:57:10 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqUvx-00000005tGh-2RiX for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2024 09:55:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DF42FA40ED4; Tue, 17 Sep 2024 09:55:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58103C4CEC5; Tue, 17 Sep 2024 09:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726566944; bh=WHbeFH5Td69vGBqxgGhIT2rQhQdb5LE6FSqeOmbeESY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TX1BFEAhm+ZWwoXKsSRcTE128mIgVCrFrDzOfnhgjbI74MPD7etlTl2Nu8f5kmEAH odnIr3Nb6UCpPq31zJbqWeyICExBSR8Mvbv/WY13KbzhuymGLsjjQKQuHgCTunB5A5 X3vBKyOMNSshGpb55BjfdNjWltv6Rfutm8Fu4pSsKl88eq1M/EeKkl56tcthmVWQ1K 9EnNGZnVmlxv9HZGdBc/18YD0i86NfCp8NlF/dFqM9H1gt0RK94joobYPXi404jC93 75fz7rFhMX0vCl8FTlcc/ow9QLYH6wssRCMkBSDAw90yZc5pYTOarC111swTX63pBi 2LoQ6evp0eDrw== Date: Tue, 17 Sep 2024 10:55:39 +0100 From: Will Deacon To: Steven Rostedt Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, "Masami Hiramatsu (Google)" , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Alexei Starovoitov , Jiri Olsa , Arnaldo Carvalho de Melo , Daniel Borkmann , Mark Rutland Subject: Re: [PATCH v14 04/19] function_graph: Replace fgraph_ret_regs with ftrace_regs Message-ID: <20240917095538.GA27384@willie-the-truck> References: <172615368656.133222.2336770908714920670.stgit@devnote2> <172615373091.133222.1812791604518973124.stgit@devnote2> <20240915051144.445681c2@rorschach.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240915051144.445681c2@rorschach.local.home> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240917_025545_724314_A963E595 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 15, 2024 at 05:11:44AM -0400, Steven Rostedt wrote: > On Fri, 13 Sep 2024 00:08:51 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Masami Hiramatsu (Google) > > > > Use ftrace_regs instead of fgraph_ret_regs for tracing return value > > on function_graph tracer because of simplifying the callback interface. > > > > The CONFIG_HAVE_FUNCTION_GRAPH_RETVAL is also replaced by > > CONFIG_HAVE_FUNCTION_GRAPH_FREGS. > > > > Signed-off-by: Masami Hiramatsu (Google) > > --- > > Changes in v8: > > - Newly added. > > --- > > arch/arm64/Kconfig | 1 + > > arch/arm64/include/asm/ftrace.h | 23 ++++++----------------- > > arch/arm64/kernel/asm-offsets.c | 12 ------------ > > arch/arm64/kernel/entry-ftrace.S | 32 ++++++++++++++++++-------------- The arm64 part looks good to me, although passing a partially-populated struct out of asm feels like it's going to cause us hard-to-debug problems down the line if any of those extra fields get used. How hard would it be to poison the unpopulated members of 'ftrace_regs'? Will