From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 301C0C3601E for ; Tue, 17 Sep 2024 14:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vQlfje8RzrGkZL2VqWknD0uNiWO5cAU70iaVLEwLNAU=; b=lWWrTjCGrc2tGwdvy/gZptc91w 0m9BKpHe5H64kbYHInLHJYQQM2DdPuGxquV8CxjIKT61f/RbhYGG+y6CUpmhf1tlyZ35XuBGbLvcV tw73rI8f4AYf9JssVDyo10PtfWEZHzrdV7HXdNJyUi/QlLWzYA/gkojS2iabfnbupFnSmYL4p/eMh wKyyxogBkOrxoOkC79vASrFjLWfUrTfNxqp85VCEKqeUxPvrkJQL3OPlRPSj36he0j1Bn5OoAOQU3 Fs+RtLC4XprV+oa9BnjmdLSPIuP7f7pXJIEA/WHDUdhH37KAtw1YvS60Sp0oye1w4tr7SVf40rQ6p iZLQr2Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqYzG-00000006I0E-2I7V; Tue, 17 Sep 2024 14:15:26 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqXpX-00000006BDs-2Fph for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2024 13:01:22 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 86FD21BF20C; Tue, 17 Sep 2024 13:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1726578075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vQlfje8RzrGkZL2VqWknD0uNiWO5cAU70iaVLEwLNAU=; b=L65FQO4iMpdZMyY+qPrsMRQ50jSWU2ygXHMRw3RA7fsdQOm81tYUl+GSn+x5dLKr0UPIxb sOlegEAWN5N4XlefLr7ICeppeFTkaYBBbLwzMyH3PTZoFhVnBsI69RbZGae0RAb0dIV02X 8L5ZD5DFLtZpJ2Jy0CzrS3HdPc9sKIAAu44cTrHPDLBE5zHVHQOQa9G6OFGqu9lB4fEL7Q m6nxqZQF4MwdkskvdHSveY6oP1y/0QQgsCfW9n2oDcsB1vnc9Tdup5uW86MxXTYZ9gQc/2 6QPfZWisAPbjh0HhV7zmF7Pk0QU6EgtjniT4QOqf0NqYpgq8wOmoUN4HePb4Ag== Date: Tue, 17 Sep 2024 15:01:13 +0200 From: Alexandre Belloni To: Ciprian Marian Costea Cc: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Bogdan-Gabriel Roman , Ghennadi Procopciuc Subject: Re: [PATCH 1/4] dt-bindings: rtc: add schema for NXP S32G2/S32G3 SoCs Message-ID: <20240917130113daecdd5b@mail.local> References: <20240911070028.127659-1-ciprianmarian.costea@oss.nxp.com> <20240911070028.127659-2-ciprianmarian.costea@oss.nxp.com> <20240911-racism-playmaker-71cb87d1260f@spud> <62ba70ca-429e-476c-bb7b-78f743574a68@oss.nxp.com> <2024091212260302903af7@mail.local> <2815dcf8-bb90-4e3f-837d-2c2a36a8744e@oss.nxp.com> <202409121403232ab1295b@mail.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240917_060120_460230_F603AC30 X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/09/2024 10:21:32+0300, Ciprian Marian Costea wrote: > On 9/12/2024 5:03 PM, Alexandre Belloni wrote: > > On 12/09/2024 15:36:46+0300, Ciprian Marian Costea wrote: > > > > Then should this mux be registered in the CCF so you can use the usual > > > > clock node properties? > > > > > > Hello Alexandre, > > > > > > In hardware, these clock muxes and divisors are part of the RTC module > > > itself and not external. Therefore, I would say no. > > > > This is irrelevant, if this is a clock mux, it must be in the CCF, just > > as when the RTC has a clock output. > > > > > > I understand your point, but taking into account the fact that FIRC clock > should be used in most scenarios, would it be acceptable to not export this > 'clksel' property in the devicetree bindings and simply use the FIRC clock > by default in the RTC driver ? > No, this doesn't work for RTCs because their lifecycle is longer than the system's and f you change a configuration from the default value without providing a way to control it, we won't have any upgrade path without breaking users. > At least for this patchset, in order to ease the review process. If > configurable clock source support would want to be enabled and exported via > bindings for this S32G2/S32G3 RTC driver, then CCF registration for this clk > mux could be added in future patches. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com