From: Simon Horman <horms@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Andy Chiu <andy.chiu@sifive.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Paolo Abeni <pabeni@redhat.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Sean Anderson <sean.anderson@linux.dev>
Subject: Re: [PATCH] net: xilinx: axienet: Reduce scopes for two resources in axienet_probe()
Date: Sun, 22 Sep 2024 17:59:52 +0100 [thread overview]
Message-ID: <20240922165952.GC3426578@kernel.org> (raw)
In-Reply-To: <2e6f6f8f-89de-4b75-a0af-3a55bc046ab7@web.de>
On Fri, Sep 20, 2024 at 11:22:47AM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2024 11:08:10 +0200
>
> The calls “dma_release_channel(tx_chan)” and “of_node_put(np)”
> were immediately used after return value checks in this
> function implementation.
> Thus use such function calls only once instead directly before the checks.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Hi Markus,
This change seems reasonable to me. However, I am assuming that as a
non-bug-fix, this is targeted at net-next. And net-next is currently
closed for the v6.12 merge window. Please consider reposting this patch
once net-next reopens. That will occur after v6.12-rc1 has been released.
Which I expect to be about a week from now.
Also, for networking patches please tag non-bug fixes for
net-next (and bug fixes for net, being sure to include a Fixes tag).
Subject: [PATCH net-next] ...
Please see https://docs.kernel.org/process/maintainer-netdev.html
--
pw-bot: defer
prev parent reply other threads:[~2024-09-22 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 9:22 [PATCH] net: xilinx: axienet: Reduce scopes for two resources in axienet_probe() Markus Elfring
2024-09-22 16:59 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240922165952.GC3426578@kernel.org \
--to=horms@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=andy.chiu@sifive.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).