From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7268CF9C69 for ; Sun, 22 Sep 2024 17:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WeNNfb15Y3nh9V9yc2oB0Qsgb9o6VPE6UfNtOe7HsPM=; b=aCA1Yox1f7QYkQcUxzeyLCotCo U7uEECMs+Y65Hn5/kFzHwJipSdl34DB85cny6HSbYQKNJ0VdzhmNU2SaSSgQywJFP8yAiPJjgYwab PH721N815spvz1kenRECht4/lGc6cqtjNsGlZ8FGp8507rpFjLkVtGUeyzXLPBA7FRFQkyqCLDm2F wiajk79p9cXaG/HcKr4Osq0ZWqHk9RI4FGiIAlLiy/HGqoWMaZ9x8dmrL1zso8NbQJ0OtWFefJGhN Km636X1u4pSM3z40OZwnBt/+NO2n+Qp9l0jAtEoE3XaeNqVH5q3Z44UjSJJ3B1IvV7hRl7eNGGMyh 5onTC8Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ssPxN-0000000FT0j-16Oq; Sun, 22 Sep 2024 17:01:09 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ssPwE-0000000FSsJ-2kwr for linux-arm-kernel@lists.infradead.org; Sun, 22 Sep 2024 17:00:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 36F13A40F1A; Sun, 22 Sep 2024 16:59:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DD98C4CEC3; Sun, 22 Sep 2024 16:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727024396; bh=SCLexZ/RaMKo8XOThB7Kxlr0ZTSGEF/eJ+/2S0nvWGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b3gCPh7yJjD4E02kksOsCOvatAABfNwvb00eajBsAjgXdil3AoNGw6wFXe1sjymca CV8bJA547vrwEtIZfYFJl/jhA1iC97jn1ChV4AKAClmfi4jJF+0JCY4JiO3tuvcV9b 3lO/7IsbcO0G9koeAnlmt9ACsMCDLdxMJvR884Yn7lIWKappC9Glxo6RA+emLPwfU/ js5rjrhRUfM1dlNGlq9wXX75ql2e628mgLtD7/wRUo/hnOaTy1S5SG9rmYrB/TZXCR 3FlGvnyLMUnlSUFk8go/MaeXU/AG3FrOrJG6ZUb5cEOnI3phE9tDpRenR+uqodCGbn pjUfy6CXilGHA== Date: Sun, 22 Sep 2024 17:59:52 +0100 From: Simon Horman To: Markus Elfring Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andy Chiu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michal Simek , Paolo Abeni , Radhey Shyam Pandey , LKML , kernel-janitors@vger.kernel.org, Sean Anderson Subject: Re: [PATCH] net: xilinx: axienet: Reduce scopes for two resources in axienet_probe() Message-ID: <20240922165952.GC3426578@kernel.org> References: <2e6f6f8f-89de-4b75-a0af-3a55bc046ab7@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2e6f6f8f-89de-4b75-a0af-3a55bc046ab7@web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240922_095958_784126_D926D524 X-CRM114-Status: GOOD ( 13.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 20, 2024 at 11:22:47AM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 20 Sep 2024 11:08:10 +0200 > > The calls “dma_release_channel(tx_chan)” and “of_node_put(np)” > were immediately used after return value checks in this > function implementation. > Thus use such function calls only once instead directly before the checks. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Hi Markus, This change seems reasonable to me. However, I am assuming that as a non-bug-fix, this is targeted at net-next. And net-next is currently closed for the v6.12 merge window. Please consider reposting this patch once net-next reopens. That will occur after v6.12-rc1 has been released. Which I expect to be about a week from now. Also, for networking patches please tag non-bug fixes for net-next (and bug fixes for net, being sure to include a Fixes tag). Subject: [PATCH net-next] ... Please see https://docs.kernel.org/process/maintainer-netdev.html -- pw-bot: defer