From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46D4BCF9C6F for ; Mon, 23 Sep 2024 21:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4nJiFXN9qZGjYATN+GpANSWIL3yCAttlmDjXVvB/zc8=; b=WduLTFSRhX/3LybXcCHlDWwYCc IG4LVq2cgg0cULtO54M/naEjd6WJoHHyWKAbtbemMe+vtpECTsIIyYz7sbzsRurC926OHdVaayQKX pm2nBjjx3BrfjMzWFajOMNbilnDHaknO6jjRxM9uOqmy5nwuvC2Q4WtIUhYQjDYBZoV77buUrZLmX drn+xWZvnO/QPRoBRsxHMmgRUR2TtYl75S7GlXHkklY0OFrZXRqoqR/HOHUwRe014GMZ514j3GAKY X4YJqtHC/Birn0tcoSEXE0bOFMziH21mC4WI3wXx0xMZuHhF8FWE9k18eKwO2qznvnVGWky25pkcP u8j5lvrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ssqiH-00000000WM8-47DH; Mon, 23 Sep 2024 21:35:21 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ssqhA-00000000WGp-0f1l for linux-arm-kernel@lists.infradead.org; Mon, 23 Sep 2024 21:34:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1614CA42857; Mon, 23 Sep 2024 21:34:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABAE3C4CEC4; Mon, 23 Sep 2024 21:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727127250; bh=vVPOUctwnyfB+YD2bNXn8oVlRQeRez4f3tU2z/4oPAM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B69oEG9iR2lkgbaavaQIF+rGFjkOhAxIFSb0gLR/US8dDlU1t8itdFNSvLN4acSWA uezOSixDb4nZ2qizKSmVEHl/IMoat2cNQHh7Gzad5EwtM1/xgfzt10u8K2QbMaao0L kczydm+8kjvJEHutG8lKOn3DIvS9fWlk2UEoUU3EcovPOOqtgKGXlb7VsALziJSGom kFb4E1a8b57vx9oP9Drip8Qa6rwlMpEsVTB2p19364RtE40O0KsvlKLLI4Kw3YwICn pKQENBXWRVORwjwV7gMn3fzyBKIqtVnqv6CpprlMDRlz0jb8oijEvymnwBBpLRuK/d 1CcAHKmZAjuFQ== Date: Mon, 23 Sep 2024 22:34:05 +0100 From: Conor Dooley To: Andrei Stefanescu Cc: Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chester Lin , Matthias Brugger , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team Subject: Re: [PATCH v3 2/4] dt-bindings: gpio: add support for NXP S32G2/S32G3 SoCs Message-ID: <20240923-rentable-okay-922af44b66c8@spud> References: <20240919134732.2626144-1-andrei.stefanescu@oss.nxp.com> <20240919134732.2626144-3-andrei.stefanescu@oss.nxp.com> <20240920-reapply-amusement-a37cf13fd910@squawk> <16950e81-e0ef-4e7c-b0ef-4f56415dceed@oss.nxp.com> <20240921-party-glass-bfb7099c7ded@spud> <20240922-plug-legible-74f56d898123@spud> <3b51ff7b-ab9b-431c-a43a-49b5a5e74dff@oss.nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D4I/hfqMmYR9lhb8" Content-Disposition: inline In-Reply-To: <3b51ff7b-ab9b-431c-a43a-49b5a5e74dff@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240923_143412_342315_20C409CC X-CRM114-Status: GOOD ( 20.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --D4I/hfqMmYR9lhb8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 23, 2024 at 01:47:25PM +0300, Andrei Stefanescu wrote: > Hi, >=20 > On 23/09/2024 00:07, Conor Dooley wrote: > > On Sun, Sep 22, 2024 at 11:04:22PM +0200, Krzysztof Kozlowski wrote: > >> On Sat, Sep 21, 2024 at 10:58:46PM +0100, Conor Dooley wrote: > >>> On Fri, Sep 20, 2024 at 03:40:31PM +0200, Krzysztof Kozlowski wrote: > >>>> On 20/09/2024 15:33, Andrei Stefanescu wrote: > >=20 > >>>>>>> +properties: > >>>>>>> + compatible: > >>>>>>> + items: > >>>>>>> + - const: nxp,s32g2-siul2-gpio > >>>>>> > >>>>>> Commit message and binding description say s32g2 and s32g3, but th= ere's > >>>>>> only a compatible here for g2. > >>>>> > >>>>> Yes, the SIUL2 GPIO hardware is the same for both S32G2 and S32G3 S= oCs. I plan > >>>>> to reuse the same compatible when I add the SIUL2 GPIO device tree = node for > >>>>> the S32G3 boards. Would that be ok? > >>>> > >>>> There are only few exceptions where re-using compatible is allowed. = Was > >>>> S32G on them? Please consult existing practice/maintainers and past = reviews. >=20 > I will add another compatible: "nxp,s32g3-siul2-gpio" for the S32G3 SoC. = We currently > also have the SIUL2 pinctrl driver in upstream with only one compatible: > "nxp,s32g2-siul2-pinctrl". Should I also send a separate patch to add an = S32G3 compatible > to it? >=20 That would be great, thanks. --D4I/hfqMmYR9lhb8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZvHezQAKCRB4tDGHoIJi 0pCmAQC1egpDgRJ3lx7CnNAI1DfohfH3FYOvN94njKldOAyNOgEAjqcWytfOQc+G sRWY+YJMcy6ZEW7clxmqi0OwPbJBmws= =R/oF -----END PGP SIGNATURE----- --D4I/hfqMmYR9lhb8--