From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E99ECF9C6B for ; Tue, 24 Sep 2024 10:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qjRcD8XaCQtfC+CXj8B3RS3iMr5qqtfxn/9w1+Vpwoo=; b=txp216YezqJFWtrJ9ZYSaVvlTr A3Bx/Exfz8g1UTjhDlwMslZoP2TcbqxZaVBTS5TPVp85nteP3mQZDHN0blY/Bsm/3rNESJlrTNDkA iC44DDigwWNW9hwBqFqRFn9VCJvllSeLc7glcoBqEzfYQezqx5pt6EgtOJtLzOpBiaJpRqYDA9inW RGVTa+PtKdiBHygPwGX2+G2Uop/ErkkRbNHfx23ZHQLi95I/i1QDbTC+kkXF/J4ipyX067QNpveyw tQFl8C3wKvQqyEmnnGN7kG9AlgV9GMPqr3gm3DhVM44Nn9Zw1Kw3LmgY+rMK8+KapfjGQvCO9hCjX b/4SZFwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1st2Vq-00000001xLR-0EOV; Tue, 24 Sep 2024 10:11:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1st2T6-00000001wig-07W5 for linux-arm-kernel@lists.infradead.org; Tue, 24 Sep 2024 10:08:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 44E9B5C0406; Tue, 24 Sep 2024 10:08:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6654DC4CEC4; Tue, 24 Sep 2024 10:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727172505; bh=qjRcD8XaCQtfC+CXj8B3RS3iMr5qqtfxn/9w1+Vpwoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SqzYzQp93dGUwuK3crgxPjosYaZsJEloYZeMqEihgotzZQM/CDv8CASzjYnufILO5 taIViMjN5jBlchcv6+6gBgO/UxbQbixJvRaO4uwSENJ6IYUPZjYs4nw6NxJRa1MmRa AjrKROcGgot0hbWzNsynhn72O8xNROSGRUMMAzlm2ilYTLu4FIefRlrh2MCwAZY1l1 JEunDpHWEfS0EUeDmr9/MPgYV/zsQ5yB4UhciO6ZVy0K5bmj6Y7juXBbtiVcx7++ex EIPfX47cskTKbsSMV/qGaPYbgpu3LMhRX7iZhi2W6aCfVBLKzh6IvnmlSQKsGTjJ3X VK7f45vLMyBSg== Date: Tue, 24 Sep 2024 11:08:20 +0100 From: Conor Dooley To: Richard Zhu Cc: l.stach@pengutronix.de, kwilczynski@kernel.org, bhelgaas@google.com, lpieralisi@kernel.org, frank.li@nxp.com, robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe Message-ID: <20240924-ended-unlaced-cc7ddf87af90@spud> References: <1727148464-14341-1-git-send-email-hongxing.zhu@nxp.com> <1727148464-14341-2-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QPsNdq4s/PN2L3Fw" Content-Disposition: inline In-Reply-To: <1727148464-14341-2-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_030828_197328_DB9797B1 X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --QPsNdq4s/PN2L3Fw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 24, 2024 at 11:27:36AM +0800, Richard Zhu wrote: > Add one ref clock for i.MX95 PCIe. Increase clocks' maxItems to 5 and > keep the same restriction with other compatible string. >=20 > Signed-off-by: Richard Zhu It'd be really good to mention why this clock is appearing now, when it did not before. You're just explaining what you've done, which can be seen in the diff, but not why you did it. --QPsNdq4s/PN2L3Fw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZvKPlAAKCRB4tDGHoIJi 0gdqAP9OZE7f2j2BJ6kK0OX4ojssKFgoNCVvarSmVjUoswwluAD9GJRlsy4e4cVO V+bFllNycrn9H5nOyRGfT0fu8JdWTw8= =I93h -----END PGP SIGNATURE----- --QPsNdq4s/PN2L3Fw--