From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFEF7CF9C6F for ; Tue, 24 Sep 2024 16:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U92bSuEAZjnU4w+FGU/py+Q//Fe1SulLSbofqyLyPhg=; b=Aggvjid1B6os7U7jvNIPIP53HR DQPqDdBCTtzAjUoPA0NCNg56AKO89XGNyMv5Yl+H1WbMSmhiYkVyZB1syQ5PTz0uyR1AbYiN5uCT+ 6UydCXGDbwHy3NthO4Edhxau7BaoWy+liHJK7TE93JOdA4q83ciQ095HKJidmEgNvJu6kcv44zSCF V60t8F6U9FjrAhTnd025uPVSsVZF0gt1YQdlXI0RqY2FTPLdLQ8Aa9mAvlzyDsRVnbGluooyyD6vH CUuw1YqiQGkjUncCX/sxv0vvuc0XxWmDQSl+Sf+ZzoDHwpN2FuGqtn5MHEBbL4n8/ku99aATEJcXv UFpzT4aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1st82j-00000002jvR-3jmw; Tue, 24 Sep 2024 16:05:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1st81Y-00000002jXi-3ZtV for linux-arm-kernel@lists.infradead.org; Tue, 24 Sep 2024 16:04:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 18F595C583A; Tue, 24 Sep 2024 16:04:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19A4CC4CEC7; Tue, 24 Sep 2024 16:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727193863; bh=U92bSuEAZjnU4w+FGU/py+Q//Fe1SulLSbofqyLyPhg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pJ4yEG9beL4nwlPOLmbryx5h75ub112hfFpa8teutRosJNeJVXJ0kWmX0xXWXITf0 bFJPKsJKg9Ks9T1cbndwhb8va9OCsjSgICncZG0raZWYqy0Ai6lGKts2zE8o6XrKZS exvhIKnqi4iXflPDvO/ZKhFYOfPphrg8nK3xfZ76hr+XHfe239Hjq98QlqeQ3tDHZS gg8HL9p4wSZChyjMFsh4sLv2yOAb77WsZ5E6kJP7c1JP2mvDlgHswDjq69vdMKb4eg mCKQ4ZOLPCGWAEp8nbhOaR5y3Lk2KprJlVzJNlil4Ywhp6TPSJkbaMBTZVlUzkoCpe 0tVVNVvhCV3Jw== Date: Tue, 24 Sep 2024 17:04:18 +0100 From: Conor Dooley To: Frank Li Cc: Richard Zhu , l.stach@pengutronix.de, kwilczynski@kernel.org, bhelgaas@google.com, lpieralisi@kernel.org, robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe Message-ID: <20240924-spoilage-fanfare-357c65b8418e@spud> References: <1727148464-14341-1-git-send-email-hongxing.zhu@nxp.com> <1727148464-14341-2-git-send-email-hongxing.zhu@nxp.com> <20240924-ended-unlaced-cc7ddf87af90@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2y7ZEn7oTFy8mHq6" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_090424_984463_EC6F9AFF X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --2y7ZEn7oTFy8mHq6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 24, 2024 at 11:23:06AM -0400, Frank Li wrote: > On Tue, Sep 24, 2024 at 11:08:20AM +0100, Conor Dooley wrote: > > On Tue, Sep 24, 2024 at 11:27:36AM +0800, Richard Zhu wrote: > > > Add one ref clock for i.MX95 PCIe. Increase clocks' maxItems to 5 and > > > keep the same restriction with other compatible string. > > > > > > Signed-off-by: Richard Zhu > > > > It'd be really good to mention why this clock is appearing now, when it > > did not before. You're just explaining what you've done, which can be > > seen in the diff, but not why you did it. >=20 > Previous reference clock of i.MX95 is on when system boot to kernel. But > boot firmware change the behavor, so it is off when boot. So it need be > turn on when it use. Also it need be turn off/on when suspend and resume. > Previous miss this feature. Please put this in the commit message Richard. Thanks, Conor. --2y7ZEn7oTFy8mHq6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZvLjAQAKCRB4tDGHoIJi 0hOYAP0XcNVPuI7V62UHF/QiRSFVkV0CAHFfd9a51umMSxHx9wEAtYpToWp7Adbl rLzKRXA23fuI970EAdxYZ8ZzmkY9rA4= =Rfph -----END PGP SIGNATURE----- --2y7ZEn7oTFy8mHq6--