From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 492E7CF9C6F for ; Tue, 24 Sep 2024 14:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dfQTsP0vA/xZ7wbPE4mzCRWLqRMSRVWs8MpYHZmYO04=; b=MBbXKS1JhNnOo0y6le0TiipXa4 CtMzvzjsoChVV5188DEH+rpf5CetrEoBzzvmHwCeCoItdMlartezpJ0EhyxJ+RH75XPUa8p6VdtLa B/vHsh7RDtxjTo81ZyvrcWz3owXVIxD5APkkL1wCec5DwEROBrYafPaZDQMmA92SNwBiaRzWbLxdE MIzTRxsL3R+2ieQFdEE+Y9ObVmmJthPraF/G2bgVBFUhUto4x32xiIZi31e+mLeP17yCzq3DegqdC wEcBTcjxkdstHgbdHwV5lGTaS98EUU06WvUaR/bd7EISa1gYWmZ1FFBhSR4moX0P060USl35S7kiR LcGESPEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1st6SM-00000002XUT-1FLX; Tue, 24 Sep 2024 14:23:58 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1st6Pz-00000002Wsy-0ndw for linux-arm-kernel@lists.infradead.org; Tue, 24 Sep 2024 14:21:33 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-42cacabd2e0so48284525e9.3 for ; Tue, 24 Sep 2024 07:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727187689; x=1727792489; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dfQTsP0vA/xZ7wbPE4mzCRWLqRMSRVWs8MpYHZmYO04=; b=DJ7A9GXWBl903wXwrB4W0MnKclQ/mn1wr0OoovuGCOP8x0ixXQ6aGsOAyM8/25RsqP XyQJXL/HBr/ZB7wDlmpPMCmC3V4YoitFX2Lfg5zHZi3ae7vCwCtYfVRKZPFcLJx89ULZ UGKXEcQfkumcShDEnuW1x+SACcWuyeVgko5EI3gm8f2hrFV81DZqC5W27EYjMwKXGmuR bI5NVYklFdZqmCo6Ovq5PgIUuu1kjv4TBl+ruItS2Dni+zIT+uD0zsHXDaXJl+eivcER ZNDIIYjNBMhtyuMUCOleA44Xx150txCc7eXaNBrWelkjq+cj/T+YVzAsy1a3DaAl8LsD Gskw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727187689; x=1727792489; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dfQTsP0vA/xZ7wbPE4mzCRWLqRMSRVWs8MpYHZmYO04=; b=jGie4BQsD61HfQqn9gmqNeumolKHJ7CmeH09cIsjKX+rPysFd6umbC2bEgwNr8aHPY WThI8FgQFMycQe63Z0ex2ytK6y7GLsbE1m9Up4DDW7jt6/pk9f8a8ZUJmyum1vPrq28h aKr3/PZgySTP30TKa0vLhmbn8yixwnD65ASkbxKbHu1jzlHURHFYvlOw5HL+jliaCaKa GKTT2UL+ZWTe6CFEMl+xAxuZGHawx47F0amWZpBjMLdAsyM1jKSkQ2ARcir07jo/76I0 mKf0TemcpAGIOSMlJ7JvNmxKaW6Oo9/ucUBzgD7Fckpd4v8fywhV0u7dmLTjlevyR+Ip JfbQ== X-Forwarded-Encrypted: i=1; AJvYcCUk6aZJiAGQ79vlR2n7anUUx+VMESCba8Auce6Nm/+4KbCtNez658iOdE/Jwr/gSwP9ZDlP45BqBul5h1BQ65dX@lists.infradead.org X-Gm-Message-State: AOJu0YwtdJ+BVye8fbi9Vj3HnKGK6dWJH7JkoPCrJA029FISsGiYWKDF iFc0NmD0jNQjas7UhwiK7QIOFNWvBxr6ZtdoJwhgKiw5nyW78RuPE35tIeKybQ== X-Google-Smtp-Source: AGHT+IHvYi5sE75KftIebO9vedcos5Z0ukc1YN0ZeK6gW61izK+suGuxOSBkOiwHtcrUCyrBSyEIZQ== X-Received: by 2002:a05:600c:1d29:b0:42c:b309:8d18 with SMTP id 5b1f17b1804b1-42e7ac23136mr108548925e9.19.1727187689466; Tue, 24 Sep 2024 07:21:29 -0700 (PDT) Received: from thinkpad ([62.67.186.33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e75450ec6sm158091485e9.21.2024.09.24.07.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 07:21:28 -0700 (PDT) Date: Tue, 24 Sep 2024 16:21:27 +0200 From: Manivannan Sadhasivam To: Chen Ni Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, heiko@sntech.de, cassel@kernel.org, ukleinek@debian.org, dlemoal@kernel.org, yoshihiro.shimoda.uh@renesas.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err() Message-ID: <20240924142127.4wi7rsndl76vtffk@thinkpad> References: <20240918074401.2221146-1-nichen@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240918074401.2221146-1-nichen@iscas.ac.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_072131_859435_235349E7 X-CRM114-Status: GOOD ( 20.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 18, 2024 at 03:44:01PM +0800, Chen Ni wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from platform_get_irq_byname() > function as it is going to display an appropriate error message in case > of a failure. > > Signed-off-by: Chen Ni Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index 1170e1107508..3770e566b597 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -450,10 +450,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_ep_sys_irq_thread, > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்