From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F029CF9C6B for ; Tue, 24 Sep 2024 17:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ri+GAU/GeYWJ7kAA7IwGhSHyAI6OloJr9cBh+i/4KD0=; b=ejlFADOWNkOqU+iJV2MzLV59FY qMABEQkUPdauhNS5uUsJ6hhMaLHIIMpSoVvMsoUKvT2utb9KKhqPAgAhVyg/f92tgS6F4Fe3UgHH/ UNMyZrCUqpsZx93zlYMkLLez2BA0O0Tal0ck9rt0fdtKLsnIAEhRtfhUuUBqKS9gcAncXBUOfqjHB kiD65TXnLVSEFnsJiTrjzNKvGPSRn79WIH+Ltv/rzkp1FGrR5ia3vwJ4WOz8y0U5vREzFq4WNEihK xiL+fmIC8MpisHLtWHyOto22yntpt0ncIh5RtOeUFpT9ViDRAbVsbKewmdcIKNAJQc03cM1cLBvUS KclD+nyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1st8xS-00000002ulY-3rkj; Tue, 24 Sep 2024 17:04:14 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1st8wK-00000002ufU-1PCM for linux-arm-kernel@lists.infradead.org; Tue, 24 Sep 2024 17:03:05 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-2059204f448so50521155ad.0 for ; Tue, 24 Sep 2024 10:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727197383; x=1727802183; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ri+GAU/GeYWJ7kAA7IwGhSHyAI6OloJr9cBh+i/4KD0=; b=iCyNn+r+23ufOBrH2MNvhWzZp/R1tTPEyxsfskEokescJRHJpFu/KXUkZCc1V6W5zj m+WZB8aJigChK/sEByU50guAujsnwGTZ9unliTr/1IxRihU0CSFq1U/wbBPfWd4xfQrp 2OGw6fJZptbar5MSoDuZY4ADkYBVLULb/pPsmWuljvvC9OyX8CoX4w5rCw9xfOLJcwmg 4Kz0iGAQPdkV3mxVX6YgzYMpx5LK3fIwOWfWohEcl7N2bgJbhlCMHkhnvypqMd3nwi6m x4QVDW+AmzU8jSHBnXxNytowoVB8zf0JSrtGOaZz3QciUR8FGchsryXp5QQfI1z5OrWG Bmsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727197383; x=1727802183; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ri+GAU/GeYWJ7kAA7IwGhSHyAI6OloJr9cBh+i/4KD0=; b=fOPZk/Hz4eLdq8ccj17ACDBJQnLHqYkYPCECxZXGXG2vSRoWt9Hn8wC4wfVaNXKGgF TzUHYnd/i2OEGyi5rUxndgDPF7vzG+GwrH9QBgSkXVfJ2D9QDXoWAeLHIWl94eOMZknQ jH9oDrCm2Xfmm0udWb3LZa7Lt9doaTen2/cT846OvlC6/3b7grHHi6Jtk16KjiNjUOE2 qHAKpy8MD5EPl8qaIzZpNllUxkZa+MaFWtnk6wXe6chPSxZYxhs2EoDOc1BRAXi9wxjz bM/n24D6LaUaA1rZEiPV5375E2H9cfvmQcouuS3rMHpjuPDDe1LsffMSlbA3FBuDaNts VqjQ== X-Forwarded-Encrypted: i=1; AJvYcCUFrP5pzTKo7IaRL7xemfA1zU2czFkvgd6eKPMqjNM/U0Nu/HDJTii+aV6k+wxyD6gjuwg/pAsvgl7iQNSK59rj@lists.infradead.org X-Gm-Message-State: AOJu0YxrFS3edSlB9lhp1SCaI+8ZV9PR9rP/bLa+T/Hi3fWzXujvmKfR P6d37MEy+8SMhmFE7SlNn2HlRJDqfkgxGwT3xVDLDNIrq0XKLNL1AwQSvHcO X-Google-Smtp-Source: AGHT+IFKCI4MDKi4ygHlEjuHRjdP+HLRKNnYJF/sTyPhgmEdcEPM4C9gNFo1BFv48YUeTBRut9mF3A== X-Received: by 2002:a17:90b:1286:b0:2d3:c892:9607 with SMTP id 98e67ed59e1d1-2dd80c175c9mr17637988a91.12.1727197383448; Tue, 24 Sep 2024 10:03:03 -0700 (PDT) Received: from joaog-nb ([67.159.246.222]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dd837875d2sm9908018a91.21.2024.09.24.10.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 10:03:02 -0700 (PDT) Date: Tue, 24 Sep 2024 14:02:54 -0300 From: =?utf-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= To: Frank Li Cc: Francesco Dolcini , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , =?utf-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: Re: [PATCH v1 2/3] arm64: dts: freescale: imx8mp-verdin: add labels to som nodes Message-ID: <20240924170254.yx4v2m23evppfa6l@joaog-nb> References: <20240924114053.127737-1-francesco@dolcini.it> <20240924114053.127737-3-francesco@dolcini.it> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_100304_398047_0445B9C3 X-CRM114-Status: GOOD ( 22.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, On Tue, Sep 24, 2024 at 11:02:50AM -0400, Frank Li wrote: > On Tue, Sep 24, 2024 at 01:40:52PM +0200, Francesco Dolcini wrote: > > From: João Paulo Gonçalves > > > > Add labels to ti-ads1015 and fec ethernet mdio node to make it easier to > > reference them from other nodes. > > > > Signed-off-by: João Paulo Gonçalves > > Signed-off-by: Francesco Dolcini > > --- > > arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > index a19ad5ee7f79..e9518b7c7aa8 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > @@ -320,7 +320,7 @@ &fec { > > pinctrl-0 = <&pinctrl_fec>; > > pinctrl-1 = <&pinctrl_fec_sleep>; > > > > - mdio { > > + verdin_eth2_mdio: mdio { > > #address-cells = <1>; > > #size-cells = <0>; > > > > @@ -591,11 +591,12 @@ hwmon_temp_module: sensor@48 { > > vs-supply = <®_vdd_1v8>; > > }; > > > > - adc@49 { > > + verdin_som_adc: adc@49 { > > compatible = "ti,ads1015"; > > reg = <0x49>; > > #address-cells = <1>; > > #size-cells = <0>; > > + #io-channel-cells = <1>; > > Why add this? it is not related with what descript in commit message The #io-channel-cells property is required to reference the ADC node as an IIO channel producer in consumer nodes, otherwise, DT check warnings will occur. I agree that the commit message could be improved, but I consider this a minor issue. Would it be acceptable to keep it as is, or would you prefer a v2? Best Regards, João Paulo Gonçalves