From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2EE4C369DC for ; Wed, 25 Sep 2024 12:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PuwiR0h5qrYDFfKWep0guUFNi9B/ScBFdK5Es+tSGss=; b=MtfWiIw6YEcSvLq2IUC8Reeoue gep7tpMypzTMV3KGntkMq2uR0cM2ktvUNXa+2XJg1mMdbcjb+mEcOFRWIM+EVte0WhbrkB+Vh5rk5 kV0hQvNISC4UKf1oZ863HHpOoJLJ4+ShPGsXdp+RUpm0L7cmgnAAD3xLOBSCxbqueZ5M7Yvg7NZzG N2dl5cV/IxuG5YzrgjTTzJsyH/bgzVxDkApeQpmNwe9BEEk+mqyn6nrguC8xsXWeHXiFeeRYQatRK 4/TBSYPrQ5fHZWWbykkevZ6PHcl7GUSnwf2kdMajIEc8FBV5bXF+IrSn8TqtzXmmC3bhFozeZ+tei ZEfVFm1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stRR0-00000005DRb-47AE; Wed, 25 Sep 2024 12:47:58 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stRPq-00000005DCk-24yZ for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 12:46:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BF827A44214; Wed, 25 Sep 2024 12:46:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23301C4CEC3; Wed, 25 Sep 2024 12:46:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727268404; bh=kcSA1j/3f0Eze9yRRZ4pyTUpEjl/LYeoC7gl0Z8q/BM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J/rDeOHrlwt6bi35l3WrRKtwZ/Hf7vHYS9qemOk3SIU+UIyEZmgNFddrsGW3cR/d+ MvzsyAojMqYy5NaCHneDSiHJCtZ7XkelcfAyCRyNgV/4lagm4JGo9HVVKSAgUa716D PD5pUQWUIcDHNbCLIfVUljDNd2/YJCm/kvCzXwUH1FnUlo8Rci/lltRXmU16AeAmBu Jbv+3/ENU5je2/AS2BkIcJjIOzXmV8NDuuB2LAw0oiuKV0jQdfALqnbGbwlSoV6lsQ tujWUyEwICK6r91V7BGKV04xg0VQi9Z/cGKWJCW5ASNQf4gwHs/7wRCZ9mEtTy0hqk fI1PMf0GIHZsw== Date: Wed, 25 Sep 2024 13:46:40 +0100 From: Conor Dooley To: "Mahapatra, Amit Kumar" Cc: "broonie@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "Simek, Michal" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "git (AMD-Xilinx)" , "amitrkcian2002@gmail.com" Subject: Re: [PATCH] dt-bindings: spi: xilinx: Add clocks & clock-names properties Message-ID: <20240925-trapdoor-stunt-33516665fdc5@spud> References: <20240923123242.2101562-1-amit.kumar-mahapatra@amd.com> <20240924-impaired-starving-eef91b339f67@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HaqQMrQQU5awWjZC" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_054646_690092_7E617C5D X-CRM114-Status: GOOD ( 29.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --HaqQMrQQU5awWjZC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 25, 2024 at 11:35:56AM +0000, Mahapatra, Amit Kumar wrote: > Hello Conor, >=20 >=20 > > -----Original Message----- > > From: Conor Dooley > > Sent: Tuesday, September 24, 2024 10:07 PM > > To: Mahapatra, Amit Kumar > > Cc: broonie@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > > conor+dt@kernel.org; Simek, Michal ; linux- > > spi@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git (AMD-Xili= nx) > > ; amitrkcian2002@gmail.com > > Subject: Re: [PATCH] dt-bindings: spi: xilinx: Add clocks & clock-names= properties > >=20 > > On Mon, Sep 23, 2024 at 06:02:42PM +0530, Amit Kumar Mahapatra wrote: > > > Include the 'clocks' and 'clock-names' properties in the AXI Quad-SPI > > > bindings. When the AXI4-Lite interface is enabled, the core operates > > > in legacy mode, maintaining backward compatibility with version 1.00, > > > and uses 's_axi_aclk' and 'ext_spi_clk'. For the AXI interface, it > > > uses 's_axi4_aclk' and 'ext_spi_clk'. > > > > > > Signed-off-by: Amit Kumar Mahapatra > > > --- > > > BRANCH: for-next > > > --- > > > .../devicetree/bindings/spi/spi-xilinx.yaml | 29 +++++++++++++++++= ++ > > > 1 file changed, 29 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-xilinx.yaml > > > b/Documentation/devicetree/bindings/spi/spi-xilinx.yaml > > > index 4beb3af0416d..9dfec195ecd4 100644 > > > --- a/Documentation/devicetree/bindings/spi/spi-xilinx.yaml > > > +++ b/Documentation/devicetree/bindings/spi/spi-xilinx.yaml > > > @@ -12,6 +12,25 @@ maintainers: > > > allOf: > > > - $ref: spi-controller.yaml# > >=20 > > Please move the allOf block down to the end of the binding, after the p= roperty > > definitions. > =20 > Sure, I'll take care of it in the next series > >=20 > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: xlnx,axi-quad-spi-1.00.a > > > + then: > > > + properties: > > > + clock-names: > > > + items: > > > + - const: s_axi_aclk > > > + - const: ext_spi_clk > >=20 > > These are all clocks, there should be no need to have "clk" in the name= s. >=20 > These are the names exported by the IP and used by the DTG. So? This is a binding, not a verilog file. > > > + > > > + else: > > > + properties: > > > + clock-names: > > > + items: > > > + - const: s_axi4_aclk > > > + - const: ext_spi_clk > > > + > > > properties: > > > compatible: > > > enum: > > > @@ -25,6 +44,12 @@ properties: > > > interrupts: > > > maxItems: 1 > > > > > > + clocks: > > > + maxItems: 2 > > > + > > > + clock-names: > > > + maxItems: 2 > > > + > > > xlnx,num-ss-bits: > > > description: Number of chip selects used. > > > minimum: 1 > > > @@ -39,6 +64,8 @@ required: > > > - compatible > > > - reg > > > - interrupts > > > + - clocks > > > + - clock-names > >=20 > > New required properties are an ABI break, where is the driver patch tha= t makes use > > of these clocks? >=20 > Alright, I will remove these from the required properties to avoid=20 > breaking the ABI. We're working on the driver patch and will send it once= =20 > it's ready. What changed to make the clocks needed now? It's possible that making them required is the correct thing to do, so breaking the ABI would be justified (provided the driver can still handle there being no clocks). --HaqQMrQQU5awWjZC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZvQGLAAKCRB4tDGHoIJi 0scRAQCAKuG3tQ1/pvYQPWfQVDEub9Z82uFOrgLkwy9OhlSd1wD+LQsM2swJTMq1 Uz+Je+2R40Vej/gra4Rc5OrYmXslfwY= =8acX -----END PGP SIGNATURE----- --HaqQMrQQU5awWjZC--