From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0223ECF9C6C for ; Wed, 25 Sep 2024 03:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QwY19019EFRjU3LmiFbhaONNL620/dAJwYqX4p46DKY=; b=EJIcUUokdlFD1W6oloKUemGA55 sYxE6KuZzy4AAcLNU6xXJ7AttKElnlxCQEOVXX8zxyd4q0r5txm8DbckVl2J1vnmQU0Pbg6S6nWfr 1fLmC/nUJ/QfIf809i1qDWmjKhO/kx/MnjF3KPR0iOPqQt8+pSZ+3E/N9VUlaBayix6LBYcVfpfJb KI0/oagmUGD/5buvKJ5I+8o05lqwDBZfBMJ0O/oRxX4TEtigw2C2qpY0MKXIKWU3fV7H2FUvVtgo6 BmmUjVH0g7uQwM/6q3NV+DcSpmPLvccOh4HPrN5H+EJouAbG66MTWs/C4+Tweyf0F/uvFhC6Td4hb DWbA3kfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stJ8A-00000003w8i-0qty; Wed, 25 Sep 2024 03:55:58 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stJ71-00000003w5I-1Q24 for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 03:54:48 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-718e9c8bd83so343772b3a.1 for ; Tue, 24 Sep 2024 20:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727236486; x=1727841286; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=QwY19019EFRjU3LmiFbhaONNL620/dAJwYqX4p46DKY=; b=hBGEoDm/DWoSySD344EQuMaXV2DuTM90sjydqJWymIiCoBvAIO1Fp3ciBSbo0UMK2p 45QgVDZGqDz2y4Sf1CAaA3Wzxpr3zKASWWL/kiRQWCT8oCZ0FwbIgJXmNRf+E+ti4NSK XRnQFu/vZeH6xcHjlyVW9pAUZdUHZMeWcgDpgyYGJY+ccQwj1D2T3Dr+KwLXr5IXStVS j50jwBQ1jhwJ/xcMg2qyIOfYtx12eG29Irfvb1MdLo//kNtFiUthJhPp539Kjt6UYCWc WVzEXemCeDiNww1PlC6XsO/VrdqwFyIrEYkJkOD9+9FI3RHzk5bkTf2HlX5JjJSCzzLC d3Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727236486; x=1727841286; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QwY19019EFRjU3LmiFbhaONNL620/dAJwYqX4p46DKY=; b=Ywogo2wMyzfkt+q/JLUUqIweU0zIorKW4M1+FysDzflTyqxya5LgUsoT8IiM9Fat72 /U0DC0t5j9w9peZ7W66ZULqFblCA4bcgb1EZgbQXD7h4HZQJHreb8DqRhe44JSoNu9uC bH+MZ0rJ6U5OPc0D5SFuEv58NwEBL0xnzMtDjj28vLyskwYJwYIYLImQkm6snJIQUjuu gWEWXKgLTkvVCniuT04M4hXhv8196sV1daMRv7bEf0s1gy6U8zFxWKvqfWbZ4In2zViy bg41lSuNCpR/VUCSgTJACShbGGfx0A03Wyd14CDByNWrfjCM04qxOo0wt4Ptp5kYOWo2 4KLA== X-Forwarded-Encrypted: i=1; AJvYcCX+8lK71/04q6AW4DV4V8ZMST3yK8W0+aTvv9b/6t98XeWxoM7Bd8GlhhZd+5f7ioWWS8xTzj01JMu87oIHMIjN@lists.infradead.org X-Gm-Message-State: AOJu0YyxiggNSdyP5j8HWeKZQuINcRAofRMXlDgT6XuaNbWT5Cq8dZRE KGRHkXo+hGYQLbyF4UmfIMbiI5Tab0PUlCMP7aYb3nueg7tpK6pW X-Google-Smtp-Source: AGHT+IHoszYzZR6FaOBuROwQNPUghuIvxepmZftX62ol0oPeA3CYEtPbyagy0d3q92dFlJQXXpOaag== X-Received: by 2002:a05:6a20:b58b:b0:1d3:294e:6502 with SMTP id adf61e73a8af0-1d4bed0b3d4mr2042853637.3.1727236485859; Tue, 24 Sep 2024 20:54:45 -0700 (PDT) Received: from localhost ([183.226.245.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6b7c73085sm1887334a12.59.2024.09.24.20.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 20:54:45 -0700 (PDT) From: chenqiwu X-Google-Original-From: chenqiwu Date: Wed, 25 Sep 2024 11:54:40 +0800 To: Oleg Nesterov Cc: "qiwu.chen" , corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, paulmck@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v4 2/2] arm64: show signal info for global init Message-ID: <20240925035440.GA2941@rlk> References: <20240924074341.37272-1-qiwu.chen@transsion.com> <20240924074341.37272-2-qiwu.chen@transsion.com> <20240924183634.GB17395@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924183634.GB17395@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_205447_400198_79C79751 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 24, 2024 at 08:36:35PM +0200, Oleg Nesterov wrote: > > So what does this patch try to do? Note that unhandled_signal(tsk) returns true > if is_global_init(tsk). > > So it seems that this patch just tries to bypass the show_unhandled_signals and > __ratelimit() checks? Or what? > Yes, this patch just try to bypass the show_unhandled_signals and __ratelimit() checks for the global init. > > OTOH. The is_global_init() check in unhandled_signal() (which predates the git > history) doesn't look right to me. If init has a handler for, say, SIGSEGV, why > should the kernel complain? I need to recheck this logic... > I think the orignal logic is the signal sent to the global init is regarded as unhandled becuase it has SIGNAL_UNKILLABLE feature. Thanks Qiwu