From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E167C369D9 for ; Wed, 25 Sep 2024 12:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iTJx4RvwFxfTOCwvhdIaY07N/0J58vt6GfX0pwiHMqk=; b=GwP1oKciEETt/eDpl+YAUIv5Kq bpX4jwCNMXTYOhPg9/8IFcYbf16d9cXyIXp93dwNRG7i1pQnsTk3R5kStgxoyLJOOQvEhSFO26itD /klzf9BfsvAOiGbpnbgZ4vnHhh6i1/b2Hmnf3Jp/XelTat4vqYs8rTQHLLFPm7m+jzNMQrhbj6yzA 1WULrfYx77lKFT7Pcb+iGs2D9VBAzMxKd7EqjPbChHMCGr0qrN3wnM78zpG1+7hr0VTkJRstCvlKY EnrhJyezE533/o6nRRj+bzHKWDm1RtnrFBRSvsQHB03iIX8xi3Dv+QKEfQWSpCKf+SBeDjH1Tzs0m k6Ortbew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stRBl-000000059uO-2pjP; Wed, 25 Sep 2024 12:32:13 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stR0H-000000056Z5-1nYT for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 12:20:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727266820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iTJx4RvwFxfTOCwvhdIaY07N/0J58vt6GfX0pwiHMqk=; b=EHUhZWI2BOS3Bb6XBRdZZcvSaQKFZB+UV40B4G63jeUMrUyZonKR8bnyvNBRzL47JuY/ch gjADTT5uqPV+1EhMh6c/oQ9z2fAEQ9MPvYfySGDY3IzCpq1CgWbZXIRoO5W4c1Gr9uCzby dVGK4NENDc1ykt6VUYnHza+xBI6AOLI= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-UjlCmDMoPYWUw4laE9LiUg-1; Wed, 25 Sep 2024 08:20:17 -0400 X-MC-Unique: UjlCmDMoPYWUw4laE9LiUg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A959B19367BC; Wed, 25 Sep 2024 12:20:15 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.67]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 491A41956048; Wed, 25 Sep 2024 12:20:11 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 25 Sep 2024 14:20:02 +0200 (CEST) Date: Wed, 25 Sep 2024 14:19:58 +0200 From: Oleg Nesterov To: chenqiwu Cc: corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, paulmck@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v4 1/2] panic: add option to dump task maps info in panic_print Message-ID: <20240925121957.GB26882@redhat.com> References: <20240924074341.37272-1-qiwu.chen@transsion.com> <20240924113322.GA7248@redhat.com> <20240925082759.GB2941@rlk> MIME-Version: 1.0 In-Reply-To: <20240925082759.GB2941@rlk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_052021_555159_7AAB4CC9 X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/25, chenqiwu wrote: > > On Tue, Sep 24, 2024 at 01:33:54PM +0200, Oleg Nesterov wrote: > > > > > + if (path) { > > > + name = d_path(path, name_buf, sizeof(name_buf)); > > > + name = IS_ERR(name) ? "?" : name; > > > I think this is an easier way to get file path name which deals with IS_ERR(name) case. > > perhaps this needs mangle_path() ... Sorry, I don't understand your reply... Oleg.