From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56672C369D9 for ; Wed, 25 Sep 2024 12:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Eo83E3rr21/cKLc/zAZGOD/iRD2paKfELWeccpaaQQ=; b=Q+mb+FGs9jcXuAym196E4bN/+X i2n2ztVlvT4rptoZIbwz5wQwMXYNIGaEh7Ahxh38Yg5ms2Tzx9muQYBJkN0y/rQgwtCgviEpRj+6N fn+ahjBdophGV2uQ9gPaTaVj/ISFwljkeWTs5PHol1zSwH87JR9GZYVz3UkqyRtN6uyQfIFXj78kr d3IYJyhdhS0OgibPIBGNDkcI06Wve25+HnzHl7GmbaKQSuqv/MQplpnj+3iNaMXr4dOSZOVItmvot M4jkidHNu1QVNqQzwnWKBAxRoTfq6NEfY2IFQniQK4C1ZGKxuZPsymr1vwFv3qyhxbQM8ulESqOwp TLCHzFEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stROU-00000005Cmp-3Vy9; Wed, 25 Sep 2024 12:45:22 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stRNK-00000005CXW-2WWM for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 12:44:11 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-42ca4e0014dso9819635e9.2 for ; Wed, 25 Sep 2024 05:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727268248; x=1727873048; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4Eo83E3rr21/cKLc/zAZGOD/iRD2paKfELWeccpaaQQ=; b=mLCpo0dY/+Ts4tabM5VxaS8hLvfV4XMjeRndlyVF7NDdvWklpvTf2oxvpHAfokYNk3 4bQKKEUNNCDrbRmPHKS2YSiDWw7ylGxZZCHDEqCyidINf8R6HAWgNApo7bokLJp1ESpe afDGyMehLsmRaqRBlIpuOWWpZfacdcTWvUa/WWGcnmghN3mg1wreMUNq/9vkNWEd48Tt bbaI4dmaz69dWkNjkqopO4EksqBQKHTV24Ll4pMDd2Pu8kLXbXfVDws90mS10fE2Q6B5 obDEhJg7ikHZPZdK61U+fzbpNHsUruiH4lvsQlPzWuFT6rIDcHWJchGLOcfoD6Sn4mj2 /eJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727268248; x=1727873048; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Eo83E3rr21/cKLc/zAZGOD/iRD2paKfELWeccpaaQQ=; b=vROveR5Rv2wl7ybcNvqOqjLGhEFOV8HZGJq+Bfrhd8bzhKbny8vkdxXX9Rp48r6cFK zaSBtrXcYFRVGYnwTI0tkIqz+vRlKatA8Q3hFFbnNX5KY/TZoPpuch4YibJYx4LJMMbr 4sR5JyjjjGrtpPEG/GMqf5Y9nwbI/zzJqatk9gfodqlm+8xjVL/zCfoQ8uT/EiuvP0SJ whlxLn3kYq8c0ClmFytW6EaOHwdBPCaS4J9X3fnroI3/UjxPm+ZdpZb9/JSoADv39GRQ Hnj/3AlbT90VuahLPNdNnJ1pKJ3IZ+bQzVAFKhvQ2CSG0wrfH8wzPaK1OnfjYJKc80Up w/FA== X-Forwarded-Encrypted: i=1; AJvYcCW/0CCtLaTGurrnb9FPwj6/e45QIE9IJVho4u0taHqFYJ/ZacA0GclOPA7yUymLsMU4ZBOVdMsjxnDw51l9NWuY@lists.infradead.org X-Gm-Message-State: AOJu0YxnghsG6lR3Qu+jaYpCo4MlK8iiLjS28GBvYekI22uK96LYJp44 HqhFm09IbqHucRmxvTtghz/S+Vf7JwhnDR6rzyhWExeZpyceyqHK X-Google-Smtp-Source: AGHT+IFfS7vhUVhrpQ9ElZSkjpzVE5QUA1yIAFxCnd7J6P95GWbU9JMpyPawsb2SPEgug7UuG0NqYw== X-Received: by 2002:a5d:5f85:0:b0:374:c8d9:9094 with SMTP id ffacd0b85a97d-37cc246852fmr1068284f8f.5.1727268248129; Wed, 25 Sep 2024 05:44:08 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c5cf4d74f9sm1856930a12.80.2024.09.25.05.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 05:44:07 -0700 (PDT) Date: Wed, 25 Sep 2024 15:44:04 +0300 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jiawen Wu , Jose Abreu , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Mengyuan Lou , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH RFC net-next 01/10] net: pcs: xpcs: move PCS reset to .pcs_pre_config() Message-ID: <20240925124404.djjy7e4jhovhbwgt@skbuf> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_054410_660035_AD4A1CAA X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 23, 2024 at 03:00:59PM +0100, Russell King (Oracle) wrote: > Move the PCS reset to .pcs_pre_config() rather than at creation time, > which means we call the reset function with the interface that we're > actually going to be using to talk to the downstream device. > > Signed-off-by: Russell King (Oracle) > --- Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean # sja1105