From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DE7FCF9C6B for ; Wed, 25 Sep 2024 13:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uHvDwBZzI4wRaMBB4iym1ztBubtpy+b9V7vHZYPrE5I=; b=rHsNsylXCJ/6u1clNvPDfn+hGp +mXAVkbDPdOFf8u7z8kdQZ7+3AaAC4/G/PT+yoPrQ/eMa/i0YEh8gfq9hE9T14ZfUiQXtHc80/lNO 8m58GkNvJ1RWaUyt/r/DEHbvG27iSUJt+dOQye22VCu2LMUJIht80w+7DcGfPeibrMbAeRmeMIjWG S7Ef1iDovHtomJwHjKHnr+yWfLKpCBiylxN0ZEGDjXsRUMx6oRk5axegBee37d/Z7Xf22/Sm1FYVu gZ/gmHUsv7zgQmsRf6aNm66PSdUiAfrYVSmlIYbet7vEIouPqTymBDKV7CFTcn9VMHmS9Ntta5bjI 2e2sq6GQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stSK7-00000005RQJ-1hmE; Wed, 25 Sep 2024 13:44:55 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stSIx-00000005R8D-0z56 for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 13:43:44 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-42e6dbc8778so11133275e9.2 for ; Wed, 25 Sep 2024 06:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727271821; x=1727876621; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uHvDwBZzI4wRaMBB4iym1ztBubtpy+b9V7vHZYPrE5I=; b=ScLP37mDl0CsAZX0tD4cexiaI+nzhW5BzMEvs3D7JpxHw2AxefcgWvG1h7eI8zgb6+ TsxDZSi1pwRqmodpYexrDetaLxyGYeMhLjasvijyp07SE6fIeR+Zw2vIps+DUkoa01Vg nax7v1h1rUgKDpMdnD+1B1bcgWqrkN4FiSpigeQQOnwV8xhFmLR8/FAznWaw7sTp7l96 b9cHCJ21hE6k7DwtEh1YdAGr1n2hisUpkn9QV2LdJdPQSs5ESJyNPEUpzga/JfCHMbAj wXEyoSlJMPbC9FVJyr0CpxR3bJFduqWeVHxRJ5DiO/a5oI0CsKEiIM3ijnxsPQN1W1z5 TTTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727271821; x=1727876621; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uHvDwBZzI4wRaMBB4iym1ztBubtpy+b9V7vHZYPrE5I=; b=qeO5dFjvXiwujRs2pt1akddGyxe+Bfk/lc7nGQTcxVlcEEcF4Veau02qa2mo7yxxqP uYXOTXFcUqOKZuGhB08Cuc23UyG8eX4A2lvXlr35D4UWYhj50ySxRXS/UORhX7sUnQ0B JfpOP5pGaj6kJhSWSiV5qn7qe+HWKGRONODEdYtfXoglze1uSGybtFhGvw/RhEHqq0+6 SjqV9wJ2u6cTgpMywW/kt+QvD5FIcgMzr63mNnAqMbDFlWp3ug0xjPNclXFuSAMTbyP7 +ZF32VVtyZdCAI7TcIIXtwtFlo3YYUHQ3o/KSiR8LeJjXR8j25Zn44WR8x6NvQIGtByq iKDg== X-Forwarded-Encrypted: i=1; AJvYcCUh91yTGEWkziLktt1ZVRZWMqIb9uI8wQt1P+YiGIgeducC2EHsmeYs1pk4iwuKVz4Cnyl5hBi1GjDa/JAvpUGU@lists.infradead.org X-Gm-Message-State: AOJu0YzaLNtCSnxfOZBfmmiFcTFsBDqGmDcFIheKVER667kzSLW5hOJd jenvZlID6hm3zCDKM/KuDMyNdcU2834+elzUR5INjYNTvCSAbE9b X-Google-Smtp-Source: AGHT+IHmnVWjsS8xkdZZ7T2bxRduY3ggznHkuYE5rMeBgUZ+UEHsPUYheF24v3Oz1tufHagTFvs72g== X-Received: by 2002:a05:600c:3c9e:b0:42c:b8da:c79b with SMTP id 5b1f17b1804b1-42e96144caamr9214525e9.5.1727271820933; Wed, 25 Sep 2024 06:43:40 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e969a48fasm19531535e9.0.2024.09.25.06.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 06:43:40 -0700 (PDT) Date: Wed, 25 Sep 2024 16:43:37 +0300 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jiawen Wu , Jose Abreu , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Mengyuan Lou , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH RFC 00/10] net: pcs: xpcs: cleanups batch 1 Message-ID: <20240925134337.y7s72tdomvpcehsu@skbuf> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_064343_296624_D309EEA7 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, On Mon, Sep 23, 2024 at 03:00:26PM +0100, Russell King (Oracle) wrote: > First, sorry for the bland series subject - this is the first in a > number of cleanup series to the XPCS driver. I presume you intend to remove the rest of the exported xpcs functions as well, in further "batches". Could you share in advance some details about what you plan to do with xpcs_get_an_mode() as used in stmmac? if (xpcs_get_an_mode(priv->hw->xpcs, mode) != DW_AN_C73)) I'm interested because I actually have some downstream NXP patches which introduce an entirely new MLO_AN_C73 negotiating mode in phylink (though they don't convert XPCS to it, sadly). Just wondering where this is going in your view.