From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68DA5CCF9F7 for ; Wed, 25 Sep 2024 21:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hserkp0XoO/xaxszPyfe2XUusNXhdSGovTKNC7GSS08=; b=eRft50c/BBlWTIdRYSovPPEbU/ NN7tdzJ3+dcONM5JI22nPJ6PLcV2uncudK77HIc40wgALp90jDgepwu7Z2SeO8ojGc9XUhgQOc+14 gH0iTi0McpYW3sAcVVVU86seFvajHphDXgr8oxUu5jz9jlf3stBbeKE16nAscziNcbJe9AsR0xnf7 Fslxc+GNnDBpCJLlE1kSpSARkyCeNGbczu2hrL4bXrDFoGQGEJ2qYdFx2Ip8CGrL/Rox1VQUHRni8 zmgQz4L07R6pbW2i1N7TY6nmfjgV5sQLKfR3vKgTWQFJzw9uA6o41SsZyz3D3df+DSom+Oz+sxAFN sowKynkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stZO7-00000006Ywp-40a9; Wed, 25 Sep 2024 21:17:31 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stZMx-00000006YtA-1SLl for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 21:16:21 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-42e6dbc8778so333095e9.2 for ; Wed, 25 Sep 2024 14:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727298977; x=1727903777; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hserkp0XoO/xaxszPyfe2XUusNXhdSGovTKNC7GSS08=; b=SW1NSPkOORWea0C1C6RO1h6c/3NewUgvAhoApoTzdpEaolGJZD/bf+L7M69C5jQBTo miTcScsCDbKAYkfScMvsqYDhrqFjTxUgRHj7xyry3JT5F+e4l43WN5MF0QcTHDg1ho8N pg00oB26W5zcWcVk3K3vYZLXRluFyV6zOz2Ssi2R9VU3EWIgYcuXQAozv7oQ8czk1qGz w0KMxQwK7Gw4Sz28QhaDnAfhtIyAfJzTBUszEad5r6/893pNddB+AUvbo9Fia9vFmLNS Nc1m7BhZYgBdeVsXXWdXy4EV5mCNxo8WRSXDqJBXv3v3uhxDV5imgM/mmEhGFPemD1n2 hATQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727298977; x=1727903777; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hserkp0XoO/xaxszPyfe2XUusNXhdSGovTKNC7GSS08=; b=g50wj61xSU6K76NF2wyBxKLqaQbej7q7H9CZSZQ/m2n83M2iMedJkL7pf45c7RDnC6 IbkzyA5gkyv+SscT95ES9TsiIzmZMbHKQ5IFXJ0FvP6fM+m9kAGhp58CRomIeA5yK4bd sbfFDk6kgc8KCmL/qWxfMZzhUX6dEw3M3JPmOfRpFCmgfmWKp7Fh7Pp6JkdDj+k9gsvR OMBQ4dEEidU2A1n5Hia9orV7/jDC8TfBn4DJwemO11dg1d1fa55HaE0nPkUsBSGiWT9Y Iqt1wBwOsNlN43aOcdgeJuJ+WUk0EilCetRDbZ0zSs7wKNFuVYNS67A/TrdcKbln3anX TKJA== X-Forwarded-Encrypted: i=1; AJvYcCViKsTFm6q1yZWn9PVEfWQ9fKZsCBUM+fawSOB/SFZgNG0wrjinhWpmw78YIc/RPEddN/5lqg0gv5U63xNZ8fOy@lists.infradead.org X-Gm-Message-State: AOJu0Yx6h9m0NGUteqBB70dODIj/gMpZCWJawDFhlms38l2M1ks14tLL FKxqymCB6IFFai7m16WoGFUATF/7ZnnqcNKbDj9BSqtgz4t/zGvT X-Google-Smtp-Source: AGHT+IHBkP25fB4BC5hSAT45OKJ8Gcfe1I3/jKVfbWU3juyKG2hV4TbANIux7w2Ze32P428dDIwKzg== X-Received: by 2002:a05:600c:1d25:b0:42c:ba6c:d9a7 with SMTP id 5b1f17b1804b1-42e96144adcmr14013805e9.4.1727298976991; Wed, 25 Sep 2024 14:16:16 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2c13cesm4876658f8f.29.2024.09.25.14.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 14:16:16 -0700 (PDT) Date: Thu, 26 Sep 2024 00:16:13 +0300 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jiawen Wu , Jose Abreu , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Mengyuan Lou , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH RFC net-next 06/10] net: dsa: sja1105: simplify static configuration reload Message-ID: <20240925211613.lmi2kh6hublkutbb@skbuf> References: <20240925131517.s562xmc5ekkslkhp@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_141619_413631_FCD049DC X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 25, 2024 at 08:38:23PM +0100, Russell King (Oracle) wrote: > > There are 2 more changes which I believe should be made in sja1105_set_port_speed(): > > - since it isn't called from mac_config() anymore but from mac_link_up() > > (change which happened quite a while ago), it mustn't handle SPEED_UNKNOWN > > - we can trust that phylink will not call mac_link_up() with a speed > > outside what we provided in mac_capabilities, so we can remove the > > -EINVAL "default" speed_mbps case, and make this method return void, > > as it can never truly cause an error > > > > But I believe these are incremental changes which should be done after > > this patch. I've made a note of them and will create 2 patches on top > > when I have the spare time. > > ... if we were to make those changes prior to this patch, then the > dev_err() will no longer be there and thus this becomes a non-issue. > So I'd suggest a patch prior to this one to make the changes you state > here, thus eliminating the need for this hunk in this patch. That sounds good. Are you suggesting you will write up such a patch for v2?