From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B36E2CDE021 for ; Thu, 26 Sep 2024 16:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i5gKs28PIZ9OJchaPijaHDwFlIvvXwx3mdFdZLIkcJU=; b=hnrzbq55a2DkMkDO2sLpoBP0VM Ye4126CmyKXMk8xg5CNX7ZLp0s+Mukpt46NaPj1qS9ED7Z0hyTCaUKoBgFzZriqen52X78hDJUyum +/wfzWveBnZQJO8IunQjF8CuEdvIn9o+vbU3YI+jfY7j2YaFJxnGpDhRh+54J+mltth0uJvBIQMfT /wenStetyVmE5zrTHa1+un1QG+M4Qpi8M0Leqcmp1TXyD+bPnJfCNLzy7q7yoAvVas7kj0SSEI2vU PeKdBLR9Tqy+0MTLDXmZQX28q/ML/7pc/D+uT0gZring8U9GzRnynRE/EI5E8DnFuj5jItRl7g+9V cL78tF2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1str5R-00000008qzc-0vCR; Thu, 26 Sep 2024 16:11:25 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1str2q-00000008qMD-3iX6 for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2024 16:08:46 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-535dc4ec181so1327347e87.3 for ; Thu, 26 Sep 2024 09:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727366923; x=1727971723; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i5gKs28PIZ9OJchaPijaHDwFlIvvXwx3mdFdZLIkcJU=; b=Ky/yceWf6CI/8Ypt2UFGWLwJ/EL1d+maKh+Kt/cNZ79A9nxHIQP+g8QOweo6Y1a02m otHhMMo+pUUS+rP7UKlDL/YjwSYBCuPmbBcsw823GCPYuatZ1ElfkjCSXQkzi9JcWodi WSYHFixpQ6Z3R9MopkxdgvqwEb8m+TMZbT0DrSh7aHuSQvIFjyC3N5XCaZqaQN1yzfbF FGSiR1VULtbPAawg2PbS/UqHmblEuCKefsGLMN+kEK2FuUWPuRDigZuocJKtc4WPxzwn QFEAoF2n6+MX6hEPmnJp+vcaXakI8iCySDAenePFgUY5JKh1pE2YQB60i9beiyNBENlN p/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727366923; x=1727971723; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5gKs28PIZ9OJchaPijaHDwFlIvvXwx3mdFdZLIkcJU=; b=BrZ7WaPUsc015AYje/IsobARppK8dZe8o5UyZQ8guaJ9fERVTTkkvyTwEYAMLMSkXY HB3Peio1n9Qrv1h2B9OwIFXhThHV8iUdpnU8oMWXSshKGvDFqbfCKfVSddGQYLEcsHF1 4tlP6YP/0syTJLYkvc0vNL1hftwzAn/cwGKq3599S48VepfKZ07pxu+7vayOcR6Z6R/U Zva/96DDmXDV0SMvwKzIiDY9grL0dt5s+VcSxlYog0ATXJ9Cd3oDSWLRtprwWWfwQL0e I0+2UHhLNC1zfU/JwoRaL44owf7TsbWSYvgSe70visDUjxYZgESU6j17m+rSgkV4OrMX 66Pg== X-Forwarded-Encrypted: i=1; AJvYcCV9yuzZBcYukYmSTV5zINkd1uCj3cdbzhLy4u3uEZXkLItfbs9o8rBUSzgXoqqYofW9zwVdcdKsd7xFSDrI4TFj@lists.infradead.org X-Gm-Message-State: AOJu0Yzv9rBAoUlHCYH8M/l2zeDDJ172J28SCffZhW1mps0jfeF+/Caz Tl6GVT+CcPU7JnssuaNDEO+5/Kr99Jh6u1ccjgrZul7oZIj7n7pZ X-Google-Smtp-Source: AGHT+IGLWzwtVsVoERLcNZJXmgDmyiGB9Y0BA8D4DZOrd3E+mXlHlQRe8hXYareII+TVH+5IvvXpAA== X-Received: by 2002:a05:6512:118e:b0:536:a4d8:916d with SMTP id 2adb3069b0e04-5389fc4d0d6mr73847e87.34.1727366922442; Thu, 26 Sep 2024 09:08:42 -0700 (PDT) Received: from [127.0.1.1] (2a02-8389-41cf-e200-6d88-4cd9-a9d4-f267.cable.dynamic.v6.surfer.at. [2a02:8389:41cf:e200:6d88:4cd9:a9d4:f267]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c27c70d3sm13947966b.78.2024.09.26.09.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 09:08:40 -0700 (PDT) From: Javier Carrasco Date: Thu, 26 Sep 2024 18:08:37 +0200 Subject: [PATCH 1/4] iio: adc: qcom-pm8xxx-xoadc: use scoped device_for_each_child_node() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240926-iio_device_for_each_child_node_scoped-v1-1-64ca8a424578@gmail.com> References: <20240926-iio_device_for_each_child_node_scoped-v1-0-64ca8a424578@gmail.com> In-Reply-To: <20240926-iio_device_for_each_child_node_scoped-v1-0-64ca8a424578@gmail.com> To: Jonathan Cameron , Lars-Peter Clausen , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Hennerich Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Javier Carrasco X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1727366918; l=1388; i=javier.carrasco.cruz@gmail.com; s=20240312; h=from:subject:message-id; bh=+7rr+FCJ6AKEfSNXljsUP6cpWRBmO490u2jfv3txKV4=; b=sqgXoB41yns5o3RxNgTQxLX7a9d1ns38jgO9CICIOPLIHhpk3IrwcW0xk/EqE/0KHISg3Zupw NRY4WuSZt3QB53sR21L3VYD5YsVriYRanA8iMQlfuAM4Q7yT0YwUlxi X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=lzSIvIzMz0JhJrzLXI0HAdPwsNPSSmEn6RbS+PTS9aQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240926_090844_963132_68EF0713 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Switch to device_for_each_child_node_scoped() to simplify the code by removing the need for calls to fwnode_handle_put() in the error path. This prevents possible memory leaks if new error paths are added without the required call to fwnode_handle_put(). Signed-off-by: Javier Carrasco --- drivers/iio/adc/qcom-pm8xxx-xoadc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c index 9e1112f5acc6..311e9a804ded 100644 --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c @@ -821,7 +821,6 @@ static int pm8xxx_xoadc_parse_channel(struct device *dev, static int pm8xxx_xoadc_parse_channels(struct pm8xxx_xoadc *adc) { - struct fwnode_handle *child; struct pm8xxx_chan_info *ch; int ret; int i; @@ -844,16 +843,15 @@ static int pm8xxx_xoadc_parse_channels(struct pm8xxx_xoadc *adc) return -ENOMEM; i = 0; - device_for_each_child_node(adc->dev, child) { + device_for_each_child_node_scoped(adc->dev, child) { ch = &adc->chans[i]; ret = pm8xxx_xoadc_parse_channel(adc->dev, child, adc->variant->channels, &adc->iio_chans[i], ch); - if (ret) { - fwnode_handle_put(child); + if (ret) return ret; - } + i++; } -- 2.43.0