From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF135CCFA10 for ; Thu, 26 Sep 2024 02:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y0gpZKu+9BbdzaHiTLt+hndiQTMHx4RLZuHkJ2X3QxQ=; b=uO4AbWX+Bdwa4DNtfQZvBFh9S+ wVkfXXFPjH849AHLlqpxpz724vnCj9AzkJnVYmadyKkvpXo2Mkl4hKoDNc0s79ry5VfJ6wC8t0C99 tjYmhLPHrfDDFmLGHwMHnqlsTfbSaKfi97z+Y0bITvlNh6nzKSCXQav4XXbjQmgTuDtcis3EFfdq2 BRmSIEB6o6j3heWLOVzUnPNsrnLqHsgLe4nzEKRB+ZHY4oQVh+zv09HvmX6w2Jj4XnTRnwES5Jg2H v/XsDnSVB88hQx0Brh6RCzDWtDlUKjQi4suFAKuKCnBvNTtgw2OzZKUum2WCwy5nxkC7pQXS6DRwv Q00NMbBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stdxU-00000006yQW-0ZoE; Thu, 26 Sep 2024 02:10:20 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stdwK-00000006yKR-1Oki for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2024 02:09:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6964BA43AFD; Thu, 26 Sep 2024 02:08:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04BC2C4CEC3; Thu, 26 Sep 2024 02:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727316547; bh=M6ISVRGWt2YWY2xkGb/Zh1/Y2FhcZIYx1Ll7zaW+C08=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lYN3jqPoNP5YDqf60G7WyiKAO2OBv9hpFUejKtuQCgTrhIdYCmuW0sxrN7wCGp5fL 2YAm9Jye8BOUTlUjMPlVM/zx8zuEWV4OKbEzPGdw3nLqAPPsmwM0HGCbWf78gjRFe7 Cy89DDGvSF2EG3set4sjEAVMuUXf83MW+Yy7hYJxQSRUHV6hAwDv+G7LIzHG6kFp3R TWiL7jLgKkxi737wRPytv/lsAWBKHiHB6I0v6EVmWpSv0MVao5WJ8SzN16rV4KiQ+5 AygH/X0HluzBMr4VcLlPsrSBcNmI5cfx1nUYLKmWlsuad6izgrsKMZ7gI0KB30R0GZ u3rceLwUs4x1w== Date: Wed, 25 Sep 2024 21:09:06 -0500 From: Rob Herring To: Laurentiu Mihalcea Cc: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Daniel Baluta , Shengjiu Wang , Iuliana Prodan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/6] dt-bindings: dsp: fsl,dsp: fix power domain count Message-ID: <20240926020906.GA2246040-robh@kernel.org> References: <20240925232008.205802-1-laurentiumihalcea111@gmail.com> <20240925232008.205802-2-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925232008.205802-2-laurentiumihalcea111@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_190908_523066_9A6D41F1 X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 25, 2024 at 07:20:03PM -0400, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea > > Per the current binding, QM/QXP DSPs are supposed to have 4 > power domains, while the rest just 1. For QM/QXP, the 4 power > domains are: DSP, DSP_RAM, MU13A, MU13B. > > First off, drop MU13A from the count. This is attached to the > platform device of lsio_mu13. This decreases the count to 3. > > Secondly, drop DSP and DSP_RAM from the count for QXP. These > are attached to the platform devices of the lpcgs (used as clock > providers for the DSP). What's a platform device? Sounds like some Linux implementation detail. The number of power islands for a h/w block shouldn't be changing. > > With this in mind, the number of required power domains for QXP > is 1 (MU13B), while for QM it's 3 (MU13B, DSP, DSP_RAM). > > Additionally, two extra power domains may be required in the case > of QM/QXP DSPs. These are IRQSTR_DSP and MU2A. For the nodes using > the "-hifi4" compatibles these PDs are optional, while for nodes using > the "-dsp" compatibles these are mandatory. > > These changes reflect all of this information. > > Signed-off-by: Laurentiu Mihalcea > --- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 62 +++++++++++++++---- > 1 file changed, 49 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > index 9af40da5688e..e2f016af1048 100644 > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > @@ -51,8 +51,6 @@ properties: > description: > List of phandle and PM domain specifier as documented in > Documentation/devicetree/bindings/power/power_domain.txt > - minItems: 1 > - maxItems: 4 Top level should be the range of domains that covers all variants. > > mboxes: > description: > @@ -97,16 +95,55 @@ allOf: > properties: > compatible: > contains: > - enum: > - - fsl,imx8qxp-dsp > - - fsl,imx8qm-dsp > - - fsl,imx8qxp-hifi4 > - - fsl,imx8qm-hifi4 > + const: fsl,imx8qxp-hifi4 > then: > properties: > power-domains: > - minItems: 4 > - else: > + maxItems: 3 > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8qxp-dsp > + then: > + properties: > + power-domains: > + minItems: 3 > + maxItems: 3 > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8qm-dsp > + then: > + properties: > + power-domains: > + minItems: 5 > + maxItems: 5 > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8qm-hifi4 > + then: > + properties: > + power-domains: > + minItems: 3 > + maxItems: 5 > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mp-dsp > + - fsl,imx8mp-hifi4 > + - fsl,imx8ulp-dsp > + - fsl,imx8ulp-hifi4 > + then: > properties: > power-domains: > maxItems: 1 > @@ -157,10 +194,9 @@ examples: > <&adma_lpcg IMX_ADMA_LPCG_OCRAM_IPG_CLK>, > <&adma_lpcg IMX_ADMA_LPCG_DSP_CORE_CLK>; > clock-names = "ipg", "ocram", "core"; > - power-domains = <&pd IMX_SC_R_MU_13A>, > - <&pd IMX_SC_R_MU_13B>, > - <&pd IMX_SC_R_DSP>, > - <&pd IMX_SC_R_DSP_RAM>; > + power-domains = <&pd IMX_SC_R_MU_13B>, > + <&pd IMX_SC_R_IRQSTR_DSP>, > + <&pd IMX_SC_R_MU_2A>; > mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; > mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>; > memory-region = <&dsp_reserved>; > -- > 2.34.1 >