From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6AEECCFA15 for ; Thu, 26 Sep 2024 03:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KCxZTZ1euyY54qbLVhSCXA9DvC9lVSXbCKQM3aJpPaI=; b=eQ5F9HdSykQbC4ppQWkNHw7x/S NgWkTcQgy5x66ZDw97xzOkPlabOcdYov9WZklRJZKSanpwycrXj3dK91ZCU//NePsf6b93jAOa3h2 QnVknggMNHe7M5Gii1ZPGC4rxX5eCvgIXSf5nB7WYn8Fwh45HUi29eLu7CmZ85mzhN+Uafj3tlszy X+uD+5sQNPdnA30hJZdC63CcezjE+wXif7Gtnaq2c9p2F1hi4+eVTAlqG6RImLCkKTBMxWlyZ80bs 3rZEK7s9SIpbNLDiRukOj7Ty7/XzzHVxqeHC4L2X4GR9NHUKY40ie+G0HvUyuDbEj/RfSQfMY7o61 POJwuNbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stfJV-000000076HP-42PM; Thu, 26 Sep 2024 03:37:10 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stfDZ-000000075bq-3U1T for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2024 03:31:06 +0000 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2e078d28fe9so410009a91.2 for ; Wed, 25 Sep 2024 20:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727321461; x=1727926261; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=KCxZTZ1euyY54qbLVhSCXA9DvC9lVSXbCKQM3aJpPaI=; b=bn/kEhYbscRU+E4IGsH6/YSBdia0DXhxMTDuk18KiEP9YbMcF1xSyQzoAZa009mQgP jz2lE5SgNFR3HJfyqEOUOSTbQMkarQeY9IduYk4yDpSY1VhlKmz8AaKX31NPOdqdpEmC QVsnea1MWSi3scgPkbsnkAJtrXteyOGDG5wbuNcNJjV9/ETuRZX820o7XjDBTNbUPob9 3o2Dm4yTZgvmCUV/RwLcRIb398NVeX7Pu2gIVFzDctT3UsM011u3MMgej5v/zMUESij2 bE0Byim5VD8nOSkp5q37b6F8kt2Ir0ZV54AVRJ6O+hh7KpXZAHP8OPNCPYAQtDTcBwcV 3aSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727321461; x=1727926261; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCxZTZ1euyY54qbLVhSCXA9DvC9lVSXbCKQM3aJpPaI=; b=p39LaQFmibtUqP3k0XNeptsnd5RZRdrkJFNeBXwb5XPyHGDv8Amvny8ZlyXbs5v1kZ VZ9FJibOrPhyorwBd6ydghdYIbyw4nh+o/Fn42/tPMB+3+ttZqeAP7qLd/KslHEmaS+L m8q7quIjXvAJcc2ZE5u5LZpljvB4LLhqYlowPqtBsDba1DadKU+cvp8aBkOVGAg4A1M8 7fFp9sFesVl9u7iMxgHSSX1eIknEmgn60LTZDUOaSdAV0ds05lRxdNKBI7mK1j6h1VOq FhfaFDE+FDw1qAKYPZIppTWczi2C04XAOzvA9gu66e1olOhQHKVe8XCqBV4+GS9e5Gf5 kTNg== X-Forwarded-Encrypted: i=1; AJvYcCXzsziJdXR0P+1fPebB2X7FcKsYDcgV/qK1A6kZJTFkXUhEoJPtlH1c14VJ6u5bgiVvvDNJ6waqBkHaxVr2jnKx@lists.infradead.org X-Gm-Message-State: AOJu0YwJXABX1DxFuUbnIl90fiPYqm+F1EsfFf9+a0/+/ARjKC+i0Akn nfd3Im9/YuKAbW0R4qqGkgQ+/3gd9P3AEay9TBbQwtq8slfxsTz6jNAGJg== X-Google-Smtp-Source: AGHT+IGQDwBefWrAFN11jrRpwyPnqaaEUT7c3ati0zWLQssXOQSb+CN5F4cnku8kK40cd8hznu3odQ== X-Received: by 2002:a17:90a:8c98:b0:2c9:9658:d704 with SMTP id 98e67ed59e1d1-2e06b005dd5mr4161010a91.40.1727321460651; Wed, 25 Sep 2024 20:31:00 -0700 (PDT) Received: from localhost ([183.226.245.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e06e1ae753sm2228130a91.14.2024.09.25.20.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 20:31:00 -0700 (PDT) From: chenqiwu X-Google-Original-From: chenqiwu Date: Thu, 26 Sep 2024 11:30:45 +0800 To: Oleg Nesterov Cc: chenqiwu , corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, paulmck@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v4 1/2] panic: add option to dump task maps info in panic_print Message-ID: <20240926033045.GA3811@rlk> References: <20240924074341.37272-1-qiwu.chen@transsion.com> <20240924113322.GA7248@redhat.com> <20240925082759.GB2941@rlk> <20240925121957.GB26882@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925121957.GB26882@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_203101_907428_36E8D4EB X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 25, 2024 at 02:19:58PM +0200, Oleg Nesterov wrote: > On 09/25, chenqiwu wrote: > > > > On Tue, Sep 24, 2024 at 01:33:54PM +0200, Oleg Nesterov wrote: > > > > > > > + if (path) { > > > > + name = d_path(path, name_buf, sizeof(name_buf)); > > > > + name = IS_ERR(name) ? "?" : name; > > > > > I think this is an easier way to get file path name which deals with IS_ERR(name) case. > > > perhaps this needs mangle_path() ... > > Sorry, I don't understand your reply... > I means we can dump the file path name by d_path() directly without escaping "\n" by mangle_path(). I try to test the patch in arm64 qemu, it can show the same file path name as /proc/$pid/maps. Thanks Qiwu