From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28971CDD1CD for ; Fri, 27 Sep 2024 18:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=+KzWXvhZLejLYSwzsL0VCreiZ64XK6rERtqTeRm7HWw=; b=f/E1dWZlJ2J/HlxdPn15cGJKlO ON+3T5IwWPTI56B+WrW2YZUg8zw5eurw9jgyHUH7uQP81FzjNN0FG5zZSWJ+eE4njL0+EZtLdzQz4 R2NDWYpoqxHU1Rxc6xfGeacACI1ZfhtYM8A/dFGLMWffqBpXD+P08MBmq4WTmxNc9lInAMrAL7Ba1 /ZfOKBJnP4e7M6C32eHF89dMlRLj1NmTQMI5W+GIdupXWwkWcQEWl0BWUKIH+FNdq5vJ8np72fK9f vl3r9EJIddeaIOHoLhqVBcl5uu2tNe5QwbAvoMl7BbWFvbemaQoP5wQpAnJwZ28poXjpyeBXRhd/n /6P5wuFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1suFdE-0000000BqyY-16Ny; Fri, 27 Sep 2024 18:23:56 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1suFc1-0000000Bqt9-2z6h; Fri, 27 Sep 2024 18:22:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 19EA45C558E; Fri, 27 Sep 2024 18:22:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8520AC4CEC4; Fri, 27 Sep 2024 18:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727461360; bh=Aj6QsXN9+wurRdEhLLOgrIKRi1TKrZH9iLUL4lOE1aI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=HrJ9iO9Y/DzVq8thg17WFcf91NweE6AOMVZnFbBW6wetlh8Dzbd9hwP61HNIEw7qx Sw+FwQQ+5GuwF5ZyKG6x6LYW+HRsm9H8+TvvynPjlDLbb+Con37B2qfukao8pNaVKg aMhjTDC7cWr07Vr6bhNfgFo/LHSAoAgxfQpdbCejz0NJplLsM8hXHSyJoTwCZNIjRo KdXgeciJAPYNeaEE+CwCSyEUGQgyePSXJTqJC34wGJOnsfGgkkWO16f/Zv+J3LByVK Zsy+GXUswnLxIZ878CbvnmLfxy6BHDZDc0BrbGQu0wgZHTZdIvBVU/3PojaWCftmL8 IOZQINqOzH48g== Date: Fri, 27 Sep 2024 13:22:38 -0500 From: Bjorn Helgaas To: Anand Moon Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/6] PCI: rockchip: Simplify clock handling by using clk_bulk*() function Message-ID: <20240927182238.GA85539@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_112241_819917_A110571F X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 27, 2024 at 01:47:44PM +0530, Anand Moon wrote: > On Mon, 2 Sept 2024 at 00:03, Anand Moon wrote: > > > > Refactor the clock handling in the Rockchip PCIe driver, > > introducing a more robust and efficient method for enabling and > > disabling clocks using clk_bulk*() API. Using the clk_bulk APIs, > > the clock handling for the core clocks becomes much simpler. > > > > Signed-off-by: Anand Moon > > Do you have any review comments on this series? Looks like nice work, thanks. Minor tips below. We'll start applying PCI patches to v6.13-rc1 after it is tagged. It looks like these will apply cleanly, so no rebasing needed. - It would be helpful if you can add a cover letter (0/n), which is a good place for the overall diffstat and series-level changelog. - This v5 series adds drivers/phy patches, which are also related to rockchip, but will be handled by a different maintainer, so best to send them as separate series (and of course send the phy patches to the right maintainer, linux-phy, etc). - "b4 am -o/tmp/ 20240901183221.240361-2-linux.amoon@gmail.com" complains about something, I dunno how to fix: Checking attestation on all messages, may take a moment... --- ✗ [PATCH v5 1/6] PCI: rockchip: Simplify clock handling by using clk_bulk*() function ✗ [PATCH v5 2/6] PCI: rockchip: Simplify reset control handling by using reset_control_bulk*() function ✗ [PATCH v5 3/6] PCI: rockchip: Refactor rockchip_pcie_disable_clocks function signature ✗ [PATCH v5 4/6] phy: rockchip-pcie: Simplify error handling with dev_err_probe() ✗ [PATCH v5 5/6] phy: rockchip-pcie: Change to use devm_clk_get_enabled() helper ✗ [PATCH v5 6/6] phy: rockchip-pcie: Use regmap_read_poll_timeout for PCIe reference clk PLL status --- ✗ BADSIG: DKIM/gmail.com - In 3/6 and 6/6 commit logs, add parens after function names as you did elsewhere. - Super nit: In 5/6, s/Change to use/Use/. Every patch is a change, so "Change to" doesn't add any information. Bjorn