From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C461CF6493 for ; Sat, 28 Sep 2024 20:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5g/GbLVNzyIk2tMYnpwq2qGJHO83h81HrN4l1i13zrg=; b=pQ8rFkIX5hWnmV8EfzMclPngZK bF8vwCTpaB2cPSqtoxWnoOmIkdzBy0u0o0N/A6VCXxryVHfmoQVXDVEGc8eNoThRozSMtn9nqAlCq qzph38TiVC60wMb45S8GMk+4kYtjZnozNcNveff6LTfy14mlBccOiga/jzaS8BaXvBGFicoZahLQU g0BstbsEcr5YoALBFUGQ2MyWpoUCbwMk1/g5cNuNgSzTQI2Op2bwcJLlI4OkNkz/9TrBUIz0SOZJo KFhIF4L7TzK4RPtWyWnb+gjoeJkweRLIZ/F1mu4U4ZWhn8E+ySvsHipC0nqhVH6AHW93jc6qMGibn krwMQ4kA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sudoy-0000000Da4S-2TLi; Sat, 28 Sep 2024 20:13:40 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sudnl-0000000DZzK-3rX5 for linux-arm-kernel@lists.infradead.org; Sat, 28 Sep 2024 20:12:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1D43FA40C06; Sat, 28 Sep 2024 20:12:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2EE4C4CEC3; Sat, 28 Sep 2024 20:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727554343; bh=I26IhX4NPnUeeWPTVvJaD0+ucaQP/7Z8uFoi3S8v0Bk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JI/efwwFtDmd+Nkm6Hsk/gt9t5XEcQqUqD6b0o9RIUI+KDDCIgO8mlFeVr8Jyyy9j 5A0ZX0W7fAwebJwawO3dh13IX0OT/81s5+95Rj/ux3eS4cdNz3UixGYMloVSl32d5/ ldHHuC+BLQm2X+9+Hho5fu5cEKRSyxsJGxt+OLHm8tG4L1ylu3UJTs5Bd0Nv5hwqEL p7EKwU2ON28oYc49PQI9ovO6XdjWtI3gYJc/qN/7DLSkJTkFaVEWOzbVw3IfclOmve F5pLNYURtBGOEfxu6fg3shNJroczcjQx+mkla31XkuDYkXlvV7GwMwm2SSKuXMHp6R EvTZ0wgbrpeLA== Date: Sat, 28 Sep 2024 21:12:18 +0100 From: Conor Dooley To: Krzysztof Kozlowski Cc: "Mahapatra, Amit Kumar" , "broonie@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "Simek, Michal" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "git (AMD-Xilinx)" , "amitrkcian2002@gmail.com" Subject: Re: [PATCH] dt-bindings: spi: xilinx: Add clocks & clock-names properties Message-ID: <20240928-postcard-lively-c0c9bbe74d04@spud> References: <20240923123242.2101562-1-amit.kumar-mahapatra@amd.com> <20240924-impaired-starving-eef91b339f67@spud> <20240925-trapdoor-stunt-33516665fdc5@spud> <03a1c7e7-c516-41ab-a668-7c6785ab1c4f@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1NX/bfG8PX15XlnI" Content-Disposition: inline In-Reply-To: <03a1c7e7-c516-41ab-a668-7c6785ab1c4f@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240928_131226_112140_C6E27FF4 X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --1NX/bfG8PX15XlnI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 28, 2024 at 10:19:01AM +0200, Krzysztof Kozlowski wrote: > On 27/09/2024 11:30, Mahapatra, Amit Kumar wrote: > > Hello Conor, > >=20 > >=20 > >>>> Subject: Re: [PATCH] dt-bindings: spi: xilinx: Add clocks & > >>>> clock-names properties > >>>> > >>>> On Mon, Sep 23, 2024 at 06:02:42PM +0530, Amit Kumar Mahapatra wrote: > >>>>> Include the 'clocks' and 'clock-names' properties in the AXI > >>>>> Quad-SPI bindings. When the AXI4-Lite interface is enabled, the > >>>>> core operates in legacy mode, maintaining backward compatibility > >>>>> with version 1.00, and uses 's_axi_aclk' and 'ext_spi_clk'. For > >>>>> the AXI interface, it uses 's_axi4_aclk' and 'ext_spi_clk'. > >>>>> + properties: > >>>>> + clock-names: > >>>>> + items: > >>>>> + - const: s_axi_aclk > >>>>> + - const: ext_spi_clk > >>>> > >>>> These are all clocks, there should be no need to have "clk" in the n= ames. > >>> > >>> These are the names exported by the IP and used by the DTG. > >> > >> So? This is a binding, not a verilog file. > >=20 > > Axi Quad SPI is an FPGA-based IP, and the clock names are derived from = the=20 > > IP signal names as specified in the IP documentation [1].=20 > > We chose these names to ensure alignment with the I/O signal names list= ed=20 > > in Table 2-2 on page 19 of [1]. > >=20 > > [1] chrome-extension://efaidnbmnnnibpcajpcglclefindmkaj/https://www.amd= =2Ecom/content/dam/xilinx/support/documents/ip_documentation/axi_quad_spi/v= 3_2/pg153-axi-quad-spi.pdf >=20 > So if hardware engineers call them "pink_pony_clk_aclk_really_clk" we > should follow... >=20 > - bus or axi > - ext_spi or spi >=20 > You have descriptions of each item to reference real signals. Conor's > comment is valid - do no make it verilog file. >=20 > >=20 > >> > >>>>> + > >>>>> + else: > >>>>> + properties: > >>>>> + clock-names: > >>>>> + items: > >>>>> + - const: s_axi4_aclk > >>>>> + - const: ext_spi_clk >=20 > Nah, these are the same. They may be different, depending on whether or not the driver has to handle "axi4-lite" versus "axi" differently. That said, I find the commit message kinda odd in that it states that axi4-lite goes with the s_axi_aclk clock and axi goes with s_axi4_aclk. Seems backwards.. --1NX/bfG8PX15XlnI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZvhjIgAKCRB4tDGHoIJi 0hFsAP9qhLfMvQnzh6cmsRecT9CTopCWp6KmwX/VcslN+ktYaAEAi5sAx2oVJBfy K00tigLYMqwYoZS6Oac4xOrzlxuOaAs= =lz2t -----END PGP SIGNATURE----- --1NX/bfG8PX15XlnI--