From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A812CCF649D for ; Mon, 30 Sep 2024 09:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=08CqMCR40QeByk4ty6nskGAarldWWiP1HXvLuo/jmq8=; b=iZel4zURk/KJnPRTBr3jb7dInY 3FWPttHIHWKa4l+6fjy0F5Pvv55AyuPWHx6/aG/tmD8kKIBFAHrSuSWC+NxIj3SrvxEgRAuYoqESE B/vQ1cTh7v2Hat1jXR1D5AA+XqMUJ6wn9QkiZCRPZX/TKbhvM8gbmfnkC7NUWtg1zg2MtvD8jGtta P8Z57RoRGvHxk9y3taQHds8REGZCI3FovBdSnyd6Mw1LkN1F38ex++sjHgzLvTTJdo9SrTzOvjupG 1eYPuYz1r2T3OJ0aq7LmkHrMQB/myzRaVHy0qAHy9fUA4FQK+iVtu55xbPCjxLVz1sfug9hncgcP3 7p2fdtcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svCce-0000000GUx2-3fOf; Mon, 30 Sep 2024 09:23:17 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svCYq-0000000GU5U-2S9T; Mon, 30 Sep 2024 09:19:22 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5E4A62000F; Mon, 30 Sep 2024 09:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1727687957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=08CqMCR40QeByk4ty6nskGAarldWWiP1HXvLuo/jmq8=; b=aryuuA522t22D8cTiaR7wOrrrGfDITc/83JLG7Jb/SzmS/GFsmyD7kPvEqzaqvtRZ8JhTh DqvJ9QEo9K3e69VI9MQzf5f7FArwYHbcNVyeVG+DR6qkPaV9N6OytyFv6MUqJu1Rk6a41Q pjJMF0s8zolKg0F6Nkfaudp+au93S7qmnwUEtp/yLsAXPUN1FE1V76z7Eqn8sqxJgeUc0r Uk8TAT0Y0oeEplXvLsoUieX6TaC95JvVNjj3QP/S9jE4akg/aMvrGhoIrhND4RdKknlP1s ImKyhYXYuGirdnUn6QiePxg5j62zCSjKN5QPRf117LZiWPzRkWg9Dzi5pGtqtA== Date: Mon, 30 Sep 2024 11:19:14 +0200 From: Miquel Raynal To: "Peng Fan (OSS)" Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Marco Felsch , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator Message-ID: <20240930111914.4b412581@xps-13> In-Reply-To: <20240930-spi-v2-2-ed7f6bcbe0df@nxp.com> References: <20240930-spi-v2-0-ed7f6bcbe0df@nxp.com> <20240930-spi-v2-2-ed7f6bcbe0df@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_021920_802871_5685507A X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, peng.fan@oss.nxp.com wrote on Mon, 30 Sep 2024 17:22:25 +0800: > From: Peng Fan >=20 > SPI NOR flashes needs power supply to work properly. The power supply > maybe software controllable per board design. So add the support > for an vcc-supply regulator. >=20 > Signed-off-by: Peng Fan > --- > drivers/mtd/spi-nor/core.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index 9d6e85bf227b..5249c8b13916 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -3462,6 +3463,10 @@ int spi_nor_scan(struct spi_nor *nor, const char *= name, > if (!nor->bouncebuf) > return -ENOMEM; > =20 > + ret =3D devm_regulator_get_enable(dev, "vcc"); _optional ? > + if (ret) > + return ret; > + > ret =3D spi_nor_hw_reset(nor); > if (ret) > return ret; >=20 Thanks, Miqu=C3=A8l