From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Hans Verkuil" <hverkuil@xs4all.nl>,
"Ricardo Ribalda" <ribalda@chromium.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Bingbu Cao" <bingbu.cao@intel.com>,
"Tianshu Qiu" <tian.shu.qiu@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Mike Isely" <isely@pobox.com>,
"Olli Salonen" <olli.salonen@iki.fi>,
"Maxim Levitsky" <maximlevitsky@gmail.com>,
"Sean Young" <sean@mess.org>, "Sergey Kozlov" <serjk@netup.ru>,
"Abylay Ospan" <aospan@netup.ru>,
"Jemma Denson" <jdenson@gmail.com>,
"Patrick Boettcher" <patrick.boettcher@posteo.de>,
"Ming Qian" <ming.qian@nxp.com>, "Zhou Peng" <eagle.zhou@nxp.com>,
"Andy Walls" <awalls@md.metrocast.net>,
"Michal Simek" <michal.simek@amd.com>,
"Jean-Christophe Trotin" <jean-christophe.trotin@foss.st.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Eddie James" <eajames@linux.ibm.com>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Tomasz Figa" <tfiga@chromium.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Tim Harvey" <tharvey@gateworks.com>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 00/45] media: Use string_choice helpers
Date: Mon, 30 Sep 2024 14:56:18 +0200 [thread overview]
Message-ID: <20240930145446.10d832e9@foz.lan> (raw)
In-Reply-To: <20240930124619.GG31662@pendragon.ideasonboard.com>
Em Mon, 30 Sep 2024 15:46:19 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> > >> Cocci has located some places where the helpers can be used. This
> > >> patchset uses the diff generated by cocci, plus these changes:
> > >
> > > Personally I think most of those helpers just hinder readability for not
> > > much added gain. String de-duplication is done by the linker already.
> > > The only value I see in the helpers is ensuring that the strings are
> > > consistently written, and I think we can do so through other means.
> >
> > Just my opinion: I'm OK with these new helpers,
>
> Coding style opinions are personal preferences of course :-) My opinion
> is that this hinders readability for no benefit.
Agreed. New code somewhat obfuscates what it does with no benefit
except maybe saving a few bytes on each drive.
Thanks,
Mauro
next prev parent reply other threads:[~2024-09-30 13:46 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 12:03 [PATCH 00/45] media: Use string_choice helpers Ricardo Ribalda
2024-09-30 12:03 ` [PATCH 01/45] media: staging: ipu3: Use string_choices helpers Ricardo Ribalda
2024-09-30 12:03 ` [PATCH 02/45] media: staging: atomisp: " Ricardo Ribalda
2024-09-30 12:03 ` [PATCH 03/45] media: core: " Ricardo Ribalda
2024-09-30 12:03 ` [PATCH 04/45] media: pwc-ctl: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 05/45] media: pvrusb2:Use " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 06/45] media: em28xx: Use " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 07/45] media: dvb-usb: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 08/45] media: dvb-usb-v2: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 09/45] media: cx231xx: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 10/45] media: tuners: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 11/45] media: rc: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 12/45] media: dvb-frontends: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 13/45] media: pci: cx23885: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 14/45] media: saa7134: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 15/45] media: amphion: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 16/45] media: pci: ivtv: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 17/45] media: bttv: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 18/45] media: xilinx: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 19/45] media: platform: ti: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 20/45] media: st: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 21/45] media: coda: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 22/45] media: aspeed: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 23/45] media: ipu6: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 24/45] media: cx18: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 25/45] media: cobalt: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 26/45] media: videobuf2: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 27/45] media: cec: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 28/45] media: b2c2: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 29/45] media: siano: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 30/45] media: i2c: cx25840: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 31/45] media: i2c: vpx3220: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 32/45] media: i2c: tvp7002: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 33/45] media: i2c: ths8200: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 34/45] media: i2c: tda1997x: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 35/45] media: i2c: tc358743: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 36/45] media: i2c: st-mipid02: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 37/45] media: i2c: msp3400: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 38/45] media: i2c: max9286: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 39/45] media: i2c: saa717x: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 40/45] media: i2c: saa7127: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 41/45] media: i2c: saa7115: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 42/45] media: i2c: saa7110: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 43/45] media: i2c: adv7842: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 44/45] media: i2c: adv76xx: " Ricardo Ribalda
2024-09-30 12:04 ` [PATCH 45/45] media: i2c: adv7511: " Ricardo Ribalda
2024-09-30 12:21 ` [PATCH 00/45] media: Use string_choice helpers Laurent Pinchart
2024-09-30 12:38 ` Hans Verkuil
2024-09-30 12:46 ` Laurent Pinchart
2024-09-30 12:56 ` Mauro Carvalho Chehab [this message]
2024-09-30 12:53 ` Ricardo Ribalda
2024-09-30 13:41 ` Laurent Pinchart
2024-09-30 14:36 ` Julia Lawall
2024-10-01 7:49 ` Hans Verkuil
2024-10-01 10:40 ` Julia Lawall
2024-09-30 12:57 ` Andy Walls
2024-09-30 14:00 ` Dan Carpenter
2024-09-30 15:34 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930145446.10d832e9@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=andy@kernel.org \
--cc=aospan@netup.ru \
--cc=awalls@md.metrocast.net \
--cc=benjamin.mugnier@foss.st.com \
--cc=bingbu.cao@intel.com \
--cc=eagle.zhou@nxp.com \
--cc=eajames@linux.ibm.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=hverkuil@xs4all.nl \
--cc=imx@lists.linux.dev \
--cc=isely@pobox.com \
--cc=jacopo+renesas@jmondi.org \
--cc=jdenson@gmail.com \
--cc=jean-christophe.trotin@foss.st.com \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.szyprowski@samsung.com \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=ming.qian@nxp.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=olli.salonen@iki.fi \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=patrick.boettcher@posteo.de \
--cc=ribalda@chromium.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=sean@mess.org \
--cc=serjk@netup.ru \
--cc=shawnguo@kernel.org \
--cc=sylvain.petinot@foss.st.com \
--cc=tfiga@chromium.org \
--cc=tharvey@gateworks.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).