From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35A94CE8347 for ; Mon, 30 Sep 2024 13:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+Y2rA94ZRCsge94Mb2n9rvp+3ph01mmSYoe6xjzea6A=; b=IOgJPT8SwEQG7ScHeTgia98DY9 Q1HuG7hfucwokqeCJUqQkQy20l+Y/cWH8zkgaHaBjzxVj+FGc1q8iap7yQyvOm2PSFsPp9BdHfiL6 6beIUZteBVHdyYU3oRjGsN7/useMLmw/wg3CdTnBGZsz3ERNjYVOpbmI+MHZEH/U5EoU04EeaDs09 SVk2nTSD1INfJI/74UWyYlU2nn/JYg3HpZ85/dvJBdt21TSapkBDRsJxUlWq793Au+ppKi88ltV9V 8TogGvJ2RmB8T86gjrMOyfaEFLjUiOTosc0WN/pkUj3ZP2y2TQqTaGWaEcw+NksOc1nb0U3V3/pkL DssrVU+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svGiu-0000000HMZF-3vh4; Mon, 30 Sep 2024 13:46:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svFx7-0000000HAFt-3nUv for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2024 12:56:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 14DA45C0FF4; Mon, 30 Sep 2024 12:56:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71D88C4CEC7; Mon, 30 Sep 2024 12:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727700996; bh=86l+n3oUOCw3cRUKaIVSOwRNK+3sfcj6behnUqpUl4U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rUoVx6PV6rUDCc6U4wZInfOCNP8K9UdicEzWn6HmqDWqtSHMeG0hQyJJSrrhT6xmq 3u/bHlw9T6wv1VV1oSFimbRei++Uxh8fHUdGmMVbW7+UaoOgNJZh8qIUNx2f38wkDz 0i4O+1yL5J6l5J8D0oZqI2JpEKkFIF2F46znp5YvyMYSJ6SjDRQ6/FqZgEdmeHZN9O 35XEnqQRb+eXZPluuW71hMkfQdJ/fEhfcRWCOV+TG9VBRyVa0W6TZJqaovdfxZkzMS 0ZSJpYFwGpNxgLdckGd45p3qyC3hlcPqPV4kJ1PCA1dVhJ4jsfm8zOGX0J+6Qy0sye OjZviUqSTgiog== Date: Mon, 30 Sep 2024 14:56:18 +0200 From: Mauro Carvalho Chehab To: Laurent Pinchart Cc: Hans Verkuil , Ricardo Ribalda , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans de Goede , Andy Shevchenko , Mike Isely , Olli Salonen , Maxim Levitsky , Sean Young , Sergey Kozlov , Abylay Ospan , Jemma Denson , Patrick Boettcher , Ming Qian , Zhou Peng , Andy Walls , Michal Simek , Jean-Christophe Trotin , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Eddie James , Joel Stanley , Andrew Jeffery , Hans Verkuil , Tomasz Figa , Marek Szyprowski , Tim Harvey , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Niklas =?UTF-8?B?U8O2ZGVybHVuZA==?= , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH 00/45] media: Use string_choice helpers Message-ID: <20240930145446.10d832e9@foz.lan> In-Reply-To: <20240930124619.GG31662@pendragon.ideasonboard.com> References: <20240930-cocci-opportunity-v1-0-81e137456ce0@chromium.org> <20240930122157.GF31662@pendragon.ideasonboard.com> <4873f3a0-bd82-4ace-a783-10ea137284d6@xs4all.nl> <20240930124619.GG31662@pendragon.ideasonboard.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_055638_077946_E41A83C5 X-CRM114-Status: GOOD ( 14.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, 30 Sep 2024 15:46:19 +0300 Laurent Pinchart escreveu: > > >> Cocci has located some places where the helpers can be used. This > > >> patchset uses the diff generated by cocci, plus these changes: > > > > > > Personally I think most of those helpers just hinder readability for not > > > much added gain. String de-duplication is done by the linker already. > > > The only value I see in the helpers is ensuring that the strings are > > > consistently written, and I think we can do so through other means. > > > > Just my opinion: I'm OK with these new helpers, > > Coding style opinions are personal preferences of course :-) My opinion > is that this hinders readability for no benefit. Agreed. New code somewhat obfuscates what it does with no benefit except maybe saving a few bytes on each drive. Thanks, Mauro