From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D89FCEACE9 for ; Tue, 1 Oct 2024 16:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8bgfs3OcpEXF9cPvj1xL5Q0DMnyiHSnE/Zs3T0yl9WU=; b=Fk8M4KBN0TxEMf889NNEiTkGNx sRj5RD1Ctcje1cxMJhjyrw34C3sceOlPOe2/K4g7XHzBepNaosRub5eRcoebxCKj4/L3kGlDYWmYD 2ebvl8c2kImlTB5PsBN4qTRGj0IwCwNt1vm7uARcueWsC2tx0ZhgbMfL3dWuI+YOTOvsG+R1R6stp 8LO9hTXXvkSqIrWUSwOTFALhN6qwL8+e76xOE8Ukh8ZpCqz+RznQAbOBMtCQF8b8a5r/bGhG/uQTF O2tzp87NMWFwWb2mRDiktxRz+zHlXj8lZI7hmYGQlhe0+/yz7dRvVtRANn09eBpiwesZZVyDZZ53A bmA7tktQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svg8A-00000003bCy-1VRc; Tue, 01 Oct 2024 16:53:46 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svg6w-00000003b4z-1hWJ for linux-arm-kernel@bombadil.infradead.org; Tue, 01 Oct 2024 16:52:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8bgfs3OcpEXF9cPvj1xL5Q0DMnyiHSnE/Zs3T0yl9WU=; b=EwlbTWtnqxI+IQ/Rcszr3Cb7e4 VKP187mBKS05FfNI9DWhe0fjb6K4EH1TP0nEEpMiuZXQxaUgAsbYjYWFwq18WWMPSywB6Aumqyjaf IcPX1doBQ8LZoUekH6m4t0MZZ4pECqfyaGsj1I2fDLmd7FN7gsdYIOddsHMWBMASVDIpLpIx+maj2 rkK6D0Z8kiemnKxzIIshNzSJVVsQ2qEi7WGYbs14SO40lImj1sLgCqeVpBwMceiwa/17UF40IrmD8 T83qmLiAFeVa/BNJMo+SwTTMz590bGE0DMqEFWtr7OsbW4l5pVUiQvWVaiO3e6u4WVJenMjRBl/BE 9+6/Ua1g==; Received: from dfw.source.kernel.org ([139.178.84.217]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svg6t-00000003Esx-1QBt for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 16:52:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AB15B5C54CE; Tue, 1 Oct 2024 16:52:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC87EC4CED3; Tue, 1 Oct 2024 16:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727801545; bh=O8kM/T6VQqLQbAH1MWMkPU1BLFMr1RVAP4rN0s02mhY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kacD0SyNQ80uIodoXTzcKc2JX5cGyPiCGUzw6s0YxSi2CjAUrOHaktNh5rPZVX2Cf VLja/2UVw6qoDyVyDNLq8XVmEBDu1RyINYWTiWlFvUZ+4Qkq2yFWaEjo6hcsMZbzY5 Uw1yrpgyoLQXA+SbRMm6dYf/blaC+peDqcEBrskjBKTjq4O3EFNBpvbA1nPJmmbWMc Ls1TNKKjycwbnTNvTEle44503QULCE4jERtX+tcXY06m7Lf0qFt6q8uDvJTa+9InRJ v3gc1QQ7n7xfiyMokQZJKOArrJAf9vAbVXVNmUMm2mnOoj+hYoBFr8V62z7YE98F7z 6WeG2kl8ltEvQ== Date: Tue, 1 Oct 2024 17:52:19 +0100 From: Conor Dooley To: Radhey Shyam Pandey Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, michal.simek@amd.com, abin.joseph@amd.com, u.kleine-koenig@pengutronix.de, elfring@users.sourceforge.net, harini.katakam@amd.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@amd.com Subject: Re: [PATCH net-next 1/3] dt-bindings: net: emaclite: Add clock support Message-ID: <20241001-battered-stardom-28d5f28798c2@spud> References: <1727726138-2203615-1-git-send-email-radhey.shyam.pandey@amd.com> <1727726138-2203615-2-git-send-email-radhey.shyam.pandey@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RQ7Mi1lo08Qqi5sg" Content-Disposition: inline In-Reply-To: <1727726138-2203615-2-git-send-email-radhey.shyam.pandey@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_175227_565578_1A744DFC X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --RQ7Mi1lo08Qqi5sg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 01, 2024 at 01:25:36AM +0530, Radhey Shyam Pandey wrote: > From: Abin Joseph >=20 > Add s_axi_aclk AXI4 clock support and make clk optional to keep DTB > backward compatibility. Define max supported clock constraints. Why was the clock not provided before, but is now? Was it automatically enabled by firmware and that is no longer done? I'm suspicious of the clock being made optional, but the driver doing nothing other than enable it. That reeks of actually being required to me. >=20 > Signed-off-by: Abin Joseph > Signed-off-by: Radhey Shyam Pandey > --- > Documentation/devicetree/bindings/net/xlnx,emaclite.yaml | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml b/D= ocumentation/devicetree/bindings/net/xlnx,emaclite.yaml > index 92d8ade988f6..8fcf0732d713 100644 > --- a/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > +++ b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml > @@ -29,6 +29,9 @@ properties: > interrupts: > maxItems: 1 > =20 > + clocks: > + maxItems: 1 > + > phy-handle: true > =20 > local-mac-address: true > --=20 > 2.34.1 >=20 --RQ7Mi1lo08Qqi5sg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZvwowwAKCRB4tDGHoIJi 0vouAP9IqvWh1E3qUt438ZfMnQXb1mwXnrDkP/wXybmQ18nDAwD9FtCI+Njapmt2 8f69L62OfMnwgP/1HSmAwSMxkZybRwA= =QW3P -----END PGP SIGNATURE----- --RQ7Mi1lo08Qqi5sg--