From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2202CCEACD5 for ; Tue, 1 Oct 2024 15:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iDwqWg5zq/fKwm8IzJT/Md0hSacM6LitsSEMNrkGEJw=; b=rgkpsKSEKGtxZTbcXYR6mGzYVc CkoreE+JK52siUrOUIsyVD9FFPTwR+Rid/fccGoS69uEWSy5i3ZD2rV3PVCz3DyFWoM0qTCwPddN0 9E6YUWojEkjiRE7BS8B96AfJnxfUpPxQXU+jmMLTk2RAV6SENaapeAN+GhmBfpqfPcX9ZrNG4s0cf 1OB2X/1P5fRIlgn2xquOOe8KRyveGNk1m7Ih6x6rn4LXfXsZEMKCXAuSSIFj/TDJ4/eiR3VroDE4f BI3DRVvUnpU+MRCuEBXg4Ml1eS0n0pnkmw4MBZgeUa8hRs6Lef1Ss5XezETFx9Q2Nu33csTRustky jhfxsfeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svewt-00000003LYJ-0yEb; Tue, 01 Oct 2024 15:38:03 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sveqV-00000003KhX-3WL5 for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 15:31:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6B8E75C4BDF; Tue, 1 Oct 2024 15:31:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBEE2C4CEC6; Tue, 1 Oct 2024 15:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727796686; bh=JTjMeNjAdjcmlXBo4g1OYjHb8ddMEYPTWyFl5S+f3Nk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HRuIQdjmGzWE9tAgt1bkBn1uYU8vXEtQKjdeuYPoCSsXIw8nZQvKapHO1bDLbXU9g HJ4HEa0SNiMYEKbuKt5G7nvxJUKKFn3e7qub3T/BWvATjy0Nw44YPQVq/9+4S5AsHv A6c/2T3rJWHL6FUXi3//WZUzxa6SDFtwFZxEurBDNXpmfo42MDU1cFLtqy3+l3I7RB 7sNE4RGFcllB6TGK3JNFntauk7e/Mkz9wKwPyFxLZIqs/Wt3XRXOYm9iJCwZMyxFBd HZBp4hkvslt6Rzh11p38mDEEZOYEIqK02cQV9+VKKrmCGCQDijC+Egv7lz3N84NPJ3 HdGuKClpsDk7Q== Date: Tue, 1 Oct 2024 16:31:21 +0100 From: Conor Dooley To: Andrei Simion Subject: Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes Message-ID: <20241001-sleet-bronchial-867258945373@spud> References: <20241001152541.91945-1-andrei.simion@microchip.com> <20241001152541.91945-5-andrei.simion@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pp7amhUoR3YGJ6qY" Content-Disposition: inline In-Reply-To: <20241001152541.91945-5-andrei.simion@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_083127_966737_115ED706 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, Alexander Dhal , linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --pp7amhUoR3YGJ6qY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 01, 2024 at 06:25:41PM +0300, Andrei Simion wrote: > Add the label property here and use the old node name as value to stay > stable and avoid breaking the userspace applications that depend on those > paths. >=20 > Suggested-by: Alexander Dhal > Signed-off-by: Andrei Simion Shouldn't this be squashed with 3/4 so as not to break it in one commit, only to fix it in another? > --- > v1 -> v2: > - added in v2 by suggestion of Alexander Dhal > --- > arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/= microchip/aks-cdu.dts > index 0c3373ad1723..b65f80e1ef05 100644 > --- a/arch/arm/boot/dts/microchip/aks-cdu.dts > +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts > @@ -99,22 +99,26 @@ leds { > compatible =3D "gpio-leds"; > =20 > led-red { > + label =3D "red"; > gpios =3D <&pioC 10 GPIO_ACTIVE_HIGH>; > linux,default-trigger =3D "none"; > }; > =20 > led-green { > + label =3D "green"; > gpios =3D <&pioA 5 GPIO_ACTIVE_LOW>; > linux,default-trigger =3D "none"; > default-state =3D "on"; > }; > =20 > led-yellow { > + label =3D "yellow"; > gpios =3D <&pioB 20 GPIO_ACTIVE_LOW>; > linux,default-trigger =3D "none"; > }; > =20 > led-blue { > + label =3D "blue"; > gpios =3D <&pioB 21 GPIO_ACTIVE_LOW>; > linux,default-trigger =3D "none"; > }; > --=20 > 2.34.1 >=20 --pp7amhUoR3YGJ6qY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZvwVtwAKCRB4tDGHoIJi 0puLAP9wTZxsWq9bQcikzeyGjPnJ9hykcLmPOcqId6xgxzKIywEAgLxNnEe+o0No sgVGhPNyUqz+VHFmJwNhgI92IxjAPgs= =yRwO -----END PGP SIGNATURE----- --pp7amhUoR3YGJ6qY--