Re: [PATCH 1/8] dt-bindings: clock: Add clock ID definition for Rockchip RK3528

Krzysztof Kozlowski
2024-10-02T06:34:38Z

On Tue, Oct 01, 2024 at 04:23:55AM +0000, Yao Zi wrote:
> There are two types of clocks in RK3528 SoC, CRU-managed and
> SCMI-managed. They are assigned independent clock IDs.
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> .../dt-bindings/clock/rockchip,rk3528-cru.h | 453 ++++++++++++++++++
> 1 file changed, 453 insertions(+)
> create mode 100644 include/dt-bindings/clock/rockchip,rk3528-cru.h
>
> diff --git a/include/dt-bindings/clock/rockchip,rk3528-cru.h b/include/dt-bindings/clock/rockchip,rk3528-cru.h
> new file mode 100644
> index 000000000000..c90b25f57973
> --- /dev/null
> +++ b/include/dt-bindings/clock/rockchip,rk3528-cru.h
> @@ -0,0 +1,453 @@
> +/* SPDX-License-Identifier: (GPL-2.0-or-later OR MIT) */

Wrong license.

> +/*
> + * Copyright (c) 2022 Rockchip Electronics Co. Ltd.
> + * Copyright (c) 2024 Yao Zi <ziyao@disroot.org>
> + * Author: Joseph Chen <chenjh@rock-chips.com>
> + */
> +
> +#ifndef _DT_BINDINGS_CLK_ROCKCHIP_RK3528_H
> +#define _DT_BINDINGS_CLK_ROCKCHIP_RK3528_H
> +
> +/* cru-clocks indices */
> +#define PLL_APLL 1

Start from 0. Just like your other - SCMI - list.

Best regards,
Krzysztof