From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 335C4CE837A for ; Tue, 1 Oct 2024 06:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SZZ9vGNAt5u/4C0MxsgZzleHQqz1x9Kb0YcmVd2T7II=; b=RUjl/rQXXeJxlxzI1ySG7UhouH 021r3RxpFSBtfUraw4PD4LUCgUQKWpeBq1eOFBb2IiivoH2DPHs7Jac3Hul7gWDVbWwdRHnUoYCA0 yoFRR1RDMbZn9LSsRMO6qwl7Z1T2UOLPAU7W0fzr0CKjwnzQh6FyfNkQ2UcTd96POuNQLfxsdMnV7 t0s9KzxtxJYYWUUCM5lThkcw0szR061F1xQOqStrZ1Wc71VjD7DsWD+7kuPPM/47hZWkGu66+u5+Q tesJ9mLYAWIS/75TsqKCzKiZqxQRWkLRe7J8WlD37GKIeoQZRsCXFixBRKOlUBSxxJ6sht9xnF2gU 5dk0AnRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svWYp-00000001mfH-0ziy; Tue, 01 Oct 2024 06:40:39 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svWXa-00000001mXy-47Pj for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 06:39:24 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-20b5affde14so21150025ad.3 for ; Mon, 30 Sep 2024 23:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727764762; x=1728369562; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SZZ9vGNAt5u/4C0MxsgZzleHQqz1x9Kb0YcmVd2T7II=; b=OiuGgD4CokAJe+LlpgVgRClxlrkCVL6CNamfd6aZruImxUaqkZwcO+OXjlU0nI9HcE igsFCWAyl21e07mKFvzVSPqXn0pmPg8TSk3BAnZVFI2KPzhTvZxYL8h9Fl9xcRE+Fvff RdICFbDtCQW4yJpf1fQWpxjoF2uj9IxiF/8AHWk8pwSaRJiu3AdYwf1NewnAg3GpNlAC kNiTnZNkA9Gc4YAGzatf3Wqnz01MAcgbQC7OFrQNpEGxv6C1xucshT5UQTSmA7A40rit Ezg11KJT/UMByV2aQ9Vnh1od8UuRC0YKPXrTb1xynCXhOGdA/iNnTUX2a5eyM8Mu+1N8 bYng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727764762; x=1728369562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SZZ9vGNAt5u/4C0MxsgZzleHQqz1x9Kb0YcmVd2T7II=; b=jYimbJnhCelK69EAOKvdJJAMjsodCbLhjGNyhHau64EFy8DWAZZqvAnDAFj0SVNwvC /pKswzL16B17KsUpYSFz2kTZp5Z23EQOzPRkhPyqS/kclYCvR2tdgx+GG/F2JgAXK1H0 SkvthqiXmOMFzDZcbUHiOjpoN17dpLIplWI9xv/0EwPIJDyguftTTnHxb3MoKNdasZiw d2eTnmVIe3X2LaqPBYYR13s88HtblZ4a3q6Jxpsmnd5WuLOXKCdOIv92iHqBbzCGodVN ZzH4hpcUvGHNBfQ1iiOHsdgpZLMabPIs0N27KLh25uO19S81tjIxRdqIU2xIzddxkzNg f7jQ== X-Forwarded-Encrypted: i=1; AJvYcCWN96jzwoj8y9YROd1D+ecIOo7j/PldZv+CHw2xhi/omYKkVTzmFkUTLA8eiGr+qbyPBnTE1yIhzszR6sUuGeFz@lists.infradead.org X-Gm-Message-State: AOJu0Yxclu6sGYgPeA3P5qQGd4Yr5q7q3gsj+2dDq1kBMlk68gu4QGBC LD6Cj5FOvjdThSC4tJgNtSk/d83Cm/bcTxIk4Ys4dX3IJnNkuvb7zIqecrO3W0U= X-Google-Smtp-Source: AGHT+IEOWqZzG8Ei19f42OBORnd3BwYUOQNDduKM+xXWWDwe/VJfk5IdBqLsuddvXismy7R+pVb62A== X-Received: by 2002:a17:903:2445:b0:20b:6624:70a7 with SMTP id d9443c01a7336-20b66247298mr134389545ad.21.1727764761891; Mon, 30 Sep 2024 23:39:21 -0700 (PDT) Received: from localhost ([122.172.83.237]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37e4d67esm63482095ad.229.2024.09.30.23.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 23:39:21 -0700 (PDT) Date: Tue, 1 Oct 2024 12:09:19 +0530 From: Viresh Kumar To: Mark Tseng Cc: "Rafael J . Wysocki" , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Matthias Brugger , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v1 1/2] PM / devfreq: mediatek: protect oop in critical session Message-ID: <20241001063919.ekqfd4epcefh5eci@vireshk-i7> References: <20240913103933.30895-1-chun-jen.tseng@mediatek.com> <20240913103933.30895-2-chun-jen.tseng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240913103933.30895-2-chun-jen.tseng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_233923_171312_AF3CEB17 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13-09-24, 18:39, Mark Tseng wrote: > mtk_ccifreq_target() & mtk_ccifreq_opp_notifier() is re-enter funtion > when cpufreq governor is more than one. It should add global mutex to > protect OPP , avoid get wrong frequency & voltage. I am not sure I understood the problem well. Can you explain clearly why the current locking doesn't work with details call chain ? -- viresh