From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E623DCEB2E8 for ; Tue, 1 Oct 2024 06:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MrlCI6gDMqjjvh07SpujHzw4G0hvOwNj3Og9A77/EN4=; b=TKt0cUj1X8m3sK5Vo2OECStWjl knwEzgLN+m69JVq1bEuXcw3smPS5qpDANQi1SEsWP+xUNKOXvqH/d8c0ooi+5zu+/S3FLf5pSxQ2S zExwCAthWjzOjf3EoK9BYPuwTd9ZkJcPWZTUGeLKn+KR+7y2gyZUw0J4e4iQXMs4GAw8KXdDChrCE jXgiaz4gbkaJsHE0vu5IpVH70i1ve9glOgcsSLcn7Btnrq9kprWgW9XCSqVKzTyRZwPU//8NygAkR fxLkiGBkFkWj8eE3kF7ODGXYw4gplONRj6qLeyYAEDKDt5+FX7Ztkb/y0dfdOCx5ozDutN6zGrM5r 4E0udy5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svWbD-00000001nAd-2Ii9; Tue, 01 Oct 2024 06:43:07 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svWZw-00000001mlc-3C6N for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 06:41:50 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-20b9b35c7c3so14440575ad.3 for ; Mon, 30 Sep 2024 23:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727764907; x=1728369707; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MrlCI6gDMqjjvh07SpujHzw4G0hvOwNj3Og9A77/EN4=; b=whAXJQ7VguZj/+ibAqc03dif+Tm6/2aTp7BM6NGNbAQh6t9zDPVHzKjNGRT5xRn+HF qr3IepxZTPEmhYJeC2jjMmlPIW2I5o65YqdVKeYaGJI/wspfkhXbyyYO7AqZELdbnYR5 vlCEKJmlph869FphLbYBVdlz6X/pwUpWcgtZvH7luOj2CpAl4D2bRkZf8/AoTSUtMrW/ NKSYQALFwTkbZegV5RSqdUu6RcJsd2pqcc64CGYg/15IvjiviUhGoV2ayGS2mg04E4rw HUXIQc9Yz6mtjiFNQynDnsIRHabtH6NUjkDgm1adwzz2IcN59j3fQ2bgOLq2O2GuYbF7 /GCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727764907; x=1728369707; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MrlCI6gDMqjjvh07SpujHzw4G0hvOwNj3Og9A77/EN4=; b=fQs3tqHF4Xu1v3bOf4S4OR/17Op0Rjt/SOV/QRJDnARRphZVuxBsu2f0BLRqXBOYpd P3Oh6k1KojvXGkGRc5HQkfexON8ciUxp4ELQs8ee9tER73ThRmMjF9tRPWTAmU5WIakz sb+vb760ppWGSXnDhyZKx0NtiYiCL4BoG254PwXCk05LvFIRWRwY6nVFZfZOJlZqrSEd 41BeaF+5Hd0Wdg+35mCrC1o+v0RPn4B3G+vzYYVsfbN4b30wgi8MotowYKbgFIMLYBpx vCIHOA15LU7QZ5jG0cKodqgQFX/jSZuOihkAY4B8mJJFwZgnfzzteIK37eNnTS3eA2yO J4rQ== X-Forwarded-Encrypted: i=1; AJvYcCXERiRZkMZBlQ2U/vtQjI99JCpeQvLGpB5nvX5T+LMqkKSNZt0W3WKpq5K9208YVoGPWcbuY6kt7N34OlDl7pj+@lists.infradead.org X-Gm-Message-State: AOJu0Yxc9HW/em7EvNe37hu0YWmyDNmD0bGdd/Gga2Xm7twxDmjIkYNG nV7nqaBdq8aFN0CdqkKWyUwW56LrLoMIlamm+TS0janW1L0oYP4TjCjiUSJdn98= X-Google-Smtp-Source: AGHT+IFP3u0mkHLILfVEb/4G2eiUN2Rl9g69lxh2r/A1UnM0/qF+U9h+WXBSTr/0YXwcXLpcsRJ+KA== X-Received: by 2002:a17:902:e80a:b0:20b:58f2:e1a0 with SMTP id d9443c01a7336-20b58f2e394mr152709015ad.18.1727764907712; Mon, 30 Sep 2024 23:41:47 -0700 (PDT) Received: from localhost ([122.172.83.237]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37daf85dsm63772875ad.113.2024.09.30.23.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 23:41:47 -0700 (PDT) Date: Tue, 1 Oct 2024 12:11:45 +0530 From: Viresh Kumar To: Mark Tseng Cc: "Rafael J . Wysocki" , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Matthias Brugger , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v1 1/2] PM / devfreq: mediatek: protect oop in critical session Message-ID: <20241001064145.fnnzcsrewz6pttoe@vireshk-i7> References: <20240913103933.30895-1-chun-jen.tseng@mediatek.com> <20240913103933.30895-2-chun-jen.tseng@mediatek.com> <20241001063919.ekqfd4epcefh5eci@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001063919.ekqfd4epcefh5eci@vireshk-i7> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_234148_813278_E79968B0 X-CRM114-Status: GOOD ( 13.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01-10-24, 12:09, Viresh Kumar wrote: > On 13-09-24, 18:39, Mark Tseng wrote: > > mtk_ccifreq_target() & mtk_ccifreq_opp_notifier() is re-enter funtion > > when cpufreq governor is more than one. It should add global mutex to > > protect OPP , avoid get wrong frequency & voltage. > > I am not sure I understood the problem well. Can you explain clearly > why the current locking doesn't work with details call chain ? Ended up replying to the wrong email. This comment is for patch 2/2. -- viresh