From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3438CF3185 for ; Tue, 1 Oct 2024 21:03:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MWtD++Hnl4oGFYNk31Vwvfy9zu72nUBaUAs7MD+0Pqg=; b=x4nlDl8v1MOpAcY2niWYafi2p8 vYhZ8WdXE3jWzBHTz5iji7b9H4qY+YImbOhVMwoIt5PmnSM7F0mHdUhwl/gBvAIhK3KN3M3S9ab6o tHaNSCR9mc046juuJRFRz6gALgKwj2J+Umim+HHJ91AUZoqhIAirhYJ03D+iX3LKB/ETPofEgbviJ Wu7E/w5eKC9jk7pxBXGRa43MfgMV9bh1PzecVlpUWYkjtKFDYlP7S1S7oE07GOc45DUdkB9Cfn1wU N1zsERve6gbz/P/3+NvY8SrLIE4CIdFJYbjgpbyUGdyZgMLnBOS5Ze6p/5kC+cxZwTcHf0Ax14tq2 atGJZtxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svk1f-000000044dw-0QAU; Tue, 01 Oct 2024 21:03:19 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svk0R-000000044YP-1Qeq for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 21:02:04 +0000 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-7a9a3e731f9so528539885a.0 for ; Tue, 01 Oct 2024 14:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1727816522; x=1728421322; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MWtD++Hnl4oGFYNk31Vwvfy9zu72nUBaUAs7MD+0Pqg=; b=j2vn8YnRhoybHKTIWZGb+c936sF+D9kdHhzD6HVw6u1tQSfHTXvLk5Xop2l43F+c9O aFfetw8RR9dLJ56eOyJp4TaqKXfAcDjSJvrKWLtDKz93pjS3prYIjDaK0eEtswVy9vXE Os4y0zAARSstqV/2fV2T60uZd0ZYUPIu4WwIufzCtXBejBZuoTU6YMw6WJmL5Broaiwg YkHvS7XsZpwEsBlfFpkFUiue9nDTo+SmZdpMxyvxF/YPSI445yYvkfKllN/P1obyMVi3 6ZUiHqbScA4WWYOfQ7RddqSnarRsFpYVE86jiF8VOSHeRtcmuHFNTQ4eG4zSPJwLHueK rePQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727816522; x=1728421322; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MWtD++Hnl4oGFYNk31Vwvfy9zu72nUBaUAs7MD+0Pqg=; b=asaSvNZR/tMddVUTlwWhw6n4IbIXfcx6CI5x52qSRZO9zpolBxxaVNzqvBvHC5VDgJ qcfK4jzCCZV1rKNWtxJn73ahiWN8PkEb9iD8f7K5ZSngA1s5mQeTVudO7lPwuW1qTLqO clTdBxtBTtb6iUGOQelRDYsuHi9HRVM0hOD/Hkk0m7OacYymQ8iZ9B2oVrbyPhbdyNSO wS18sqFLCT8mn3l0N30PM1AMgYmqER6DrJQQHTmJ42/z+SvOH0X9zf7qdKjHrDZhRYRF ieY/D3CpWQ1wBRJ2NPAh2uAVgImyJumxCk1WW50vskbdWkqqzn/OWOssTsCO474xhU3s oWRQ== X-Forwarded-Encrypted: i=1; AJvYcCUuiEJRNJddmkNWUksrH/a6azZfzHhY4tx+ueCzxqxrG5siEjSxwrP/3ERoJ7jUg3FxGlI3jz93JTOBEWobnq7Z@lists.infradead.org X-Gm-Message-State: AOJu0YxwHUxvHnYUBKAkERHb7256Ezpdb9ZIwjnsanrTXGkiHFnbXJec wV06PzMzYsH4dPihW4d+jBcorLvQY0qn4JuY1URax/dTXEuLEcBIReGiv8YkwRA= X-Google-Smtp-Source: AGHT+IHULfn5lXM4Kjk4P8yRcei24tL5q2e5nIBdHiXVRWfw/1DTCaErYYyTzss+FTMmxlmSF+uhOg== X-Received: by 2002:a05:620a:191d:b0:7ac:de4c:f6e6 with SMTP id af79cd13be357-7ae626d9090mr148956185a.33.1727816521943; Tue, 01 Oct 2024 14:02:01 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae3782c614sm542104985a.76.2024.10.01.14.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 14:02:01 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1svk0O-008A4U-Ma; Tue, 01 Oct 2024 18:02:00 -0300 Date: Tue, 1 Oct 2024 18:02:00 -0300 From: Jason Gunthorpe To: Yang Shi Cc: Nicolin Chen , will@kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for AmpereOne Message-ID: <20241001210200.GC1369530@ziepe.ca> References: <20241001180346.1485194-1-yang@os.amperecomputing.com> <45b97496-29a2-4111-ba38-3c8bcf9f8b4d@os.amperecomputing.com> <20241001191800.GA1369530@ziepe.ca> <0e84f3c0-09d6-4485-ac76-ca296d1ee07e@os.amperecomputing.com> <20241001194620.GB1369530@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_140203_402785_DB646C3D X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 01, 2024 at 01:47:24PM -0700, Yang Shi wrote: > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > index 1e9952ca989f..de9f14293485 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > @@ -235,6 +235,11 @@ static inline u32 arm_smmu_strtab_l2_idx(u32 sid) > return sid % STRTAB_NUM_L2_STES; > } > > +static inline unsigned int arm_smmu_strtab_max_sid(unsigned int sid_bits) > +{ Can we take the smmu struct here instead of the int? But yes, this looks OK Jason