From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3198CCF31B0 for ; Wed, 2 Oct 2024 10:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pYaa3U+Z3FT24yI/8gBzN5pJs2DVWha8P7LuEBioff4=; b=KLO2yg5Br1Rf3qQz0d68PwIepN emLBJyHHwRjFiHBB7RfHs1DLVnCusnJOLhifigBwT/Db+aUDiCXN5+074itRZvtTH21YcnZFTDkff +PO/hQBYv1yBLifYwYKgLr8aI2qp7U2TsgGl8oRAQAVQqy1jDzVUEgbEkrNwxVJrulH9qs/531MQ0 gLf5PafnvEL76VooaTS4qmsKToFIf6Ta4YD5ZpsYwgRZdJPdcjpz96v0Puh5BQdps4QWfC4/JCgqs pAeKzO2n8E0AbQCGVCvbs/pbtcRWvd7pL5gL1CQHkbJFcqzBuD5sDrFUYC00IrO1y05cnX6dABGC7 cpYcYMvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svwpP-00000005X6m-3uuE; Wed, 02 Oct 2024 10:43:32 +0000 Received: from mail.thorsis.com ([2003:a:e28:26e4::10]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svwo9-00000005WmX-0zR0 for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 10:42:14 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 17BAA148629F; Wed, 2 Oct 2024 12:42:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1727865727; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=pYaa3U+Z3FT24yI/8gBzN5pJs2DVWha8P7LuEBioff4=; b=R/dy0WlBIJPNhxvjnM5PHRsbvqjG1qjnKkNmcFjkNAnDBTOVHLeX8ITqyLf6nK9hiSf4UX W80KyeDMaFIhE0f9SbBJMrQhsIOtvHtqAKtw8v81j1aK1YIzTnZAiBRPeI3SEFbQSPapFF SnQgaeb+IRfpW2kqdyTLqvJaieEuauGnS+8gA0UWyeR6z+w9h3PnbhvR6yxb7x9DmgJ41+ HpEXk3nefO1WvIFCwGQpC/Epg+13lGBM7IHmP5WUqAxiqN5jMjqgx0cDuyQa/k2x8zWkTn cp45udk1OBF4ZVW9atit40dIRkqoifLOxsBtrsU4wgtwuj/yd5ow0YhsRyFJXw== Date: Wed, 2 Oct 2024 12:42:04 +0200 From: Alexander Dahl To: Andrei Simion Subject: Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes Message-ID: <20241002-scoured-deuce-5c4729a1a2aa@thorsis.com> Mail-Followup-To: Andrei Simion , conor@kernel.org, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, conor+dt@kernel.org, devicetree@vger.kernel.org, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com, robh@kernel.org References: <20241001-sleet-bronchial-867258945373@spud> <20241002103044.108413-1-andrei.simion@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241002103044.108413-1-andrei.simion@microchip.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_034213_462020_BD031655 X-CRM114-Status: GOOD ( 20.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, robh@kernel.org, ada@thorsis.com, claudiu.beznea@tuxon.dev, conor@kernel.org, linux-kernel@vger.kernel.org, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Andrei, Am Wed, Oct 02, 2024 at 01:30:45PM +0300 schrieb Andrei Simion: > > On Tue, Oct 01, 2024 at 06:25:41PM +0300, Andrei Simion wrote: > >> Add the label property here and use the old node name as value to stay > >> stable and avoid breaking the userspace applications that depend on those > >> paths. > >> > >> Suggested-by: Alexander Dhal > >> Signed-off-by: Andrei Simion > > Shouldn't this be squashed with 3/4 so as not to break it in one commit, > > only to fix it in another? > > > > Hi, > > My intent here was to give credits. Appreciate this. And just noticed you got my last name wrong. ;-) Credit is recorded in this thread now, this is sufficient. > If this approach is unnecessary, I will do squash in V3. Conor is right here. Please squash. Greets Alex > > Best Regards, > Andrei Simion > > >> --- > >> v1 -> v2: > >> - added in v2 by suggestion of Alexander Dhal > >> --- > >> arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts > >> index 0c3373ad1723..b65f80e1ef05 100644 > >> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts > >> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts > >> @@ -99,22 +99,26 @@ leds { > >> compatible = "gpio-leds"; > >> > >> led-red { > >> + label = "red"; > >> gpios = <&pioC 10 GPIO_ACTIVE_HIGH>; > >> linux,default-trigger = "none"; > >> }; > >> > >> led-green { > >> + label = "green"; > >> gpios = <&pioA 5 GPIO_ACTIVE_LOW>; > >> linux,default-trigger = "none"; > >> default-state = "on"; > >> }; > >> > >> led-yellow { > >> + label = "yellow"; > >> gpios = <&pioB 20 GPIO_ACTIVE_LOW>; > >> linux,default-trigger = "none"; > >> }; > >> > >> led-blue { > >> + label = "blue"; > >> gpios = <&pioB 21 GPIO_ACTIVE_LOW>; > >> linux,default-trigger = "none"; > >> }; > >> -- > >> 2.34.1 >