From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4997CF319D for ; Wed, 2 Oct 2024 07:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BsRYr69Y6c30rtCLdqrWt7qfyJtEqWZprckrz9iVtrk=; b=RWKF1QYjlu8ptROvwuC5It55mR zcMgACmKQlqmZZDwmDZbZDmoMWEkaUFz0n6MEKIxUMMoRW3ZA/0PmOkv75ECJmCKDsip2hO2lPx/Z oT6K3/LKqBG/j8d0EVQbXBg9DYPJboyRaoqq9HdYcEyWftU1HMHUnS2TbE+owOuHsURnbG51UWSfz B1l1SJOsWygRxM14qilwoteLR+DkDc7VcbEhdc0IV7XtbbA0MepuqPw5zqoqZj4ofXwWsfz0dYVmk aibZkyRG3IeRsbOKq9PX0mMbWbnTvvNOa0AmTcpaUYxDiRVNHI2sNh51L6o9gUa52WkPN6cutZVxB wyuEurBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svu8P-000000054g4-2WQE; Wed, 02 Oct 2024 07:50:57 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svu5u-0000000549g-0vxw for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 07:48:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1727855301; x=1759391301; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yjQbS4juwZPhWck9Qu/CXpBh5RJpxCF34+6/JYPUVGs=; b=EFYRpysJKIDH7FypstmfQwWdSOBE526W0x2sFbvEO5jVsj4o09n2USrm Kc2IBryHBN3m8HzaA1lit4AXNHXqEAeBh+yPXOZP7NrtUPq/IrQeSe/ci 23egzcvp1iuyoG6KTEWKi2CY9UOF+ocWg6yvZV+CBrs0iQT4ooj955l9M 8cB0jn2ppzU6+LKG439rqwJSFMKuy6yD55R7HHRcMHRJ6A4l6BUXhrS8Y OYUF+jJQzl9ogHeM+ZSCfI2POBGMdnPReaWvxfZxeUsXPp7EbStlP4j6V XLpZu2cAnkGwx9y/Gvp28kORcX0ZEhZCT86LP5PyUcxlvblTHphD6UOOB g==; X-CSE-ConnectionGUID: ur9xYuViQOazsezB14XXWQ== X-CSE-MsgGUID: F2F+WxPPTHC7dIcE4idn5Q== X-IronPort-AV: E=Sophos;i="6.11,171,1725346800"; d="scan'208";a="199937223" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Oct 2024 00:48:20 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 2 Oct 2024 00:48:08 -0700 Received: from DEN-DL-M70577 (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Wed, 2 Oct 2024 00:48:05 -0700 Date: Wed, 2 Oct 2024 07:48:05 +0000 From: Daniel Machon To: Jacob Keller CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , "Steen Hegelund" , , , , Richard Cochran , , , , , , , Subject: Re: [PATCH net-next 10/15] net: sparx5: ops out chip port to device index/bit functions Message-ID: <20241002074805.fcacici2omuimcgd@DEN-DL-M70577> References: <20241001-b4-sparx5-lan969x-switch-driver-v1-0-8c6896fdce66@microchip.com> <20241001-b4-sparx5-lan969x-switch-driver-v1-10-8c6896fdce66@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_004822_347549_360C847A X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > The chip port device index and mode bit can be obtained using the port > > number. However the mapping of port number to chip device index and > > mode bit differs on Sparx5 and lan969x. Therefore ops out the function. > > > > Signed-off-by: Daniel Machon > > Reviewed-by: Steen Hegelund > > --- > > drivers/net/ethernet/microchip/sparx5/sparx5_main.c | 2 ++ > > drivers/net/ethernet/microchip/sparx5/sparx5_main.h | 2 ++ > > drivers/net/ethernet/microchip/sparx5/sparx5_port.c | 4 +++- > > drivers/net/ethernet/microchip/sparx5/sparx5_port.h | 7 ++++++- > > 4 files changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c > > index 8b1033c49cfe..8617fc3983cc 100644 > > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c > > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c > > @@ -982,6 +982,8 @@ static const struct sparx5_ops sparx5_ops = { > > .is_port_5g = &sparx5_port_is_5g, > > .is_port_10g = &sparx5_port_is_10g, > > .is_port_25g = &sparx5_port_is_25g, > > + .get_port_dev_index = &sparx5_port_dev_mapping, > > + .get_port_dev_bit = &sparx5_port_dev_mapping, > > So for sparx5, these are identical operations, but for lan969x these > will be different? Ok. > Exactly :-) /Daniel