From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86EE5CF3189 for ; Wed, 2 Oct 2024 00:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sNvuLW8etY7kfVFMZnPVs6iTJ6n551p27c5+oQYEJ1s=; b=YK/o5fa2A04b4Yf5JQbcM7b2Dv 6p3fpAJ5grcgSrK/JBkgoJTrWg0rmh3TK72TXc/Op8GYAC3OLTMQi8O3j6t2Nx4tYzoLwclbomBUN UhOlkwvE8KFB11OstjUAkLkwqOVz5CeKtcoSLOmPv+Stbd24fSFWR3T+pmZ1mvskfKSEQsn1XKtnG Fsl0rg5I20dv+WyWKQBSKixwiJWClwVdTSJOxZq45TTrXPZRcIhOLL3nAJf3zCeZkDlHVgSWeKbf2 hZUB0p5OENgYX4qQ8xB7H9GNwpIuQqxa/tRQX8WtcgCfv4xQK93uFUt8DZD/cewDj9EmmksE+mOQq 0y0iflnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svn1l-00000004RXH-21lR; Wed, 02 Oct 2024 00:15:37 +0000 Received: from mgamail.intel.com ([198.175.65.16]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svn0W-00000004RR0-1tPY for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 00:14:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727828060; x=1759364060; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=v9C6ilDiJg0A0ytpHCTqTr0C3nnG5RgBkwEzFypgyZg=; b=XlGIOnO52s0vYvyEkbH9J/rcFtugFtcbbRIS99a6q3Ql16WSsUQa59QM 5+5iTpFwuba/3Uq5n6IOIMzyWwZBE6oNzGRQO3jf+JOGd/BtYe9wvJd4X JO/8YDMsEY0feFV+3zcMxv7u7IU1QXsiHUkYo62Gcl6mjSwZg7uw1VqA6 B5lfnVydiQufhhi0ch2w9CUz9EHlVFPAvrup8Po1t7x2hMoyrUWP4gjYS 6X2QGLc+Iy43uuPe3AET9zun/oR7yjWsAvZIpOeVY6QzzYS+pq97ZSCTF G2h9mc3U3Eihf1O5ijrFgMJjqwwgx7eC14nqq6piNYxsl+kQBouD9kkiS Q==; X-CSE-ConnectionGUID: 9+pB4ZNYTlmpPHOxAI/Dog== X-CSE-MsgGUID: d0xdNN1hQRa7Z+VcUlHQpQ== X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="27080708" X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="27080708" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 17:14:19 -0700 X-CSE-ConnectionGUID: 7UNkonJCRau/To8i+iMeHA== X-CSE-MsgGUID: HV1l8ql8RUWkOv1auV4sDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="78816944" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by orviesa004.jf.intel.com with ESMTP; 01 Oct 2024 17:14:16 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1svn0P-000RLV-1R; Wed, 02 Oct 2024 00:14:13 +0000 Date: Wed, 2 Oct 2024 08:14:00 +0800 From: kernel test robot To: Pratyush Brahma , will@kernel.org Cc: oe-kbuild-all@lists.linux.dev, robin.murphy@arm.com, joro@8bytes.org, jgg@ziepe.ca, jsnitsel@redhat.com, robdclark@chromium.org, quic_c_gdjako@quicinc.com, dmitry.baryshkov@linaro.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Pratyush Brahma , Prakash Gupta Subject: Re: [PATCH] iommu/arm-smmu: Defer probe of clients after smmu device bound Message-ID: <202410020820.gY0d4AkK-lkp@intel.com> References: <20241001055633.21062-1-quic_pbrahma@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001055633.21062-1-quic_pbrahma@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_171420_572157_86B5C4BA X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pratyush, kernel test robot noticed the following build warnings: [auto build test WARNING on soc/for-next] [also build test WARNING on linus/master v6.12-rc1 next-20241001] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Pratyush-Brahma/iommu-arm-smmu-Defer-probe-of-clients-after-smmu-device-bound/20241001-135852 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next patch link: https://lore.kernel.org/r/20241001055633.21062-1-quic_pbrahma%40quicinc.com patch subject: [PATCH] iommu/arm-smmu: Defer probe of clients after smmu device bound config: i386-buildonly-randconfig-004-20241002 (https://download.01.org/0day-ci/archive/20241002/202410020820.gY0d4AkK-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241002/202410020820.gY0d4AkK-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410020820.gY0d4AkK-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/iommu/arm/arm-smmu/arm-smmu.c: In function 'arm_smmu_probe_device': >> drivers/iommu/arm/arm-smmu/arm-smmu.c:1441:32: warning: returning 'int' from a function with return type 'struct iommu_device *' makes pointer from integer without a cast [-Wint-conversion] 1441 | return dev_err_probe(dev, -EPROBE_DEFER, "smmu dev has not bound yet\n"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +1441 drivers/iommu/arm/arm-smmu/arm-smmu.c 1419 1420 static struct iommu_device *arm_smmu_probe_device(struct device *dev) 1421 { 1422 struct arm_smmu_device *smmu = NULL; 1423 struct arm_smmu_master_cfg *cfg; 1424 struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); 1425 int i, ret; 1426 1427 if (using_legacy_binding) { 1428 ret = arm_smmu_register_legacy_master(dev, &smmu); 1429 1430 /* 1431 * If dev->iommu_fwspec is initally NULL, arm_smmu_register_legacy_master() 1432 * will allocate/initialise a new one. Thus we need to update fwspec for 1433 * later use. 1434 */ 1435 fwspec = dev_iommu_fwspec_get(dev); 1436 if (ret) 1437 goto out_free; 1438 } else { 1439 smmu = arm_smmu_get_by_fwnode(fwspec->iommu_fwnode); 1440 if (!smmu) > 1441 return dev_err_probe(dev, -EPROBE_DEFER, "smmu dev has not bound yet\n"); 1442 } 1443 1444 ret = -EINVAL; 1445 for (i = 0; i < fwspec->num_ids; i++) { 1446 u16 sid = FIELD_GET(ARM_SMMU_SMR_ID, fwspec->ids[i]); 1447 u16 mask = FIELD_GET(ARM_SMMU_SMR_MASK, fwspec->ids[i]); 1448 1449 if (sid & ~smmu->streamid_mask) { 1450 dev_err(dev, "stream ID 0x%x out of range for SMMU (0x%x)\n", 1451 sid, smmu->streamid_mask); 1452 goto out_free; 1453 } 1454 if (mask & ~smmu->smr_mask_mask) { 1455 dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n", 1456 mask, smmu->smr_mask_mask); 1457 goto out_free; 1458 } 1459 } 1460 1461 ret = -ENOMEM; 1462 cfg = kzalloc(offsetof(struct arm_smmu_master_cfg, smendx[i]), 1463 GFP_KERNEL); 1464 if (!cfg) 1465 goto out_free; 1466 1467 cfg->smmu = smmu; 1468 dev_iommu_priv_set(dev, cfg); 1469 while (i--) 1470 cfg->smendx[i] = INVALID_SMENDX; 1471 1472 ret = arm_smmu_rpm_get(smmu); 1473 if (ret < 0) 1474 goto out_cfg_free; 1475 1476 ret = arm_smmu_master_alloc_smes(dev); 1477 arm_smmu_rpm_put(smmu); 1478 1479 if (ret) 1480 goto out_cfg_free; 1481 1482 device_link_add(dev, smmu->dev, 1483 DL_FLAG_PM_RUNTIME | DL_FLAG_AUTOREMOVE_SUPPLIER); 1484 1485 return &smmu->iommu; 1486 1487 out_cfg_free: 1488 kfree(cfg); 1489 out_free: 1490 iommu_fwspec_free(dev); 1491 return ERR_PTR(ret); 1492 } 1493 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki