From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F6FCCF31B1 for ; Wed, 2 Oct 2024 10:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gVVVrloPOO94UOJZqrvUIKEyNdWyBfABXbFpW6zWF+0=; b=urvHr9F4NLCP+aiN//ZsEEOUQI yqxtrwZFQCYp46lEmGFkk0M85XAgEBFzu4tRIPWpmxHqc2c0FP3Er82QjhX6+epoUmddnX8EcaPSX X9LgQv/5w3ED6bdfMF0PpR13LJTd1cNLVlHy4knE3XT6Guh29DhQPFx+U7Hc8EpZ6AqUnODJngbGE 1/ZINTfUGUL2KCPAdY5WTeNZ3nY2IqT6vyKJkQ9mva6NclTfLC43UKKLf9jo0AYIsDRTe9nsAch2e aWI7nNEKNnvxbe8S6c/LqdVq6JYSKdBOqRMiSuIm0cL8ILPSBBLSHtv0RACwPjvetTqZ3gwdWrIKd eKOQ27Kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svwiY-00000005Vws-0SIc; Wed, 02 Oct 2024 10:36:26 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svwe7-00000005V8I-3I6Z for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 10:31:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1727865111; x=1759401111; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BZQu3MKWVvMacvUKcyQlysIUATw80nYaO8kh3HRXFwg=; b=sJ1dLj59TMBWCCd0r/rjx1XM2AsjcrvIT6Y/9kgAr6Rj3KaS3tCxyW1D r929+328ccG7daIkOUdutwEzsC6wD3vICG46HGXvF87q1dSYKWoylw8mK Qph0YLVgIc2MkQMKqjbJlR7oCyzoxZuvpHfz+4ve+X9R8qphiw2/FF4L0 5E7dNs5WM9qmbBOr2eau1t/t9j07wKS6mh1JJuJiD7u+7+S+vJU9tshth o8wDFcJKsT4eAg3bmGPw/fyMKnQ8wucIWmLw0DH6XaBzdFF/dVZw9XI9O UIOozveCeUQWLnWe3DpQhH7EvPdlnsA+nniwsH+hXysrzbuDAF0SO7C53 w==; X-CSE-ConnectionGUID: TfueWziQTJ+RLI4R25HrfQ== X-CSE-MsgGUID: KtQmdZ+2Q6KLbvDjR+u5mw== X-IronPort-AV: E=Sophos;i="6.11,171,1725346800"; d="scan'208";a="35785390" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Oct 2024 03:31:48 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 2 Oct 2024 03:31:08 -0700 Received: from ROB-ULT-M76677.microchip.com (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Wed, 2 Oct 2024 03:31:06 -0700 From: Andrei Simion To: Subject: Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes Date: Wed, 2 Oct 2024 13:30:45 +0300 Message-ID: <20241002103044.108413-1-andrei.simion@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241001-sleet-bronchial-867258945373@spud> References: <20241001-sleet-bronchial-867258945373@spud> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_033152_032810_C29F62E9 X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, robh@kernel.org, ada@thorsis.com, claudiu.beznea@tuxon.dev, linux-kernel@vger.kernel.org, andrei.simion@microchip.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Tue, Oct 01, 2024 at 06:25:41PM +0300, Andrei Simion wrote: >> Add the label property here and use the old node name as value to stay >> stable and avoid breaking the userspace applications that depend on those >> paths. >> >> Suggested-by: Alexander Dhal >> Signed-off-by: Andrei Simion > Shouldn't this be squashed with 3/4 so as not to break it in one commit, > only to fix it in another? > Hi, My intent here was to give credits. If this approach is unnecessary, I will do squash in V3. Best Regards, Andrei Simion >> --- >> v1 -> v2: >> - added in v2 by suggestion of Alexander Dhal >> --- >> arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts >> index 0c3373ad1723..b65f80e1ef05 100644 >> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts >> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts >> @@ -99,22 +99,26 @@ leds { >> compatible = "gpio-leds"; >> >> led-red { >> + label = "red"; >> gpios = <&pioC 10 GPIO_ACTIVE_HIGH>; >> linux,default-trigger = "none"; >> }; >> >> led-green { >> + label = "green"; >> gpios = <&pioA 5 GPIO_ACTIVE_LOW>; >> linux,default-trigger = "none"; >> default-state = "on"; >> }; >> >> led-yellow { >> + label = "yellow"; >> gpios = <&pioB 20 GPIO_ACTIVE_LOW>; >> linux,default-trigger = "none"; >> }; >> >> led-blue { >> + label = "blue"; >> gpios = <&pioB 21 GPIO_ACTIVE_LOW>; >> linux,default-trigger = "none"; >> }; >> -- >> 2.34.1