From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C65BCEACF3 for ; Wed, 2 Oct 2024 18:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7isLwNgAFftRQNI2d6VEiKpImMXN1qIZBDVetXlWrhE=; b=p3YT04m5KiVGAydedQsPqBk0dI h/vjqvIFxLFdKtwtbbqouw9EyvaFZaw4k70kdWEbA5r7Q+p8XA6doHZ2CMsMRVo9kMVsXPvabaaME hXrZFMc0384fEOZbMzy02Adn407P57N4jHtcLd3r7dEY+WEbmvhS4b+6RjweCfk4GlTXmHH+r3rv9 UXnxNO99GjjT+foJtgoH55lK5QObYzzI0yG6EphhRwMgSO1xkDCuGHeZTwDmZl2uqBMKQqRdF5DL6 hW8OJ00SRCuzeVWJw6pWKUDIi5fxWlD2jom9HZRr+X6oRBKWJVAn/h2mtoq8Te7rniS9r+6QeGQQz 8mETcpBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sw3tb-000000078cq-0HzG; Wed, 02 Oct 2024 18:16:19 +0000 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sw3sL-000000078U9-0n25 for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 18:15:03 +0000 Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-6cb2cba60e1so1009226d6.3 for ; Wed, 02 Oct 2024 11:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1727892899; x=1728497699; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7isLwNgAFftRQNI2d6VEiKpImMXN1qIZBDVetXlWrhE=; b=XLey4rebRS5otXWPqAmy/PwNxYPK9JgDNKnwyxx6tXGfgvw6wx/HZZ+eZAh+bh1zy9 lTT31XzkS9hS9yljF7+0xnD+CV0aD2zqLiT1TfzejBzW4JUVDMG0axY+aM4luwd2KBrp CtEvrIWtFSwAspbAH4AnLlHkvnwiwcLaiZx0DpoLXiB9O+M8D2hThfUuH5SP7lYOczzC ZcF1FioAXJWp64XcfXXVW5GczCID9JsE9eGOGmmtfpYfJKy3ncyozBKaBiRszI3vqgbE 8/R/J4aySEOKBH8yi7JPyudBIK3iaBcOZMXxKiJCLha3uapPwrrfLs353xJGQQktDEpl /Ycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727892899; x=1728497699; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7isLwNgAFftRQNI2d6VEiKpImMXN1qIZBDVetXlWrhE=; b=kFdDCAZY0DPmTwbeqetkwbkz9TEd/8w+2wRQsLB2x7J7eFB7aC24GN1Mvi2a78tOlS 5T2T3PhurE1wslKsndcqS+DaNkTCSvbg9193MBSdBWIJFEkylUX6rI3HQRYbbzRLVSbI rHykdYROfowKw2mqAUMvnQNhzcI8YJ+4Iex2E7nrBXkB11aT3UYpdXtQ0yEXqKERFARI vM2BPpnymKrFvrreetFFEBBCbPuhGDJkQYMiciFR4OLZ/Whx6jbgzaWLVcomelMsua8o EhwExTisX3l2UaRfwaXfa/LrZsLyqImOeJPhFmby+YqGSCu2gN7zjFslVn1dqsNMTY1k 4iWQ== X-Forwarded-Encrypted: i=1; AJvYcCVcuELsFSEiSE5AnALhKDFwHvP92KnZYL9NBINPWTEhBto/FCpTZGiTqNca/kCyNPwI5ti+aUvxoj9aXGZPfSE+@lists.infradead.org X-Gm-Message-State: AOJu0Yy/QV+iX3addYNPXV1FH6WhR/lDgaXbuUad5dF1PkRBn0VQkc8X 4h6b/HrmuDzieNtMyWUVb0/YqIYozbqKJka/fQFdYjpcb8gu11PrcM2qzA1ZqM8= X-Google-Smtp-Source: AGHT+IHUWegeu0iNaiqwi4NU7iIsOUUtFs2eDwht+TlsMdZFGYB/poFQ/SkzzMeLG7BamxI8CD6DlA== X-Received: by 2002:a0c:e789:0:b0:6cb:904c:478d with SMTP id 6a1803df08f44-6cb904c4f92mr4962396d6.16.1727892899641; Wed, 02 Oct 2024 11:14:59 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b67f247sm63007516d6.107.2024.10.02.11.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 11:14:59 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1sw3sI-00A6kq-O6; Wed, 02 Oct 2024 15:14:58 -0300 Date: Wed, 2 Oct 2024 15:14:58 -0300 From: Jason Gunthorpe To: Yang Shi Cc: nicolinc@nvidia.com, james.morse@arm.com, will@kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size Message-ID: <20241002181458.GK1369530@ziepe.ca> References: <20241002175514.1165299-1-yang@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241002175514.1165299-1-yang@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_111501_335227_908A8D4A X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 02, 2024 at 10:55:14AM -0700, Yang Shi wrote: > Using 64 bit immediate when doing shift can solve the problem. The > disassembly after the fix looks like: > ldr w20, [x19, 828] //, smmu_7(D)->sid_bits > mov x0, 1 > lsl x0, x0, x20 > > There are a couple of problematic places, extracted the shift into a helper. > > [1] https://lore.kernel.org/lkml/d4b53bbb-333a-45b9-9eb0-23ddd0820a14@arm.com/ > Fixes: ce410410f1a7 ("iommu/arm-smmu-v3: Add arm_smmu_strtab_l1/2_idx()") > Tested-by: James Morse > Signed-off-by: Yang Shi > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 8 +++++--- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 5 +++++ > 2 files changed, 10 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason