From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2271FCF34DA for ; Fri, 4 Oct 2024 00:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PGkmdzVif0m3ciZErJ9gXmRwVnTLrOTt5p5ptpSpun0=; b=U2sCubhZ18UOv9sfCT+zR/M0Mw 8gD2qtqbcT/ZbTlSUVDak4KSeGNU562p2Z+TZA48TSKgadCLWLynx/Zp8JPBVfA+FNQJsSfsw6iv8 oVGNjGUs6x83kH0y+VT4TsiN4CkLXc2bewWVxc6mkALsv/AamYWKCrCJR+0eXT7brvU6cJwr0oPQg mkCOzCs9qcn3X/nm3VrF+MCv8tGsOJ061OrtLST4F352i26NC4wFOOrixR5tk91Lf6bRN2N70si4V TKr/xuAstHV8UqWOS8cTHPIqEYpZOeCINavk/25ks7UZYoQaHC52jo7YNNDxLk6oH+XsBtSA9Esmt nJaxUwGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swWPP-0000000Al7C-0x9s; Fri, 04 Oct 2024 00:43:03 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swWO9-0000000Akrv-1Chi for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 00:41:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 228BB5C5CB1; Fri, 4 Oct 2024 00:41:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50EE1C4CEC5; Fri, 4 Oct 2024 00:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728002504; bh=Pj7/4JkZKTEjFnWPuyqp8I9QcPbg+NwjUmF6x3+YM0c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JiXv+n1DEbkU8Z50yZLhQtEtgdr/jj7N+8a2xfWp2jaeiVZ2480PT/vvAt7hGU2j2 4w9UeeaXT6dJ5iPrJQGSELnAFdg3YJGt9AfGom6y0Qi4gujs/AlGIwvUSa7Z0TB027 a9+JsYlHhdKTNqv241tqJ9rCUrG1itLI1S3IJ+h7dREIy2jR6Jao2NA3agEzK9bZ6R 4TUEkWNuunTHXcSqZiyEn1sXF2nULPkeGOAKtzcEDfBupQ4IDbAG78lkzONbnsJehf e3LYa3xI+/dF7V53LbRK2DFyxAslOR73C+SClsJMw5u3c9Qrv2Cibch4ae+Kk+EOOk KpkFJOU7A3xCQ== Date: Thu, 3 Oct 2024 17:41:42 -0700 From: Jakub Kicinski To: MD Danish Anwar Cc: , , , , , , , , , , , , Vignesh Raghavendra , Roger Quadros Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix race condition for VLAN table access Message-ID: <20241003174142.384e51ad@kernel.org> In-Reply-To: <20241003105940.533921-1-danishanwar@ti.com> References: <20241003105940.533921-1-danishanwar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241003_174145_403002_F87083CB X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 3 Oct 2024 16:29:40 +0530 MD Danish Anwar wrote: > diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h > index bba6da2e6bd8..9a33e9ed2976 100644 > --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h > +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h > @@ -296,6 +296,7 @@ struct prueth { > bool is_switchmode_supported; > unsigned char switch_id[MAX_PHYS_ITEM_ID_LEN]; > int default_vlan; > + spinlock_t vtbl_lock; /* Lock for vtbl in shared memory */ This needs to be kdoc, otherwise: drivers/net/ethernet/ti/icssg/icssg_prueth.h:301: warning: Function parameter or struct member 'vtbl_lock' not described in 'prueth' -- pw-bot: cr