From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04DEACF8840 for ; Fri, 4 Oct 2024 14:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XlcQ35UDL4Ddq3O7GDIWM1FWw0FdIbvAByQr3gyc5YQ=; b=Z2KhnSuVfQl9EDDB6K2wfGZMOg jruyiK2RUrE8ibBYOSXran6PvMPkDpuqKIqVcwSoe7wSaiahE3FQ9+HwFuJhnsuYNspGLtQoMXo8I oFS1u7JM0x7biu6lpY3zaog+LgsPNWk9UOATgAV7YB6o7IHSLmA+yEbcexwO6OIvyiibVlheRuIvz k3K5EugR+j+6seky70OrFPZiZPqoQIruHxcRHGqm1MyZmK+Mg3U/d0WO7VdBxcVlmycRw2HrkQBWP ALIRud5xykcsJC+gDDjSL0ObQa/g907dLtutjKh4XZxytSODxoi0WPIeG+uIq1QNxQ6hopes8ty/6 72kLUcKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swjF8-0000000ClJ0-3WpF; Fri, 04 Oct 2024 14:25:18 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swjDr-0000000Cl2J-2TYa for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 14:24:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3E246A44A4F; Fri, 4 Oct 2024 14:23:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EA08C4CEC6; Fri, 4 Oct 2024 14:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728051838; bh=XlcQ35UDL4Ddq3O7GDIWM1FWw0FdIbvAByQr3gyc5YQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EW5tXoz/DI26Mb4DC6u+NEA1D5nJPnJnxF6+HUeQ9K0vfPfcsM5L1PwlCt7RTWXId 8FZAsjYKIIG3FQ6T2f56dQ4lMsrKcbA6EM0lZW5NEaHYxQkaqVckP2D6H0oNly5pDH tPgaYC71CTZicKhci8PS+pYOEwVPmhfNLipOtKvlRKyB6OcomxMwGNhMQuiEoFQ7K/ BWbJMmMhi+BO/Jfv/imHy7pXZ7nbW+ZPB4lk7m5zer/FKy5K364OozDnZ75fpTvJeI Cl6MFlCcot0YzCQ5e6hrhoMD6zKm1nm5fnXJTobHxjf9PSA7RMPGahIsjuBmbPOjkq /76XwOVwcD6+A== Date: Fri, 4 Oct 2024 07:23:56 -0700 From: Jakub Kicinski To: Shenwei Wang Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , horms@kernel.org, Alexandre Torgue , Jose Abreu , Ong Boon Leong , Wong Vee Khee , Chuah Kim Tatt , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-imx@nxp.com, Serge Semin , Andrew Lunn Subject: Re: [PATCH v4 net] net: stmmac: dwmac4: extend timeout for VLAN Tag register busy bit check Message-ID: <20241004072356.5905e684@kernel.org> In-Reply-To: <20240924205424.573913-1-shenwei.wang@nxp.com> References: <20240924205424.573913-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241004_072359_712693_74A5E28D X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 24 Sep 2024 15:54:24 -0500 Shenwei Wang wrote: > Increase the timeout for checking the busy bit of the VLAN Tag register > from 10=C2=B5s to 500ms. This change is necessary to accommodate scenarios > where Energy Efficient Ethernet (EEE) is enabled. >=20 > Overnight testing revealed that when EEE is active, the busy bit can > remain set for up to approximately 300ms. The new 500ms timeout provides > a safety margin. >=20 > Fixes: ed64639bc1e0 ("net: stmmac: Add support for VLAN Rx filtering") > Reviewed-by: Andrew Lunn > Signed-off-by: Shenwei Wang FTR this was merged to net as commit 4c1b56671b6.