From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ABF6CF885A for ; Fri, 4 Oct 2024 20:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3WaEXPC5SuufFhicuP2SycdqcGrS+CvfcVvqnwNRy5I=; b=FIaQefDlYbeKLuQJb5QhrpLxDM Wskq5V4JNTWLcVbsY3aVZENr6RJIdQJt3pF7vHm9JHH353pJGN8pYsk7+zGWQX9wgdSNSVkPqcFvM UIg6AUUDxxBZCjSsR/csmc1XJnjYXil90zuLfnChqJSbQfUiD+yQEAdI1EgQYBc2ya8EbHK3PlCdC sLgs1qY3Jkl5w3gyZNcjx3U1EpMdCUbaZpjIbXZeN/VscPWikZIwl7h5G+wncW82MM6u3ca7ffNDx oW+NPYeXMZgz8SfRJpLeliGBhB6+YVpmTBV8cQp43SpnA0hKPAuz5AcxF1BXtAdSMsHVufWhLYv5p uBQMIjxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swoc0-0000000E44m-2IHE; Fri, 04 Oct 2024 20:09:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swoaj-0000000E3mH-1prD for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 20:07:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B92E55C5501; Fri, 4 Oct 2024 20:07:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AA11C4CECD; Fri, 4 Oct 2024 20:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728072476; bh=K/PdPwbJ/UqEBqxwToXx1HRmNsPfXx/ybKWz8tMXoJQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DShWE5rfzAd+IofYT4/GcnALtx/f+2bMMXi8y7oUL3wLbLJEU1nZJk/HihEjLYOsF skqQTKle3IQWn8MGVo+BqvkebDgK0K2C8+UuNpbZRAyx+v6mT9NQ1YWc/Nh/b4QzgS ED+gKweq+/fnOWoKfMgPi9sGfBE1585w6Jp1SBoW5y6Z4qdToNjVFbwE8yBbw7MHOu U5pUrcw/paFp+FDSHYRN500HgvU+ptAfVR1KdErkkFqJ4gw07sgd9AawZEqa4OrN9l ONSzesogzUkuQTvioIJ+jx057qw8IyT2VGegfBShSZ6duGeXNoHhOY5Q8sIh/KvBeo oLZ3j+/0AuGiQ== Date: Fri, 4 Oct 2024 13:07:55 -0700 From: Jakub Kicinski To: Simon Horman Cc: MD Danish Anwar , robh@kernel.org, jan.kiszka@siemens.com, dan.carpenter@linaro.org, diogo.ivo@siemens.com, andrew@lunn.ch, pabeni@redhat.com, edumazet@google.com, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com, Vignesh Raghavendra , Roger Quadros Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix race condition for VLAN table access Message-ID: <20241004130755.3ec07538@kernel.org> In-Reply-To: <20241004104610.GD1310185@kernel.org> References: <20241003105940.533921-1-danishanwar@ti.com> <20241003174142.384e51ad@kernel.org> <4f1f0d20-6411-49c8-9891-f7843a504e9c@ti.com> <20241004104610.GD1310185@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241004_130757_554865_F82FCB74 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 4 Oct 2024 11:46:10 +0100 Simon Horman wrote: > > 1. Move the documentation to kdoc - This is will result in checkpatch > > 2. Keep the documentation in kdoc as well as inline - This will result > > in no warnings but duplicate documentation which I don't think is good. > > > > I was not sure which one takes more precedence check patch or kdoc, thus > > put it inline thinking fixing checkpatch might have more weightage. > > > > Let me know what should be done here. > > FWIIW, my preference would be for option 2. Of the two options I'd pick 1, perhaps due to my deeply seated "disappointment" in the quality of checkpatch warnings :) Complaining about missing comment when there's a kdoc is a false positive in my book. But option 2 works, too. I haven't tested it but there's also the option 3 - providing the kdoc inline, something like: + /** @vtbl_lock: Lock for vtbl in shared memory */ + spinlock_t vtbl_lock; Again, no strong preference on which option you choose. kdoc warnings may get emitted during builds so we should avoid them.