From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BA62CF8840 for ; Fri, 4 Oct 2024 17:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t2Iit7fFgKBWP7MqjbwBizfG2cS9Hz2aUvfI/dAalIM=; b=Dlcgq1c3mYxJn8PlN4WuLevYaC uL+gX23zKl0SfPM/pq87aANGoaQtvIftot9PVYNmeAm7wUvXHLhfzZw3Mtg5JYXtvTiNrgh7kvvWi BjHBxZ+p2sqkhMfPLw/3uzIY9Kpdczc4Kly2ZWi3MxLGVD6+ZfGintK95jwjBE7B9pWXlcO1TsF6F A5I8RzJlqXs0IejKVivvvLk8RuAx4IVOyGO6npse2HC8XvWkZuEJy03GwKr/5BvXwSX55lW5YVinH gBhw9zdr0hEtuHMcYVlpibkwK7WpJc12BR/joPwP1ceavMIaX27oQOEYniPpIS1CsOvFlJ1T3fNEj AhnaiexQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swlq3-0000000DRkT-3PC9; Fri, 04 Oct 2024 17:11:35 +0000 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swkwV-0000000DCI2-0DjF for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 16:14:12 +0000 Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-709346604a7so1261165a34.1 for ; Fri, 04 Oct 2024 09:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1728058449; x=1728663249; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t2Iit7fFgKBWP7MqjbwBizfG2cS9Hz2aUvfI/dAalIM=; b=P6pFPWla6bc5qn6d5O2Po/sopbU+zdm0SYZgbvPtTK192zv3MmwT5YG2CyXWzkt9jF spd2JRGf30TzJPSOotRDl3x94uxxUvxuz8hsq6BOPqwaaLQ8GjP1LdPyJ7H4mpEVRo7t qEmsK/8n1A49qeoT4Vzv0pCXAOuyYWFJ6NecCjh6IsbP1Eh352EgROUQ8p77WrDLibX5 MFOt1Fm2lPEsEi9h29YrxiubhGsuVZM3EhE2gJ+2mtXnLVg6Pc591ayfVZEgmhLHJc09 192WxdKyouSda0+20SxFVrEZL0PxfyjlBHtJrHu5CEscc8mXZticwypoWbKkESzIkrhh SSdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728058449; x=1728663249; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t2Iit7fFgKBWP7MqjbwBizfG2cS9Hz2aUvfI/dAalIM=; b=ptGADb5TEpTreEiUwP3dLtaKRLSHQ0qQ7V5VXvU1ctkgEOHeFhBp+yAMTkUAtbuDKv K77XMwZZdWrcFCbGVoLiWS7na983eRGqsEItMTBbJKt9n85H7DTvunS9gBfFk5QQOOBq wLqlCfREY77ubrXHTkzyL79yN15uW4puWNKxJJG9kAKBAUrzhdb76dV0SNbqmA6ruaON oQQ6x3BYIwJgwcrTtmzU50bL9GUVULkuVtUc56TiaEqbqh2fQOdvB+M6T+PiGGzyOW8a vVBgi0KxTpYI+1LG2oX7aKtpsf3XZG8yH1H61UZ1Xj2bxOExsEDfwv44j7Pfz/fgoV8A 5sBA== X-Forwarded-Encrypted: i=1; AJvYcCU8tK9CJBidxOgziIa+4MbKBq75LpnCfcWlsCMrkZHGHFd46kAikYmWzT8zpp0L7olCOAaziAhv6QmkaKSE9bwZ@lists.infradead.org X-Gm-Message-State: AOJu0Yy1Ih9bPImIU+LEgh3cD61WUr8SL9s4PKqw8QvTjnwZCT7NT1z1 1h1Ad6KxDUI+hymgTMaR2xWmKTwpAe8+0TD2F+nPqyfddRicJreToG303R5JCko= X-Google-Smtp-Source: AGHT+IHNZtp0RdmKR9tPX6Tz5fe0BbWkd+TEdNBUAWZwajlgqxRX7pqiGzGGB5dusaMWe6dfhlFLAQ== X-Received: by 2002:a05:6358:9889:b0:1a5:b0f7:251 with SMTP id e5c5f4694b2df-1c2b83ad8a5mr126598055d.24.1728058449246; Fri, 04 Oct 2024 09:14:09 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba46d0fddsm534476d6.5.2024.10.04.09.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 09:14:08 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1swkwS-00DT5g-CE; Fri, 04 Oct 2024 13:14:08 -0300 Date: Fri, 4 Oct 2024 13:14:08 -0300 From: Jason Gunthorpe To: Yang Shi Cc: Nicolin Chen , james.morse@arm.com, will@kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size Message-ID: <20241004161408.GJ2456194@ziepe.ca> References: <20241002175514.1165299-1-yang@os.amperecomputing.com> <1c9767e1-4d05-4650-bc14-65a18fc63cc2@os.amperecomputing.com> <20241002194004.GT1369530@ziepe.ca> <20241003111603.GU1369530@ziepe.ca> <43c2227a-71c9-4cbf-bfec-5a2fbf698f27@os.amperecomputing.com> <20241004124343.GE2456194@ziepe.ca> <26ee77f2-720d-4e16-9f6c-fa15fd13d305@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26ee77f2-720d-4e16-9f6c-fa15fd13d305@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241004_091411_110723_E4BD78C4 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 04, 2024 at 09:05:46AM -0700, Yang Shi wrote: > > > On 10/4/24 5:43 AM, Jason Gunthorpe wrote: > > On Thu, Oct 03, 2024 at 08:31:23AM -0700, Yang Shi wrote: > > > If I understand correctly, the check is mainly used to avoid the u64 -> u32 > > > overflow. This check guarantee no overflow. If some crazy hardware really > > > requests that large memory, the allocation will fail. > > Sure, the kalloc will print a warn on anyhow if it is too big > > Thank you. Will spin a new revision. Oh wait a sec, it is not so simple, the 31 is too big because the multiply will overflow or truncate to size_t too. This is why I picked something lower. Jason