From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7CD0CF8850 for ; Fri, 4 Oct 2024 17:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l94MYM9aLPoFsocgRBRMqaai5hzItvu6ewJPpEKL7nk=; b=OTqx0n3YIi5pWdsylPmLuRbT7H h8Gb50ARkRbtR8yPE6fT5xJpFIjJckFDigpILp7aiWS2lk4tVVSK8Nyn/cHh1nSkVbT5rf/RMIuqF gdXDqWkUdMnTJRKEiwppUoS8cH5SGzCwTagW57BSYWx33wlGSziyBNkDWpA0zdZC1gR7KOJh+xn6a zBW6VBxFdVpWq9sVPjNLkiNH5iBAptHxLxcDwqotZZU/GSiq4wUnbYaydprtQc0xBuHzsAiASSvov UixHYFTvTKWwm7+dJbd4mIENoFhXAx+u67s7tSyQx1bLp8/BQCoNMyRFGyASthXSuMkZ+f2Yrl1Na fVCmaqNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swlqM-0000000DS2e-1WkD; Fri, 04 Oct 2024 17:11:54 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swkyR-0000000DCeO-2AZf for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 16:16:13 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id BE61520008; Fri, 4 Oct 2024 16:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1728058569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l94MYM9aLPoFsocgRBRMqaai5hzItvu6ewJPpEKL7nk=; b=QNpaTKOzl/37uWbR/6MeQsbwPIWLvqndTwQ++ICUhcct7Pw1conr08/X46fycgOrW/c1EZ hBlr1Xa3n6BrNPtFJmHfYxRiJAd+DikF4FdXXTcqPuegnspwpahzwtXXSXlf4P4p2Xpfn4 zVZmet0cMxUZUdTNi7Ui6nO5s96JM5q7WJczt8PMOvDgn7DrLbrbQvcm/MrzRh582Y1qz1 Be2czEbCDSI6fVAOBM9/AfmTtJl8K/9ApxRts9+uTctBFg62jtF5B3GMiE5+7W0SmVTWx7 B9Ws1iFtsoWLoStLhjPIfvlJzGKJ91qnSTkwYgx3XWDN0RYijr4FrdhWIkn9DA== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?q?Marek=20Beh=C3=BAn?= , =?UTF-8?q?K=C3=B6ry=20Maincent?= , Oleksij Rempel Subject: [PATCH net-next v2 4/9] net: phy: lxt: Mark LXT973 PHYs as having a broken isolate mode Date: Fri, 4 Oct 2024 18:15:54 +0200 Message-ID: <20241004161601.2932901-5-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20241004161601.2932901-1-maxime.chevallier@bootlin.com> References: <20241004161601.2932901-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241004_091611_728162_102A62F8 X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Testing showed that PHYs from the LXT973 family have a non-working isolate mode, where the MII lines aren't set in high-impedance as would be expected. Prevent isolating these PHYs. Signed-off-by: Maxime Chevallier --- V2 : Use callback instead of flag drivers/net/phy/lxt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c index e3bf827b7959..45f92451bee8 100644 --- a/drivers/net/phy/lxt.c +++ b/drivers/net/phy/lxt.c @@ -334,6 +334,7 @@ static struct phy_driver lxt97x_driver[] = { .read_status = lxt973a2_read_status, .suspend = genphy_suspend, .resume = genphy_resume, + .can_isolate = genphy_no_isolate, }, { .phy_id = 0x00137a10, .name = "LXT973", @@ -344,6 +345,7 @@ static struct phy_driver lxt97x_driver[] = { .config_aneg = lxt973_config_aneg, .suspend = genphy_suspend, .resume = genphy_resume, + .can_isolate = genphy_no_isolate, } }; module_phy_driver(lxt97x_driver); -- 2.46.1