From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B902CF8850 for ; Fri, 4 Oct 2024 17:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dp0DBhFARDfArCSdgYYrzM2jCoA7FW/8kA7NOUCl2/c=; b=qXI0mST2DCYKZPU2rOQ5n9rd40 kB790osY7nRRsf6peLTsCv1ayWfrM9Z84ep3J2L8qEyZWajmkvKV38ER7NXxACEvGwf2coKUnK+0N rHMrZCV2fgEaNuD0mem6t2+fnadiTzLM6ZFc/+06X/B312HoEHG0S+qh2SFS80CWF5Ef4/BG/Akam uaYi3I/pmJzanpvPPNirYkfC2RGQ6KxA0LzjZoTO131FFPGFwb19tvZuW/2/qSK8kEJDfaw3LYusk d/Z8cuPDP24DYrSTdqHGHCRDMiXgsk358oRdQfGZIVNb76razmbl7MyO86glSWLe8oCLWQVL7tOj3 Ops4ZR2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swlqX-0000000DSDT-2Jhy; Fri, 04 Oct 2024 17:12:05 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swkyS-0000000DCfM-0NqB for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 16:16:13 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id B969C2000C; Fri, 4 Oct 2024 16:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1728058570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dp0DBhFARDfArCSdgYYrzM2jCoA7FW/8kA7NOUCl2/c=; b=errC3PZ2jBRAdl7toejcmwvgAChfwyA5o3tRl8Q6lgQT5wNZf9YvCiIg3IWTthRtutbJxv gYTwTb0oG60PIMYz00uHYDPjkXEK08mRuLtjugUhc9YWBcr/kHO8BXGY9q4LT8KypSUpFC nu5BYhd3TSqqPN02LSPZfWPP8qqLsyg42oSf9fPzTAZqx3XoMyvMcqkHdq8RE1bAf1kRTv qWFB8UJS9m4f/QVKtD3C48c/kah5AcJ3ZJuhfZ7DlF/TFMF4CMDIrngvyUovzJVKUIbcsi OJzPB2k0jk53GRaP7S/JK7PUt9FCiwjUoe9+tJbVYXBMWsAUypVOvV/YsMokwA== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?q?Marek=20Beh=C3=BAn?= , =?UTF-8?q?K=C3=B6ry=20Maincent?= , Oleksij Rempel Subject: [PATCH net-next v2 5/9] net: phy: marvell10g: 88x3310 and 88x3340 don't support isolate mode Date: Fri, 4 Oct 2024 18:15:55 +0200 Message-ID: <20241004161601.2932901-6-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20241004161601.2932901-1-maxime.chevallier@bootlin.com> References: <20241004161601.2932901-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241004_091612_347514_FF923D34 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 88x3310 and 88x3340 PHYs don't support the isolation mode, regardless of the MII mode being used (SGMII/1000BaseX/2500BaseX/5GBaseR/10GBaseR). Report this through the .can_isolate() callback. This was confirmed on the 88x3310 on a MacchiatoBin. Signed-off-by: Maxime Chevallier --- V2 : Use callback instead of flag drivers/net/phy/marvell10g.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c index 6642eb642d4b..c1a471f55cd4 100644 --- a/drivers/net/phy/marvell10g.c +++ b/drivers/net/phy/marvell10g.c @@ -1422,6 +1422,7 @@ static struct phy_driver mv3310_drivers[] = { .set_loopback = genphy_c45_loopback, .get_wol = mv3110_get_wol, .set_wol = mv3110_set_wol, + .can_isolate = genphy_no_isolate, }, { .phy_id = MARVELL_PHY_ID_88X3310, @@ -1441,6 +1442,7 @@ static struct phy_driver mv3310_drivers[] = { .set_tunable = mv3310_set_tunable, .remove = mv3310_remove, .set_loopback = genphy_c45_loopback, + .can_isolate = genphy_no_isolate, }, { .phy_id = MARVELL_PHY_ID_88E2110, -- 2.46.1