From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86B0ECF8840 for ; Fri, 4 Oct 2024 17:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cNo54GXkVm6CFb67YgwSrwHjh7UB2oNyFIVxqdJOafA=; b=k8b583jU48HX340Sx56xioRsIs kpGAEASkA5pPjl1+1rPofyC9V4qZRp/mhH01zSRFvi0J99JpXdjJi2lkX/Q8tl3YVCpE8jr1VkRhl Nu0lO7HhHD9X8UA64ULtqvTyFXpJU/L7hYoS4C5gFpqXTzejib1pSwl0b+3Fvp0vtJaZFAoHQ7lIx Ia3hj5s7GiJZYLo1bnrC89QCybWV+NLZ8aVOE7G559ZwvXhoQCO0yLjX+NjJXQ9mTHyd3lXKaMlDA Nqlmr4ZIpWUui2Vfr5zNf7BkP4RW6UvR/ZfeKGiCHUaQFt/8CntxHlbchAm9S9q9ECwDOGlT/zGai QA5i/cew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swls2-0000000DTJO-2aPL; Fri, 04 Oct 2024 17:13:38 +0000 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swlN0-0000000DJ7x-2TjN for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 16:41:35 +0000 Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-7a99e8ad977so160170985a.3 for ; Fri, 04 Oct 2024 09:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1728060092; x=1728664892; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cNo54GXkVm6CFb67YgwSrwHjh7UB2oNyFIVxqdJOafA=; b=ZxLXT50STD8XZ2dF5df/tgj1VOiES1bjxoaNrz1sKd0gHaUSquHklYHK0a9Pn9dsh5 cHUFfcZL9h9WWDgPUPqmbm6toJtF4LvjvKa4c7apUTe1V9yPRNiU5s8DEOh/WTeZTj+z I3stETJSS/FqkYFrDDD8P+NJ26yQOP0I4+O/fZxavdf3dP1VfhuPr6CwX34zJyUBk4OS 7rMyAv96RdLJ6tGqjMUIlEUgInuhW9K2WVHR+1NZnlsQZa1urvalq0B5Mi3APad/0oCH ah6jVz3Kksy14WRCXFMNMLGEN5lYVm/JeAGyIOle81oUJ6YJpsbIDosJlRvP1ybkvesu rhlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728060092; x=1728664892; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cNo54GXkVm6CFb67YgwSrwHjh7UB2oNyFIVxqdJOafA=; b=rqWsqeJdUI6wtH3Y+A0/erm6EWugBYT/Hq4Hk/pwX+ZH4BS4zi3R70/eyUMO5aey1g n44VPB4WXpFcINyMYWOAbekWdzh9SlEuWNuu7bs1hzjeLCPSn1RRPwSWeboPe28zFZGN +4WsVaATMKpQurqxSQrYqXnPikElzY6jeAsWTN9MYS2Ve5zEIPWvmMPR0EEv4Xf/0VDi ZCNSiR4aD+472q5PCvuTNoh04QxavIIBNNESYRJWTh1yRFOcfj1mil3wSyd3UgZGc5l+ 0/WX/fYs0KjpiY8wrTdtr3piYIG7oOut6aP2e4P9xVzf97iWH52NATXPwdp6epEnL9c/ Mdtw== X-Forwarded-Encrypted: i=1; AJvYcCVfoNfXmpPji9zHWd2XPVBGQqBwZB09KkFjW/f3PWTafIG4JuBVkdz1Mqu3k3LIYqMui7djpC63QJDFlkJwl5p7@lists.infradead.org X-Gm-Message-State: AOJu0Yxsz7whKeotBbK6Fmw8fziBqKwTRzjCZmhzqVbmexJqyAgz6sNm s2DGAlL0qS+o6UUDP+QCmdvo01Eq4i9+BNSx5ZTf+MAxISEgbiYUqGZWaiEAUcY= X-Google-Smtp-Source: AGHT+IHxS1rReuR3uNB96tDmATg9U/Vxhje8tNVMGz45YlEaBfb5RwW5aZT+p2GKniBLo3EodEd+AA== X-Received: by 2002:a05:620a:4611:b0:7ab:36c7:b9f6 with SMTP id af79cd13be357-7ae6f44c77cmr465612585a.31.1728060091222; Fri, 04 Oct 2024 09:41:31 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae75615955sm434685a.19.2024.10.04.09.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 09:41:30 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1swlMw-00DXzM-Be; Fri, 04 Oct 2024 13:41:30 -0300 Date: Fri, 4 Oct 2024 13:41:30 -0300 From: Jason Gunthorpe To: Yang Shi Cc: Nicolin Chen , james.morse@arm.com, will@kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size Message-ID: <20241004164130.GK2456194@ziepe.ca> References: <20241002194004.GT1369530@ziepe.ca> <20241003111603.GU1369530@ziepe.ca> <43c2227a-71c9-4cbf-bfec-5a2fbf698f27@os.amperecomputing.com> <20241004124343.GE2456194@ziepe.ca> <26ee77f2-720d-4e16-9f6c-fa15fd13d305@os.amperecomputing.com> <20241004161408.GJ2456194@ziepe.ca> <7ad66e5f-d6f8-4144-8ab2-d4ea499e2665@os.amperecomputing.com> <9f28e3b3-a47d-4a83-911d-fd7a6b95fd60@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f28e3b3-a47d-4a83-911d-fd7a6b95fd60@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241004_094134_649160_E9079EDF X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 04, 2024 at 09:37:10AM -0700, Yang Shi wrote: > > size = num_sids * sizeof(struct arm_smmu_ste); > + if (size > SIZE_4G) > + return -EINVAL; If you want to do it like that then 'size >= SIZE_MAX' is the right expression Jason