From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95454CFB43F for ; Mon, 7 Oct 2024 08:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mJKNfHc7055rC/FvjwJstSqwovUh7KyChDgu1RZK00w=; b=jeM4LkEXNxVeCUBkQOmfPq+B0r qt6dWdgdKcDR/SDUTuNKH3+eh9tFF0hAC2favUFqkls2PLtshz9yZ9cBxPZAnE2X2EVEjRyXXNtst N22YfnLZJxzzvK/rPz6ONPjPxC4k+ddqhiTk7uDqiIROIfYqPT6ZMxUuyXxOmKod6s3wGC+YVPQHx ixeeiIyAt/QQ0v6mK6CEOt74wPO5ZZrIFHHBh91Nu21wKk/K3m8ReE+7DC+xWqf3f+BkEihUBjQYB 1fIMW+GgIQ7nYyMD6KP2ug2xyaz8n7yXI+8mpEt5xi3SxI7UP1/5X/4fwrCY9yyavGB1S2zP2ZFpn d0X3fIiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxj8u-00000001m3d-3hZk; Mon, 07 Oct 2024 08:31:00 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxj7c-00000001lwa-3FwT for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2024 08:29:42 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C4B7260006; Mon, 7 Oct 2024 08:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1728289778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mJKNfHc7055rC/FvjwJstSqwovUh7KyChDgu1RZK00w=; b=bX4DeVpGOTU5P/cyyrerv2kzqbGZRmanFHCu6bGKJPhVg/KQDERYtTZ+6K2bxrr3yxAY4J kEP0aU6KnjQ+L2RZFEGnqtArUMaG/CqCuLpxglp8eJ4dFaVGQyO1OR1e/R1WmZDHQ4PLIa zRSLYwsSm/jT2jomOyfEc87rpeRaBLExQjiGLL/LHVtrCXLD/jRI/KcBqaFFxcRptjGgRt 8EHfVA2NQrIp5PSl1OkpHkkKlKNifLA2Kh4Ki/LC8vHkoC9WC6GlNzLeruIe/1cfZdT5o4 LSVDZBm9b5tOM+CE7IcRqCIytc1th6utFKU1s0xAVvC6KG1wbP43ffl6n8CWbg== Date: Mon, 7 Oct 2024 12:27:20 +0200 From: Maxime Chevallier To: Andrew Lunn Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Marek =?UTF-8?B?QmVow7pu?= , =?UTF-8?B?S8O2cnk=?= Maincent , Oleksij Rempel Subject: Re: [PATCH net-next v2 3/9] net: phy: Allow PHY drivers to report isolation support Message-ID: <20241007122720.2e1eba76@device-21.home> In-Reply-To: References: <20241004161601.2932901-1-maxime.chevallier@bootlin.com> <20241004161601.2932901-4-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_012940_995430_9383F663 X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 4 Oct 2024 20:20:10 +0200 Andrew Lunn wrote: > > +static bool phy_can_isolate(struct phy_device *phydev) > > +{ > > + if (phydev->drv && phydev->drv->can_isolate) > > + return phydev->drv->can_isolate(phydev); > > + > > + return true; > > Reading Russells comment, and the fact that this feature is nearly > unused, so we have no idea how well PHYs actually support this, i > would flip the logic. Default to false. A PHY driver needs to actively > sign up to supporting isolation, with the understanding it has been > tested on at least one board with two or more PHYs. Fair point, I'll reverse the logic. Thanks, Maxime