Re: [PATCH net-next v2 3/9] net: phy: Allow PHY drivers to report isolation support

Andrew Lunn
2024-10-04T18:24:02Z

> +static bool phy_can_isolate(struct phy_device *phydev)
> +{
> + if (phydev->drv && phydev->drv->can_isolate)
> + return phydev->drv->can_isolate(phydev);
> +
> + return true;

Reading Russells comment, and the fact that this feature is nearly
unused, so we have no idea how well PHYs actually support this, i
would flip the logic. Default to false. A PHY driver needs to actively
sign up to supporting isolation, with the understanding it has been
tested on at least one board with two or more PHYs.

Andrew